mirror of
https://github.com/moodle/moodle.git
synced 2025-08-04 16:36:37 +02:00
minor fix
This commit is contained in:
parent
c86caae78a
commit
cd20e11c28
1 changed files with 9 additions and 5 deletions
|
@ -211,8 +211,6 @@ if ($perpageurl = optional_param('perpage', 0, PARAM_INT)) {
|
|||
$perpage = $perpageurl;
|
||||
}
|
||||
|
||||
/// setting up groups
|
||||
|
||||
// Prepare language strings
|
||||
$strsortasc = get_string('sortasc', 'grades');
|
||||
$strsortdesc = get_string('sortdesc', 'grades');
|
||||
|
@ -222,6 +220,7 @@ $baseurl = 'report.php?id='.$courseid.'&perpage='.$perpage.'&report=grad
|
|||
// base url for paging
|
||||
$pbarurl = 'report.php?id='.$courseid.'&perpage='.$perpage.'&report=grader&';
|
||||
|
||||
/// setting up groups
|
||||
$groupsql = '';
|
||||
$groupwheresql = '';
|
||||
$group_selector = null;
|
||||
|
@ -631,13 +630,15 @@ foreach ($users as $userid => $user) {
|
|||
}
|
||||
}
|
||||
|
||||
// Prepare icons for when quickgrading or quickfeedback are switched off
|
||||
$icons_html = '<div class="grade_icons">';
|
||||
|
||||
if (!$quickgrading) {
|
||||
// If quickgrading is off, print an edit icon
|
||||
if (!$quickgrading) {
|
||||
$icons_html .= grade_get_icons($element, $gtree, array('edit'));
|
||||
}
|
||||
|
||||
// If quickfeedback is on, print an input element
|
||||
if ($showfeedback && $quickfeedback) {
|
||||
$studentshtml .= '<input size="6" type="text" name="feedback_'.$userid.'_'.$item->id.'" value="'. s($grade->feedback) . '"/>';
|
||||
|
||||
|
@ -650,7 +651,10 @@ foreach ($users as $userid => $user) {
|
|||
}
|
||||
|
||||
$icons_html .= '</div>';
|
||||
|
||||
if (!$quickfeedback || !$quickgrading) {
|
||||
$studentshtml .= $icons_html;
|
||||
}
|
||||
|
||||
} else {
|
||||
// finalgrades[$userid][$itemid] could be null because of the outer join
|
||||
|
@ -794,7 +798,7 @@ if ($USER->gradeediting) {
|
|||
echo $reporthtml;
|
||||
|
||||
// print submit button
|
||||
if ($USER->gradeediting) {
|
||||
if ($USER->gradeediting && ($quickfeedback || $quickgrading)) {
|
||||
echo '<div class="submit"><input type="submit" value="'.get_string('update').'" /></div>';
|
||||
echo '</div></form>';
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue