MDL-79863 qtype_ordering: Moodle.2x qtype/ordering use standard message to report DB insert/update errors

This commit is contained in:
Gordon Bateson 2013-07-07 20:20:07 +09:00 committed by Mathew May
parent 3a109f946a
commit cd7f80ef5c

View file

@ -86,8 +86,7 @@ class qtype_ordering extends question_type {
if ($answer->id = array_shift($answerids)) { if ($answer->id = array_shift($answerids)) {
if (! $DB->update_record('question_answers', $answer)) { if (! $DB->update_record('question_answers', $answer)) {
$a = 'question_answers (id='.$answer->id.')'; $result->error = get_string('cannotupdaterecord', 'error', 'question_answers (id='.$answer->id.')');
$result->error = get_string('cannotupdaterecord', 'error', $a);
return $result; return $result;
} }
} else { } else {
@ -111,8 +110,7 @@ class qtype_ordering extends question_type {
// add/update $options for this ordering question // add/update $options for this ordering question
if ($options->id = $DB->get_field('question_ordering', 'id', array('question' => $question->id))) { if ($options->id = $DB->get_field('question_ordering', 'id', array('question' => $question->id))) {
if (! $DB->update_record('question_ordering', $options)) { if (! $DB->update_record('question_ordering', $options)) {
$a = 'question_ordering (id='.$options->id.')'; $result->error = get_string('cannotupdaterecord', 'error', 'question_ordering (id='.$options->id.')');
$result->error = get_string('cannotupdaterecord', 'error', $a);
return $result; return $result;
} }
} else { } else {