moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-70552 core_message: Show popup for teachers when anonymous

Browse source 
user completed feedback.
This commit is contained in:
Ilya Tregubov 2021-01-13 09:38:45 +02:00
parent a2fda1289f
commit d208bc5353
3 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/classes/message/message.php
View file

@ -132,6 +132,9 @@ class message {
/** @var mixed Custom data to be passed to the message processor. Must be serialisable using json_encode(). */ /** @var mixed Custom data to be passed to the message processor. Must be serialisable using json_encode(). */
private $customdata; private $customdata;
/** @var boolean If message is anonymous. */
private $anonymous;
/** @var array a list of properties that is allowed for each message. */ /** @var array a list of properties that is allowed for each message. */
private $properties = array( private $properties = array(
'courseid', 'courseid',
@ -158,6 +161,7 @@ class message {
'timecreated', 'timecreated',
'fullmessagetrust', 'fullmessagetrust',
'customdata', 'customdata',
'anonymous',
); );
/** @var array property to store any additional message processor specific content */ /** @var array property to store any additional message processor specific content */

13
message/output/popup/message_output_popup.php
View file

@ -49,12 +49,15 @@ class message_output_popup extends message_output {
global $DB; global $DB;
// Prevent users from getting popup notifications from themselves (happens with forum notifications). // Prevent users from getting popup notifications from themselves (happens with forum notifications).
if ($eventdata->userfrom->id != $eventdata->userto->id && $eventdata->notification) { if ($eventdata->notification) {
if (!$DB->record_exists('message_popup_notifications', ['notificationid' => $eventdata->savedmessageid])) { if (($eventdata->userfrom->id != $eventdata->userto->id) ||
$record = new stdClass(); (isset($eventdata->anonymous) && $eventdata->anonymous)) {
$record->notificationid = $eventdata->savedmessageid; if (!$DB->record_exists('message_popup_notifications', ['notificationid' => $eventdata->savedmessageid])) {
$record = new stdClass();
$record->notificationid = $eventdata->savedmessageid;
$DB->insert_record('message_popup_notifications', $record); $DB->insert_record('message_popup_notifications', $record);
}
} }
} }

3
mod/feedback/lib.php
View file

@ -2639,6 +2639,7 @@ function feedback_send_email($cm, $feedback, $course, $user, $completed = null)
]; ];
if ($feedback->anonymous == FEEDBACK_ANONYMOUS_NO) { if ($feedback->anonymous == FEEDBACK_ANONYMOUS_NO) {
$eventdata = new \core\message\message(); $eventdata = new \core\message\message();
$eventdata->anonymous = false;
$eventdata->courseid = $course->id; $eventdata->courseid = $course->id;
$eventdata->name = 'submission'; $eventdata->name = 'submission';
$eventdata->component = 'mod_feedback'; $eventdata->component = 'mod_feedback';
@ -2661,6 +2662,7 @@ function feedback_send_email($cm, $feedback, $course, $user, $completed = null)
message_send($eventdata); message_send($eventdata);
} else { } else {
$eventdata = new \core\message\message(); $eventdata = new \core\message\message();
$eventdata->anonymous = true;
$eventdata->courseid = $course->id; $eventdata->courseid = $course->id;
$eventdata->name = 'submission'; $eventdata->name = 'submission';
$eventdata->component = 'mod_feedback'; $eventdata->component = 'mod_feedback';
@ -2726,6 +2728,7 @@ function feedback_send_email_anonym($cm, $feedback, $course) {
} }
$eventdata = new \core\message\message(); $eventdata = new \core\message\message();
$eventdata->anonymous = true;
$eventdata->courseid = $course->id; $eventdata->courseid = $course->id;
$eventdata->name = 'submission'; $eventdata->name = 'submission';
$eventdata->component = 'mod_feedback'; $eventdata->component = 'mod_feedback';