moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-67673 phpunit: Fix the return type of template methods

Browse source 
All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...
This commit is contained in:
Eloy Lafuente (stronk7) 2020-08-02 10:59:12 +02:00
parent c611109ed7
commit d81a94807b
421 changed files with 531 additions and 531 deletions
Download patch file Download diff file Expand all files Collapse all files

2
availability/condition/completion/tests/condition_test.php
View file

@ -52,7 +52,7 @@ class availability_completion_condition_testcase extends advanced_testcase {
/**
* Load required classes.
*/
public function setUp() {
public function setUp(): void {
availability_completion\condition::wipe_static_cache();
}

2
availability/condition/date/tests/condition_test.php
View file

@ -38,7 +38,7 @@ class availability_date_condition_testcase extends advanced_testcase {
/**
* Load required classes.
*/
public function setUp() {
public function setUp(): void {
// Load the mock info class so that it can be used.
global $CFG;
require_once($CFG->dirroot . '/availability/tests/fixtures/mock_info.php');

2
availability/condition/group/tests/condition_test.php
View file

@ -37,7 +37,7 @@ class availability_group_condition_testcase extends advanced_testcase {
/**
* Load required classes.
*/
public function setUp() {
public function setUp(): void {
// Load the mock info class so that it can be used.
global $CFG;
require_once($CFG->dirroot . '/availability/tests/fixtures/mock_info.php');

2
availability/condition/grouping/tests/condition_test.php
View file

@ -37,7 +37,7 @@ class availability_grouping_condition_testcase extends advanced_testcase {
/**
* Load required classes.
*/
public function setUp() {
public function setUp(): void {
// Load the mock info class so that it can be used.
global $CFG;
require_once($CFG->dirroot . '/availability/tests/fixtures/mock_info.php');

2
availability/condition/profile/tests/condition_test.php
View file

@ -45,7 +45,7 @@ class availability_profile_condition_testcase extends advanced_testcase {
/** @var \core_availability\info Current info */
private $info;
public function setUp() {
public function setUp(): void {
global $DB, $CFG;
$this->resetAfterTest();

2
availability/tests/info_test.php
View file

@ -36,7 +36,7 @@ use core_availability\info_section;
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class info_testcase extends advanced_testcase {
public function setUp() {
public function setUp(): void {
// Load the mock condition so that it can be used.
require_once(__DIR__ . '/fixtures/mock_condition.php');
}

2
availability/tests/tree_test.php
View file

@ -35,7 +35,7 @@ defined('MOODLE_INTERNAL') || die();
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class tree_testcase extends \advanced_testcase {
public function setUp() {
public function setUp(): void {
// Load the mock classes so they can be used.
require_once(__DIR__ . '/fixtures/mock_condition.php');
require_once(__DIR__ . '/fixtures/mock_info.php');