MDL-67673 phpunit: Fix the return type of template methods

All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...

calendar/tests/calendartype_test.php

@@ -58,7 +58,7 @@ class core_calendar_type_testcase extends advanced_testcase {
     /**
      * Test set up.
      */
-    protected function setUp() {
+    protected function setUp(): void {
         // The user we are going to test this on.
         $this->user = self::getDataGenerator()->create_user();
         self::setUser($this->user);

calendar/tests/container_test.php

@@ -47,7 +47,7 @@ class core_calendar_container_testcase extends advanced_testcase {
     /**
      * Test setup.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest();
         $this->setAdminUser();
     }

calendar/tests/events_related_objects_cache_test.php

@@ -41,7 +41,7 @@ class core_calendar_events_related_objects_cache_testcase extends advanced_testc
     /**
      * Tests set up
      */
-    protected function setUp() {
+    protected function setUp(): void {
         $this->resetAfterTest();
     }
 

calendar/tests/events_test.php

@@ -48,7 +48,7 @@ class core_calendar_events_testcase extends advanced_testcase {
     /**
      * Test set up.
      */
-    protected function setUp() {
+    protected function setUp(): void {
         global $USER;
         // The user we are going to test this on.
         $this->setAdminUser();

calendar/tests/externallib_test.php

@@ -43,7 +43,7 @@ class core_calendar_externallib_testcase extends externallib_advanced_testcase {
     /**
      * Tests set up
      */
-    protected function setUp() {
+    protected function setUp(): void {
         global $CFG;
         require_once($CFG->dirroot . '/calendar/externallib.php');
     }

calendar/tests/lib_test.php

@@ -38,7 +38,7 @@ class core_calendar_lib_testcase extends advanced_testcase {
     /**
      * Tests set up
      */
-    protected function setUp() {
+    protected function setUp(): void {
         $this->resetAfterTest();
     }
 

calendar/tests/local_api_test.php

@@ -40,7 +40,7 @@ class core_calendar_local_api_testcase extends advanced_testcase {
     /**
      * Tests set up
      */
-    protected function setUp() {
+    protected function setUp(): void {
         $this->resetAfterTest();
     }
 

calendar/tests/privacy_test.php

@@ -47,7 +47,7 @@ class core_calendar_privacy_testcase extends provider_testcase {
     /**
      * Overriding setUp() function to always reset after tests.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

calendar/tests/rrule_manager_test.php

@@ -46,7 +46,7 @@ class core_calendar_rrule_manager_testcase extends advanced_testcase {
     /**
      * Set up method.
      */
-    protected function setUp() {
+    protected function setUp(): void {
         global $DB;
         $this->resetAfterTest();
 

calendar/tests/std_proxy_test.php

@@ -38,7 +38,7 @@ class core_calendar_std_proxy_testcase extends advanced_testcase {
      */
     public $objects;
 
-    public function setUp() {
+    public function setUp(): void {
         $this->objects = [
             1 => (object) [
                 'member1' => 'Hello',