MDL-67673 phpunit: Fix the return type of template methods

All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...
This commit is contained in:
Eloy Lafuente (stronk7) 2020-08-02 10:59:12 +02:00
parent c611109ed7
commit d81a94807b
421 changed files with 531 additions and 531 deletions

View file

@ -36,7 +36,7 @@ class format_weeks_observer_testcase extends advanced_testcase {
/**
* Test setup.
*/
public function setUp() {
public function setUp(): void {
$this->resetAfterTest();
}

View file

@ -37,7 +37,7 @@ use PHPUnit\Framework\MockObject\MockObject;
*/
class core_course_category_hooks_testcase extends \advanced_testcase {
protected function setUp() {
protected function setUp(): void {
$this->resetAfterTest();
$this->setAdminUser();
}

View file

@ -32,7 +32,7 @@ class core_course_category_testcase extends advanced_testcase {
protected $roles;
protected function setUp() {
protected function setUp(): void {
parent::setUp();
$this->resetAfterTest();
$user = $this->getDataGenerator()->create_user();

View file

@ -40,7 +40,7 @@ class core_course_customfield_testcase extends advanced_testcase {
/**
* Set up
*/
protected function setUp() {
protected function setUp(): void {
parent::setUp();
$this->resetAfterTest();
$this->setAdminUser();

View file

@ -36,7 +36,7 @@ class core_course_events_testcase extends advanced_testcase {
/**
* Tests set up
*/
protected function setUp() {
protected function setUp(): void {
global $CFG;
require_once($CFG->dirroot . '/course/lib.php');
$this->resetAfterTest();

View file

@ -42,7 +42,7 @@ class core_course_externallib_testcase extends externallib_advanced_testcase {
/**
* Tests set up
*/
protected function setUp() {
protected function setUp(): void {
global $CFG;
require_once($CFG->dirroot . '/course/externallib.php');
}

View file

@ -53,7 +53,7 @@ class course_search_testcase extends advanced_testcase {
*/
protected $customfieldareaid = null;
public function setUp() {
public function setUp(): void {
$this->resetAfterTest(true);
set_config('enableglobalsearch', true);