MDL-67673 phpunit: Fix the return type of template methods

All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...

message/output/airnotifier/tests/externallib_test.php

@@ -42,7 +42,7 @@ class message_airnotifier_external_testcase extends externallib_advanced_testcas
     /**
      * Tests set up
      */
-    protected function setUp() {
+    protected function setUp(): void {
         global $CFG;
         require_once($CFG->dirroot . '/message/output/airnotifier/externallib.php');
     }

message/output/airnotifier/tests/privacy_test.php

@@ -38,7 +38,7 @@ class message_airnotifier_testcase extends provider_testcase {
     /**
      * Basic setup for these tests.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

message/output/email/tests/privacy_test.php

@@ -34,7 +34,7 @@ class message_email_testcase extends provider_testcase {
     /**
      * Basic setup for these tests.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

message/output/jabber/tests/privacy_test.php

@@ -36,7 +36,7 @@ class message_jabber_testcase extends provider_testcase {
     /**
      * Basic setup for these tests.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

message/output/popup/tests/api_test.php

@@ -46,7 +46,7 @@ class message_popup_api_testcase extends advanced_testcase {
      *
      * This is executed before running any test in this file.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->preventResetByRollback(); // Messaging is not compatible with transactions.
         $this->messagesink = $this->redirectMessages();
         $this->resetAfterTest();

message/output/popup/tests/externallib_test.php

@@ -44,7 +44,7 @@ class message_popup_externallib_testcase extends advanced_testcase {
      *
      * This is executed before running any test in this file.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->preventResetByRollback(); // Messaging is not compatible with transactions.
         $this->messagesink = $this->redirectMessages();
         $this->resetAfterTest();

message/tests/events_test.php

@@ -44,7 +44,7 @@ class core_message_events_testcase extends core_message_messagelib_testcase {
      *
      * This is executed before running any test in this file.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest();
     }
 

message/tests/externallib_test.php

@@ -37,7 +37,7 @@ class core_message_externallib_testcase extends externallib_advanced_testcase {
     /**
      * Tests set up
      */
-    protected function setUp() {
+    protected function setUp(): void {
         global $CFG;
 
         require_once($CFG->dirroot . '/message/lib.php');

message/tests/helper_test.php

@@ -39,7 +39,7 @@ require_once($CFG->dirroot . '/message/tests/messagelib_test.php');
  */
 class core_message_helper_testcase extends advanced_testcase {
 
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

message/tests/inbound_test.php

@@ -38,7 +38,7 @@ class core_message_inbound_testcase extends advanced_testcase {
      * This includes:
      * * configuring the messageinbound_mailbox.
      */
-    public function setUp() {
+    public function setUp(): void {
         global $CFG;
 
         $this->resetAfterTest(true);

message/tests/messagelib_test.php

@@ -48,7 +48,7 @@ class core_message_messagelib_testcase extends advanced_testcase {
      *
      * This is executed before running any test in this file.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->preventResetByRollback(); // Messaging is not compatible with transactions.
         $this->messagesink = $this->redirectMessages();
         $this->resetAfterTest();

message/tests/migrate_message_data_task_test.php

@@ -44,7 +44,7 @@ class core_message_migrate_message_data_task_testcase extends advanced_testcase
      *
      * This is executed before running any test in this file.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest();
     }
 

message/tests/search_received_test.php

@@ -45,7 +45,7 @@ class message_received_search_testcase extends advanced_testcase {
      * Setting up the test environment
      * @return void
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
         set_config('enableglobalsearch', true);
 

message/tests/search_sent_test.php

@@ -45,7 +45,7 @@ class message_sent_search_testcase extends advanced_testcase {
      * Setting up the test environment
      * @return void
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
         set_config('enableglobalsearch', true);