MDL-67673 phpunit: Fix the return type of template methods

All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...

repository/flickr/tests/privacy_test.php

@@ -38,7 +38,7 @@ class repository_flickr_privacy_testcase extends provider_testcase {
     /**
      * Overriding setUp() function to always reset after tests.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

repository/nextcloud/tests/access_controlled_link_manager_test.php

@@ -53,7 +53,7 @@ class repository_nextcloud_access_controlled_link_manager_testcase extends advan
     /**
      * SetUp to create an repository instance.
      */
-    protected function setUp() {
+    protected function setUp(): void {
         $this->resetAfterTest(true);
 
         // Admin is necessary to create issuer object.
@@ -630,4 +630,4 @@ XML;
         }
     }
 
-}
+}

repository/nextcloud/tests/lib_test.php

@@ -45,7 +45,7 @@ class repository_nextcloud_lib_testcase extends advanced_testcase {
     /**
      * SetUp to create an repository instance.
      */
-    protected function setUp() {
+    protected function setUp(): void {
         $this->resetAfterTest(true);
 
         // Admin is neccessary to create api and issuer objects.

repository/nextcloud/tests/ocs_test.php

@@ -40,7 +40,7 @@ class repository_nextcloud_ocs_testcase extends advanced_testcase {
     /**
      * SetUp to create issuer and endpoints for OCS testing.
      */
-    protected function setUp() {
+    protected function setUp(): void {
         $this->resetAfterTest(true);
 
         // Admin is neccessary to create issuer object.

repository/onedrive/tests/privacy_test.php

@@ -38,7 +38,7 @@ class repository_onedrive_privacy_testcase extends \core_privacy\tests\provider_
     /**
      * Overriding setUp() function to always reset after tests.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }
 

repository/recent/tests/lib_test.php

@@ -49,7 +49,7 @@ class repository_recent_lib_testcase extends advanced_testcase {
     /**
      * SetUp to create an repository instance.
      */
-    protected function setUp() {
+    protected function setUp(): void {
         global $USER;
         $this->setAdminUser();
         $this->usercontext = context_user::instance($USER->id);

repository/tests/privacy_test.php

@@ -41,7 +41,7 @@ class core_repository_privacy_testcase extends \core_privacy\tests\provider_test
     /**
      * Overriding setUp() function to always reset after tests.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest(true);
     }