moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 01:46:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'MDL-71390-master' of git://github.com/marinaglancy/moodle

Browse source
This commit is contained in:
Sara Arjona 2021-05-06 08:01:47 +02:00
commit d8a029ad64
6 changed files with 30 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

44
lib/tests/behat/largeforms.feature
View file

@ -28,39 +28,6 @@ Feature: Forms with a large number of fields
And I should see "submitbutton=Submit here!"
And I should see "Bulk checkbox success: true"
@javascript
Scenario: Medium length form with checkboxes (needs workaround)
When I follow "Advanced checkboxes / Below limit"
And I press "Submit here!"
Then I should see "_qf__core_max_input_vars_form=1"
And I should see "mform_isexpanded_id_general=1"
And I should see "arraytest=[13,42]"
And I should see "array2test=[13,42]"
And I should see "submitbutton=Submit here!"
And I should see "Bulk checkbox success: true"
@javascript
Scenario: Exact PHP limit length form with checkboxes (uses workaround but doesn't need it)
When I follow "Advanced checkboxes / Exact PHP limit"
And I press "Submit here!"
Then I should see "_qf__core_max_input_vars_form=1"
And I should see "mform_isexpanded_id_general=1"
And I should see "arraytest=[13,42]"
And I should see "array2test=[13,42]"
And I should see "submitbutton=Submit here!"
And I should see "Bulk checkbox success: true"
@javascript
Scenario: Longer than the limit with checkboxes (needs workaround)
When I follow "Advanced checkboxes / Above limit"
And I press "Submit here!"
Then I should see "_qf__core_max_input_vars_form=1"
And I should see "mform_isexpanded_id_general=1"
And I should see "arraytest=[13,42]"
And I should see "array2test=[13,42]"
And I should see "submitbutton=Submit here!"
And I should see "Bulk checkbox success: true"
@javascript
Scenario: Small form with array fields (not using workaround)
When I follow "Select options / Small"
@ -93,14 +60,3 @@ Feature: Forms with a large number of fields
And I should see "array2test=[13,42]"
And I should see "submitbutton=Submit here!"
And I should see "Bulk array success: true"
@javascript
Scenario: Longer than the limit with array fields (needs workaround)
When I follow "Select options / Above limit"
And I press "Submit here!"
Then I should see "_qf__core_max_input_vars_form=1"
And I should see "mform_isexpanded_id_general=1"
And I should see "arraytest=[13,42]"
And I should see "array2test=[13,42]"
And I should see "submitbutton=Submit here!"
And I should see "Bulk array success: true"

6
lib/tests/fixtures/max_input_vars.php vendored
View file

@ -112,9 +112,6 @@ if ($type) {
} else {
$fieldcount = (int)ini_get('max_input_vars') - 11;
}
} else if ($type[1] === 'l') {
// Just over the limit.
$fieldcount = (int)ini_get('max_input_vars') + 100;
}
$mform = new core_max_input_vars_form('max_input_vars.php',
@ -220,8 +217,7 @@ if ($type && ($result = $mform->get_data())) {
echo html_writer::start_tag('ul');
foreach (array('c' => 'Advanced checkboxes',
'a' => 'Select options') as $control => $controlname) {
foreach (array('s' => 'Small', 'm' => 'Below limit', 'e' => 'Exact PHP limit',
'l' => 'Above limit') as $size => $sizename) {
foreach (array('s' => 'Small', 'm' => 'Below limit', 'e' => 'Exact PHP limit') as $size => $sizename) {
echo html_writer::tag('li', html_writer::link('max_input_vars.php?type=' .
$control . $size, $controlname . ' / ' . $sizename));
}