moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-08 18:36:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-79122 question: Correct capability check for question comments link.

Browse source 
This makes the rendering of the question comments count additionally
check the core moodle/comment:post capability, since this capability
is required to make comments. Previously, this was not being checked
so users could open the modal to make a comment, which was causing
a javascript error due to expected elements being missing.
This commit is contained in:
Conn Warwicker 2024-12-04 10:03:48 +00:00 • committed by Mark Johnson
parent a798b1db39
commit d9d2388965
No known key found for this signature in database
GPG key ID: EB30E1468CFAE242
5 changed files with 139 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

12
.upgradenotes/MDL-7987-2024120515332266.yml Normal file
View file

@ -0,0 +1,12 @@
issueNumber: MDL-79122
notes:
core_question:
- message: >-
Behat steps `behat_qbank_comment::i_should_see_on_the_column`
and `behat_qbank_comment::i_click_on_the_row_containing` have been
deprecated in favour of the new component named selectors,
`qbank_comment > Comment count link` and
`qbank_comment > Comment count text` which can be used with the
standard `should exist` and `I click on` steps to replace the
custom steps.
type: deprecated