MDL-67872 lib: correct plagiarism config frankenstyle naming.

This commit is contained in:
Dan Marsden 2020-02-07 10:54:00 +13:00
parent cb38ab1e39
commit de8d91ce38

View file

@ -182,19 +182,35 @@ function plagiarism_print_disclosure($cmid) {
} }
/** /**
* helper function - also loads lib file of plagiarism plugin * Helper function - also loads lib file of plagiarism plugin
*
* @todo MDL-67872 the deprecated code in this function to be removed in Moodle 4.3
* @return array of available plugins * @return array of available plugins
*/ */
function plagiarism_load_available_plugins() { function plagiarism_load_available_plugins() {
global $CFG; global $CFG;
static $showndeprecatedmessage = array(); // Only show message once per page load.
if (empty($CFG->enableplagiarism)) { if (empty($CFG->enableplagiarism)) {
return array(); return array();
} }
$plagiarismplugins = core_component::get_plugin_list('plagiarism'); $plagiarismplugins = core_component::get_plugin_list('plagiarism');
$availableplugins = array(); $availableplugins = array();
foreach($plagiarismplugins as $plugin => $dir) { foreach ($plagiarismplugins as $plugin => $dir) {
//check this plugin is enabled and a lib file exists. // Check this plugin is enabled and a lib file exists.
if (get_config('plagiarism', $plugin."_use") && file_exists($dir."/lib.php")) { if (get_config('plagiarism', $plugin."_use")) {
// Deprecated Since Moodle 3.9.
$pluginenabled = true;
if (empty($showndeprecatedmessage[$plugin])) {
$text = 'The setting plagiarism:'.$plugin.'_use is deprecated.';
$text .= ' Use plagiarism_' . $plugin . ':enabled instead';
debugging($text, DEBUG_DEVELOPER);
$showndeprecatedmessage[$plugin] = true;
}
} else {
$pluginenabled = get_config('plagiarism_'.$plugin, 'enabled');
}
if ($pluginenabled && file_exists($dir."/lib.php")) {
require_once($dir.'/lib.php'); require_once($dir.'/lib.php');
$plagiarismclass = "plagiarism_plugin_$plugin"; $plagiarismclass = "plagiarism_plugin_$plugin";
if (class_exists($plagiarismclass)) { if (class_exists($plagiarismclass)) {