moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 08:26:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-78125 qtype_multianswer: Convert popover trigger to link

Browse source 
According to Boostrap Popovers documentation for popovers triggered
on focus:
"For proper cross-browser and cross-platform behavior, you must use the
<a> tag, not the <button> tag, and you also must include a tabindex
attribute."
This commit is contained in:
Jun Pataleta 2023-05-06 00:03:27 +08:00
parent 063ffc8073
commit df496e57d6
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
question/type/multianswer/renderer.php
View file

@ -212,8 +212,9 @@ abstract class qtype_multianswer_subq_renderer_base extends qtype_renderer {
return ''; return '';
} }
return html_writer::tag('button', $icon, [ return html_writer::link('#', $icon, [
'type' => 'button', 'role' => 'button',
'tabindex' => 0,
'class' => 'btn btn-link p-0', 'class' => 'btn btn-link p-0',
'data-toggle' => 'popover', 'data-toggle' => 'popover',
'data-container' => 'body', 'data-container' => 'body',