MDL-77350 enrol: Added class properties that are not declared

In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.

enrol/ldap/lib.php

@@ -40,6 +40,9 @@ class enrol_ldap_plugin extends enrol_plugin {
      */
     protected $userobjectclass;
 
+    /** @var LDAP\Connection LDAP connection. */
+    protected $ldapconnection;
+
     /**
      * Constructor for the plugin. In addition to calling the parent
      * constructor, we define and 'fix' some settings depending on the

enrol/ldap/settingslib.php

@@ -29,6 +29,9 @@ class admin_setting_configtext_trim_lower extends admin_setting_configtext {
     /* @var boolean whether to lowercase the value or not before writing in to the db */
     private $lowercase;
 
+    /**  @var bool To store enable/disabled status of the input field. */
+    protected $enabled;
+
     /**
      * Constructor: uses parent::__construct
      *

enrol/lti/ims-blti/OAuth.php

@@ -13,6 +13,9 @@ class OAuthConsumer {
   public $key;
   public $secret;
 
+  /**  @var string|null To store callback_url. */
+  protected $callback_url;
+
   function __construct($key, $secret, $callback_url=NULL) {
     $this->key = $key;
     $this->secret = $secret;

enrol/lti/ims-blti/readme_moodle.txt

@@ -6,3 +6,4 @@ In future releases we should look into using a supported library.
 2022-01-05 - MDL-73502 - Removed get_magic_quotes_gpc() use, was returning false since ages ago.
 2022-01-20 - MDL-73523 - Conditional openssl_free_key() use, deprecated by PHP 8.0
 2022-03-05 - MDL-73520 - replace deprecated php_errormsg with error_get_last(), deprecated by PHP 8.0
+2022-04-06 - MDL-77350 - Added $callback_url property to class OAuthConsumer to comply with PHP 8.2

enrol/renderer.php

@@ -351,6 +351,9 @@ class course_enrolment_table extends html_table implements renderable {
             'alternatename', 'username', 'idnumber', 'email', 'phone1', 'phone2',
             'institution', 'department', 'lastaccess', 'lastcourseaccess');
 
+    /** @var bool To store status of Other users page. */
+    public $otherusers;
+
     /**
      * Constructs the table
      *
@@ -644,8 +647,6 @@ class course_enrolment_users_table extends course_enrolment_table {
  */
 class course_enrolment_other_users_table extends course_enrolment_table {
 
-    public $otherusers = true;
-
     /**
      * Constructs the table
      *