moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 09:56:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-27196 workshop - hardcoded strings in the random allocator

Browse source
This commit is contained in:
David Mudrak 2011-06-22 17:58:48 +02:00
parent 069de416af
commit e4394d00c4
2 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
mod/workshop/allocation/random/lang/en/workshopallocation_random.php
View file

@ -44,5 +44,10 @@ $string['numperauthor'] = 'per submission';
$string['numperreviewer'] = 'per reviewer'; $string['numperreviewer'] = 'per reviewer';
$string['pluginname'] = 'Random allocation'; $string['pluginname'] = 'Random allocation';
$string['randomallocationdone'] = 'Random allocation done'; $string['randomallocationdone'] = 'Random allocation done';
$string['resultnomorepeers'] = 'No more peers available';
$string['resultnomorepeersingroup'] = 'No more peers available in this separate group';
$string['resultnotenoughpeers'] = 'Not enough peers available';
$string['resultnumperauthor'] = 'Trying to allocate {$a} review(s) per author';
$string['resultnumperreviewer'] = 'Trying to allocate {$a} review(s) per reviewer';
$string['removecurrentallocations'] = 'Remove current allocations'; $string['removecurrentallocations'] = 'Remove current allocations';
$string['stats'] = 'Current allocation statistics'; $string['stats'] = 'Current allocation statistics';

10
mod/workshop/allocation/random/lib.php
View file

@ -426,14 +426,14 @@ class workshop_random_allocator implements workshop_allocator {
if (self::USERTYPE_AUTHOR == $numper) { if (self::USERTYPE_AUTHOR == $numper) {
// circles are authors, squares are reviewers // circles are authors, squares are reviewers
$o[] = 'info::Trying to allocate ' . $numofreviews . ' review(s) per author'; // todo translate $o[] = 'info::'.get_string('resultnumperauthor', 'workshopallocation_random', $numofreviews);
$allcircles = $authors; $allcircles = $authors;
$allsquares = $reviewers; $allsquares = $reviewers;
// get current workload // get current workload
list($circlelinks, $squarelinks) = $this->convert_assessments_to_links($assessments); list($circlelinks, $squarelinks) = $this->convert_assessments_to_links($assessments);
} elseif (self::USERTYPE_REVIEWER == $numper) { } elseif (self::USERTYPE_REVIEWER == $numper) {
// circles are reviewers, squares are authors // circles are reviewers, squares are authors
$o[] = 'info::trying to allocate ' . $numofreviews . ' review(s) per reviewer'; // todo translate $o[] = 'info::'.get_string('resultnumperreviewer', 'workshopallocation_random', $numofreviews);
$allcircles = $reviewers; $allcircles = $reviewers;
$allsquares = $authors; $allsquares = $authors;
// get current workload // get current workload
@ -513,14 +513,14 @@ class workshop_random_allocator implements workshop_allocator {
if (NOGROUPS == $gmode) { if (NOGROUPS == $gmode) {
if (in_array(0, $failedgroups)) { if (in_array(0, $failedgroups)) {
$keeptrying = false; $keeptrying = false;
$o[] = 'error::indent::No more peers available'; // todo translate $o[] = 'error::indent::'.get_string('resultnomorepeers', 'workshopallocation_random');
break; break;
} }
$targetgroup = 0; $targetgroup = 0;
} elseif (SEPARATEGROUPS == $gmode) { } elseif (SEPARATEGROUPS == $gmode) {
if (in_array($circlegroupid, $failedgroups)) { if (in_array($circlegroupid, $failedgroups)) {
$keeptrying = false; $keeptrying = false;
$o[] = 'error::indent::No more peers available in this separate group'; // todo translate $o[] = 'error::indent::'.get_string('resultnomorepeersingroup', 'workshopallocation_random');
break; break;
} }
$targetgroup = $circlegroupid; $targetgroup = $circlegroupid;
@ -541,7 +541,7 @@ class workshop_random_allocator implements workshop_allocator {
} }
if ($targetgroup === false) { if ($targetgroup === false) {
$keeptrying = false; $keeptrying = false;
$o[] = 'error::indent::Not enough peers available'; // todo translate $o[] = 'error::indent::'.get_string('resultnotenoughpeers', 'workshopallocation_random');
break; break;
} }
$o[] = 'debug::indent::next square should be from group id ' . $targetgroup; $o[] = 'debug::indent::next square should be from group id ' . $targetgroup;