moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-29894 forbid objects in DML parameters

Browse source 
Objects with __toString we never fully supported as parameters in DML layer, this finally brings consistent behaviour.
This commit is contained in:
Petr Skoda 2012-03-17 18:42:30 +01:00
parent a2b30aa852
commit e618cdf3f6
8 changed files with 156 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/dml/pgsql_native_moodle_database.php
View file

@ -529,6 +529,8 @@ class pgsql_native_moodle_database extends moodle_database {
* @return mixed the normalised value
*/
protected function normalise_value($column, $value) {
$this->detect_objects($value);
if (is_bool($value)) { // Always, convert boolean to int
$value = (int)$value;
@ -778,9 +780,10 @@ class pgsql_native_moodle_database extends moodle_database {
$fields = implode(',', array_keys($params));
$values = array();
$count = count($params);
for ($i=1; $i<=$count; $i++) {
$values[] = "\$".$i;
$i = 1;
foreach ($params as $value) {
$this->detect_objects($value);
$values[] = "\$".$i++;
}
$values = implode(',', $values);
@ -876,6 +879,7 @@ class pgsql_native_moodle_database extends moodle_database {
$blobs = array();
foreach ($dataobject as $field=>$value) {
$this->detect_objects($value);
if (!isset($columns[$field])) {
continue;
}
@ -932,6 +936,7 @@ class pgsql_native_moodle_database extends moodle_database {
$sets = array();
foreach ($params as $field=>$value) {
$this->detect_objects($value);
$sets[] = "$field = \$".$i++;
}