diff --git a/Gruntfile.js b/Gruntfile.js index bd3918574e2..59ebfbbbaf1 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -536,12 +536,8 @@ module.exports = function(grunt) { formatter.printResults(results); // Report on the results. - // We exit 1 if there is at least one error, otherwise we exit cleanly. - if (results.some(result => result.errors.length > 0)) { - done(1); - } else { - done(0); - } + // The done function takes a bool whereby a falsey statement causes the task to fail. + done(results.every(result => result.errors.length === 0)); }; tasks.startup = function() { diff --git a/admin/tool/task/tests/behat/clear_fail_delay.feature b/admin/tool/task/tests/behat/clear_fail_delay.feature index 643750b6b23..ceee8678297 100644 --- a/admin/tool/task/tests/behat/clear_fail_delay.feature +++ b/admin/tool/task/tests/behat/clear_fail_delay.feature @@ -23,7 +23,6 @@ Feature: Clear scheduled task fail delay And I should not see "Clear" in the "Send new user passwords" "table_row" And I should see "Send new user passwords" in the "tr.table-primary" "css_element" - Scenario: Cancel clearing the fail delay When I click on "Clear" "text" in the "Send new user passwords" "table_row" And I press "Cancel" diff --git a/mod/h5pactivity/tests/behat/add_h5pactivity.feature b/mod/h5pactivity/tests/behat/add_h5pactivity.feature index b7d5c00a33a..ab92d1e3fa8 100644 --- a/mod/h5pactivity/tests/behat/add_h5pactivity.feature +++ b/mod/h5pactivity/tests/behat/add_h5pactivity.feature @@ -20,7 +20,6 @@ Feature: Add H5P activity And I log in as "teacher1" And I am on "Course 1" course homepage with editing mode on - @javascript Scenario: Add a h5pactivity activity to a course When I add a "H5P activity" to section "1"