From a927fcdc7b25cdc601940b50eba7a6619555d233 Mon Sep 17 00:00:00 2001 From: Juan Leyva Date: Fri, 16 Aug 2019 15:41:21 +0100 Subject: [PATCH] MDL-65042 rating: Fix incorrect image generated for user in rating --- rating/classes/external.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/rating/classes/external.php b/rating/classes/external.php index 5e19c26e3e8..0ae8a6c95e5 100644 --- a/rating/classes/external.php +++ b/rating/classes/external.php @@ -146,18 +146,20 @@ class core_rating_external extends external_api { $rating->rating = $maxrating; } - // The rating object has all the required fields for generating the picture url. - $userpicture = new user_picture($rating); - $userpicture->size = 1; // Size f1. - $profileimageurl = $userpicture->get_url($PAGE)->out(false); - $result = array(); $result['id'] = $rating->id; $result['userid'] = $rating->userid; - $result['userpictureurl'] = $profileimageurl; $result['userfullname'] = fullname($rating); $result['rating'] = $scalemenu[$rating->rating]; $result['timemodified'] = $rating->timemodified; + + // The rating object has all the required fields for generating the picture url. + // Undo the aliasing of the user id column from user_picture::fields(). + $rating->id = $rating->userid; + $userpicture = new user_picture($rating); + $userpicture->size = 1; // Size f1. + $result['userpictureurl'] = $userpicture->get_url($PAGE)->out(false); + $results[] = $result; } }