moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-71694 assignfeedback_comments: Fill latest submitted comment data

Browse source 
Otherwise if grading validation fails, any new/updated comments are
lost and replaced with previously saved data (or an empty editor).
This commit is contained in:
Tony Butler 2021-05-28 10:21:01 +01:00
parent 9533e8ddf5
commit ec0185ccc2
No known key found for this signature in database
GPG key ID: 9711182AA2B802C4
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mod/assign/feedback/comments/locallib.php
View file

@ -348,7 +348,11 @@ class assign_feedback_comments extends assign_feedback_plugin {
$feedbackcomments = $this->get_feedback_comments($grade->id); $feedbackcomments = $this->get_feedback_comments($grade->id);
} }
if ($feedbackcomments && !empty($feedbackcomments->commenttext)) { // Check first for data from last form submission in case grading validation failed.
if (!empty($data->assignfeedbackcomments_editor['text'])) {
$data->assignfeedbackcomments = $data->assignfeedbackcomments_editor['text'];
$data->assignfeedbackcommentsformat = $data->assignfeedbackcomments_editor['format'];
} else if ($feedbackcomments && !empty($feedbackcomments->commenttext)) {
$data->assignfeedbackcomments = $feedbackcomments->commenttext; $data->assignfeedbackcomments = $feedbackcomments->commenttext;
$data->assignfeedbackcommentsformat = $feedbackcomments->commentformat; $data->assignfeedbackcommentsformat = $feedbackcomments->commentformat;
} else { } else {