moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 08:26:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-35851 Lesson module: fix page order id for import questions. Add upgrade script to fix lesson pages corrupted links

Browse source
This commit is contained in:
Rossiani Wijaya 2013-06-20 13:10:02 +08:00 • committed by Damyon Wiese
parent e780e5cb8f
commit eebc821c83
3 changed files with 68 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
mod/lesson/format.php
View file

@ -323,6 +323,13 @@ class qformat_default {
$this->count_questions($questions)), 'notifysuccess');
$count = 0;
$addquestionontop = false;
if ($pageid == 0) {
$addquestionontop = true;
$updatelessonpage = $DB->get_record('lesson_pages', array('lessonid' => $lesson->id, 'prevpageid' => 0));
} else {
$updatelessonpage = $DB->get_record('lesson_pages', array('id' => $pageid));
}
$unsupportedquestions = 0;
@ -378,7 +385,6 @@ class qformat_default {
$newpageid = $DB->insert_record("lesson_pages", $newpage);
// update the linked list
$DB->set_field("lesson_pages", "nextpageid", $newpageid, array("id" => $pageid));
} else {
// new page is the first page
// get the existing (first) page (if any)
@ -397,6 +403,7 @@ class qformat_default {
$DB->set_field("lesson_pages", "prevpageid", $newpageid, array("id" => $page->id));
}
}
// reset $pageid and put the page ID in $question, used in save_question_option()
$pageid = $newpageid;
$question->id = $newpageid;
@ -424,7 +431,12 @@ class qformat_default {
$unsupportedquestions++;
break;
}
}
// update the prev links
if ($addquestionontop) {
$DB->set_field("lesson_pages", "prevpageid", $pageid, array("id" => $updatelessonpage->id));
} else {
$DB->set_field("lesson_pages", "prevpageid", $pageid, array("id" => $updatelessonpage->nextpageid));
}
if ($unsupportedquestions) {
echo $OUTPUT->notification(get_string('unknownqtypesnotimported', 'lesson', $unsupportedquestions));