moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-09 02:46:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-66075 mod_forum: reduce DB reads in forum settings generation

Browse source 
Instead of fetching the DB record AND then fetching it again (as
part of the vault->get_from_id() call, just use the legacy data
mapper and remove the DB call.
This commit is contained in:
Jake Dallimore 2019-09-27 09:23:27 +08:00
parent c3122dfcf5
commit f5e6bcf026
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
mod/forum/lib.php
View file

@ -5235,15 +5235,16 @@ function forum_get_extra_capabilities() {
function forum_extend_settings_navigation(settings_navigation $settingsnav, navigation_node $forumnode) { function forum_extend_settings_navigation(settings_navigation $settingsnav, navigation_node $forumnode) {
global $USER, $PAGE, $CFG, $DB, $OUTPUT; global $USER, $PAGE, $CFG, $DB, $OUTPUT;
$forumobject = $DB->get_record("forum", array("id" => $PAGE->cm->instance));
if (empty($PAGE->cm->context)) { if (empty($PAGE->cm->context)) {
$PAGE->cm->context = context_module::instance($PAGE->cm->instance); $PAGE->cm->context = context_module::instance($PAGE->cm->instance);
} }
$vaultfactory = mod_forum\local\container::get_vault_factory(); $vaultfactory = mod_forum\local\container::get_vault_factory();
$managerfactory = mod_forum\local\container::get_manager_factory(); $managerfactory = mod_forum\local\container::get_manager_factory();
$legacydatamapperfactory = mod_forum\local\container::get_legacy_data_mapper_factory();
$forumvault = $vaultfactory->get_forum_vault(); $forumvault = $vaultfactory->get_forum_vault();
$forumentity = $forumvault->get_from_id($forumobject->id); $forumentity = $forumvault->get_from_id($PAGE->cm->instance);
$forumobject = $legacydatamapperfactory->get_forum_data_mapper()->to_legacy_object($forumentity);
$params = $PAGE->url->params(); $params = $PAGE->url->params();
if (!empty($params['d'])) { if (!empty($params['d'])) {