MDL-14679 fixed remaining old style set_field()s

This commit is contained in:
Petr Skoda 2010-09-03 18:14:55 +00:00
parent dd88de0ebd
commit f685e83030
26 changed files with 82 additions and 167 deletions

View file

@ -1448,10 +1448,9 @@ class question_bank_view {
$questionid = (int)$questionid;
question_require_capability_on($questionid, 'edit');
if ($DB->record_exists('quiz_question_instances', array('question' => $questionid))) {
if (!$DB->set_field('question', 'hidden', 1, array('id' => $questionid))) {
question_require_capability_on($questionid, 'edit');
print_error('cannothidequestion', 'question');
}
$DB->set_field('question', 'hidden', 1, array('id' => $questionid));
question_require_capability_on($questionid, 'edit');
print_error('cannothidequestion', 'question');
} else {
delete_question($questionid);
}
@ -1467,9 +1466,7 @@ class question_bank_view {
// Unhide a question
if(($unhide = optional_param('unhide', '', PARAM_INT)) and confirm_sesskey()) {
question_require_capability_on($unhide, 'edit');
if(!$DB->set_field('question', 'hidden', 0, array('id' => $unhide))) {
print_error('cannotunhidequestion', 'question');
}
$DB->set_field('question', 'hidden', 0, array('id' => $unhide));
redirect($this->baseurl);
}
}