moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-70042 message_popup: progress bar on upgrade only when necessary

Browse source
This commit is contained in:
Matteo Scaramuccia 2020-10-28 22:41:48 +01:00
parent 99680d1be4
commit fad0a943b2
1 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

24
message/output/popup/db/upgrade.php
View file

@ -51,17 +51,19 @@ function xmldb_message_popup_upgrade($oldversion) {
ON mpn.notificationid = n.id ON mpn.notificationid = n.id
WHERE n.id IS NULL"; WHERE n.id IS NULL";
$total = $DB->count_records_sql("SELECT COUNT(mpn.id) " . $fromsql); $total = $DB->count_records_sql("SELECT COUNT(mpn.id) " . $fromsql);
$i = 0; if ($total > 0) {
$pbar = new progress_bar('deletepopupnotification', 500, true); $i = 0;
do { $pbar = new progress_bar('deletepopupnotification', 500, true);
if ($popupnotifications = $DB->get_records_sql("SELECT mpn.id " . $fromsql, null, 0, 1000)) { do {
list($insql, $inparams) = $DB->get_in_or_equal(array_keys($popupnotifications)); if ($popupnotifications = $DB->get_records_sql("SELECT mpn.id " . $fromsql, null, 0, 1000)) {
$DB->delete_records_select('message_popup_notifications', "id $insql", $inparams); list($insql, $inparams) = $DB->get_in_or_equal(array_keys($popupnotifications));
// Update progress. $DB->delete_records_select('message_popup_notifications', "id $insql", $inparams);
$i += count($inparams); // Update progress.
$pbar->update($i, $total, "Cleaning up orphaned popup notification records - $i/$total."); $i += count($inparams);
} $pbar->update($i, $total, "Cleaning up orphaned popup notification records - $i/$total.");
} while ($popupnotifications); }
} while ($popupnotifications);
}
// Reportbuilder savepoint reached. // Reportbuilder savepoint reached.
upgrade_plugin_savepoint(true, 2020020600, 'message', 'popup'); upgrade_plugin_savepoint(true, 2020020600, 'message', 'popup');