moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-46207 Tasks: Do not run tasks if their component is disabled.

Browse source 
This can be overridden on a per task basis by implementing:
get_run_if_component_disabled() in the scheduled task.
This commit is contained in:
Damyon Wiese 2014-07-21 15:01:54 +08:00
parent 584539c0fc
commit fd57c17e2d
2 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/classes/task/manager.php
View file

@ -456,6 +456,8 @@ class manager {
$params = array('timestart1' => $timestart, 'timestart2' => $timestart);
$records = $DB->get_records_select('task_scheduled', $where, $params);
$pluginmanager = \core_plugin_manager::instance();
foreach ($records as $record) {
if ($lock = $cronlockfactory->get_lock(($record->classname), 10)) {
@ -463,6 +465,17 @@ class manager {
$task = self::scheduled_task_from_record($record);
$task->set_lock($lock);
// See if the component is disabled.
$plugininfo = $pluginmanager->get_plugin_info($task->get_component());
if ($plugininfo) {
if (!$task->get_run_if_component_disabled() && !$plugininfo->is_enabled()) {
$lock->release();
continue;
}
}
if (!$task->is_blocking()) {
$cronlock->release();
} else {

9
lib/classes/task/scheduled_task.php
View file

@ -183,6 +183,15 @@ abstract class scheduled_task extends task_base {
return $this->disabled;
}
/**
* Override this function if you want this scheduled task to run, even if the component is disabled.
*
* @return bool
*/
public function get_run_if_component_disabled() {
return false;
}
/**
* Take a cron field definition and return an array of valid numbers with the range min-max.
*