moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-08 10:26:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-45273 quiz: Fix codechecker issues.

Browse source
This commit is contained in:
Tim Hunt 2014-04-29 11:56:30 +01:00
parent 6f9a441023
commit fddcf077ab
3 changed files with 26 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

26
mod/quiz/classes/admin_review_setting.php
View file

@ -34,15 +34,29 @@ defined('MOODLE_INTERNAL') || die();
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/ */
class mod_quiz_admin_review_setting extends admin_setting { class mod_quiz_admin_review_setting extends admin_setting {
/**#@+ /**
* @var integer should match the constants defined in {@link mod_quiz_display_options}. * @var integer should match the constants defined in
* again, copied for performance reasons. * {@link mod_quiz_display_options}. Copied for performance reasons.
*/ */
const DURING = 0x10000; const DURING = 0x10000;
/**
* @var integer should match the constants defined in
* {@link mod_quiz_display_options}. Copied for performance reasons.
*/
const IMMEDIATELY_AFTER = 0x01000; const IMMEDIATELY_AFTER = 0x01000;
/**
* @var integer should match the constants defined in
* {@link mod_quiz_display_options}. Copied for performance reasons.
*/
const LATER_WHILE_OPEN = 0x00100; const LATER_WHILE_OPEN = 0x00100;
/**
* @var integer should match the constants defined in
* {@link mod_quiz_display_options}. Copied for performance reasons.
*/
const AFTER_CLOSE = 0x00010; const AFTER_CLOSE = 0x00010;
/**#@-*/
/** /**
* @var boolean|null forced checked / disabled attributes for the during time. * @var boolean|null forced checked / disabled attributes for the during time.
@ -83,6 +97,7 @@ class mod_quiz_admin_review_setting extends admin_setting {
} }
/** /**
* Return the combination that means all times.
* @return int all times. * @return int all times.
*/ */
public static function all_on() { public static function all_on() {
@ -91,7 +106,8 @@ class mod_quiz_admin_review_setting extends admin_setting {
} }
/** /**
* @return array name of all the possible times. * Get an array of the names of all the possible times.
* @return array an array of time constant => lang string.
*/ */
protected static function times() { protected static function times() {
return array( return array(

6
mod/quiz/locallib.php
View file

@ -1168,6 +1168,7 @@ function quiz_get_overdue_handling_options() {
} }
/** /**
* Get the choices for what size user picture to show.
* @return array string => lang string the options for whether to display the user's picture. * @return array string => lang string the options for whether to display the user's picture.
*/ */
function quiz_get_user_image_options() { function quiz_get_user_image_options() {
@ -1179,8 +1180,9 @@ function quiz_get_user_image_options() {
} }
/** /**
* @param string $state one of the state constants like IN_PROGRESS. * Get the human-readable name for a quiz attempt state.
* @return string the human-readable state name. * @param string $state one of the state constants like {@link quiz_attempt::IN_PROGRESS}.
* @return string The lang string to describe that state.
*/ */
function quiz_attempt_state_name($state) { function quiz_attempt_state_name($state) {
switch ($state) { switch ($state) {

2
mod/quiz/settings.php
View file

@ -203,7 +203,7 @@ if ($ADMIN->fulltree) {
get_string('showinsecurepopup', 'quiz'), get_string('configpopup', 'quiz'), get_string('showinsecurepopup', 'quiz'), get_string('configpopup', 'quiz'),
array('value' => '-', 'adv' => true), null)); array('value' => '-', 'adv' => true), null));
// Allow user to specify if setting outcomes is an advanced setting // Allow user to specify if setting outcomes is an advanced setting.
if (!empty($CFG->enableoutcomes)) { if (!empty($CFG->enableoutcomes)) {
$quizsettings->add(new admin_setting_configcheckbox('quiz/outcomes_adv', $quizsettings->add(new admin_setting_configcheckbox('quiz/outcomes_adv',
get_string('outcomesadvanced', 'quiz'), get_string('configoutcomesadvanced', 'quiz'), get_string('outcomesadvanced', 'quiz'), get_string('configoutcomesadvanced', 'quiz'),