moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 08:26:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Sorry, Petri, but we need to undo these changes, because:

Browse source 
- they could break accounts in existing installations
  - strtolower can corrupt strings in multibyte languages

Is it really a problem that usernames are case sensitive on PostgreSQL?
This commit is contained in:
moodler 2003-04-01 02:14:16 +00:00
parent b398d5ee2a
commit ffb410df03
2 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/moodlelib.php
View file

@ -484,8 +484,6 @@ function create_user_record($username, $password) {
/// Creates a bare-bones user record /// Creates a bare-bones user record
global $REMOTE_ADDR, $CFG; global $REMOTE_ADDR, $CFG;
$username = strtolower($username);
if (function_exists(auth_get_userinfo)) { if (function_exists(auth_get_userinfo)) {
if ($newinfo = auth_get_userinfo($username)) { if ($newinfo = auth_get_userinfo($username)) {
foreach ($newinfo as $key => $value){ foreach ($newinfo as $key => $value){

1
user/edit.php
View file

@ -43,7 +43,6 @@
/// If data submitted, then process and store. /// If data submitted, then process and store.
if ($usernew = data_submitted()) { if ($usernew = data_submitted()) {
$usernew->username = strtolower($usernew->username);
$usernew->firstname = strip_tags($usernew->firstname); $usernew->firstname = strip_tags($usernew->firstname);
$usernew->lastname = strip_tags($usernew->lastname); $usernew->lastname = strip_tags($usernew->lastname);