Commit graph

163 commits

Author SHA1 Message Date
David Mudrak
81eccf0a36 MDL-20652 workshop: initial work on example submissions 2010-01-04 18:27:21 +00:00
David Mudrak
10bc4bce2b Various fixes found during testing 2010-01-04 18:24:17 +00:00
David Mudrak
f27b70fbbc MDL-20058 totalgrade stuff removed from workshop code 2010-01-04 18:24:03 +00:00
David Mudrak
365c2cc22a MDL-20058 workshop pushed grades into gradebook 2010-01-04 18:23:52 +00:00
David Mudrak
557a11009e MDL-20058 workshop allows override grade for submission 2010-01-04 18:23:22 +00:00
David Mudrak
67cd00ba5b Refactor submission.php a bit to prepare for feedback form 2010-01-04 18:23:08 +00:00
David Mudrak
d183140de8 MDL-20058 workshop grading report fixes and small improvements 2010-01-04 18:22:47 +00:00
David Mudrak
f6e8b31802 workshop: general cleanup
Moving stuff from lib.php into static methods in localib.php. Removing
things from workshop core that were implemented in a subplugin. Dropping
stuff related to features not to be implemented in 2.0.
2010-01-04 18:22:10 +00:00
David Mudrak
e554671dc4 Assessments overrides and feedbacks
This requires the patch of MDL-20623 to be applied
2010-01-04 18:20:24 +00:00
David Mudrak
77f43e7d1a Frozen grid rubric layout fix 2010-01-04 18:20:10 +00:00
David Mudrak
407b1e9177 VIP Assessment review 2010-01-04 18:19:58 +00:00
David Mudrak
1696f36cf2 Fixed submission grade aggregation
Overriding the submission grade influence the total grade, not the
aggregated one.
2010-01-04 18:19:48 +00:00
David Mudrak
43b34576a4 Assessment form preview handled by a dedicated script
This was part of assessment.php but it makes the things too complicated.
2010-01-04 18:19:37 +00:00
David Mudrak
f55650e6bc Grading evaluation is now configurable on-the-fly 2010-01-04 18:18:30 +00:00
David Mudrak
1fed6ce39a Workshop total grade calculation support 2010-01-04 18:18:00 +00:00
David Mudrak
b4857acb92 Display real grade values in the grading report 2010-01-04 18:17:47 +00:00
David Mudrak
39411930fa Grading grades aggregations 2010-01-04 18:17:37 +00:00
David Mudrak
d5506aac98 Moving some helper functions from the renderer to the workshop API 2010-01-04 18:15:48 +00:00
David Mudrak
130ae6196d Fixed a phpDoc param type 2010-01-04 18:14:12 +00:00
David Mudrak
ad6a8f6911 Grading evaluation - best subplugin
I am not happy with the algorithm at all. We should replace it with some
more sophisticated subplugin, using ICC or some similar statistics.
2010-01-04 18:14:01 +00:00
David Mudrak
e9a90e6916 aggregate_submission_grades() refactoring to allow unit testing 2010-01-04 18:12:44 +00:00
David Mudrak
4efd7b5d5f Improved the workshop constructor to support unit testing
Thanks to Tim Hunt for the hint.
2010-01-04 18:12:32 +00:00
David Mudrak
8a1ba8ac04 MDL-20264 work in progress on grading evaluation support
Also fixes small bugs in workshop api constructor and in using "scales"
instead of "scale" for the core table name.
2010-01-04 18:12:12 +00:00
David Mudrak
89c1aa977b MDL-20058 Grading report, aggregation of submission grades
Not finished yet
2010-01-04 18:11:48 +00:00
David Mudrak
d895c6aaf5 Improved context handling
Getting a context from instance is very cheap and I can actually do it
just once when constructing the workshop API class. In the future, I
will get rid of all $PAGE->context which is actually meant for things
like blocks etc.
2010-01-04 18:11:35 +00:00
David Mudrak
5e71cefbba Work in progress: grading report refactoring 2010-01-04 18:10:28 +00:00
David Mudrak
61b737a51c Adding percent_to_value() helper + its unittests 2010-01-04 18:10:18 +00:00
David Mudrak
a3610b08f4 Workshop planner tool now correctly counts the submissions and allocations 2010-01-04 18:09:18 +00:00
David Mudrak
934329e50c Make sure we do not pass empty arrays to $DB->get_in_or_equal() 2010-01-04 18:08:58 +00:00
David Mudrak
29dc43e7e4 MDL-20058 first prototype of the grading report renderer 2010-01-04 18:08:27 +00:00
David Mudrak
00aca3c14c A lot of work here and there
DB columns userid renamed to authorid or reviewerid to make the value
clear. Improved manual allocation UI. Raw grades are stored as numeric
values from 0.00000 to 100.00000 (instead of the current 0 to 1) to be
more precise. Started to work on the Grading report (it est the overall
report of all grades form submission and grades for assessments).
2010-01-04 18:08:13 +00:00
David Mudrak
aa40adbf9f MDL-19717 workshop manual allocator - pagination support and performance issues 2010-01-04 18:07:38 +00:00
David Mudrak
45d24d396e Added the skelet for grading evaluation subplugins 2010-01-04 18:06:26 +00:00
David Mudrak
f05c168d2e MDL-20236 overall codebase architecture cleanup and fixing regression
See the issue description for more details
2010-01-04 18:05:48 +00:00
David Mudrak
6516b9e9e4 Added instructions for submitting
File API seems to be broken right now so I can't test properly. The new
mod/page code was re-used here.
2010-01-04 18:02:27 +00:00
David Mudrak
ddb59c778f Displays all assigned submissions to be reviewed and saves the calculated grade 2010-01-04 18:02:16 +00:00
David Mudrak
3dc78e5b04 Refactoring some critical parts
Critical issue fixed here: after recent refactorings, I called
get_users_with_capability() inside the loop in another loop! (oops :-)
This was used in my very first code using the renderers. I have learnt
I should follow the core approach (as suggested by Tim) to prepare a
data object and pass it to the renderer. The fact the renderer called
a workshop method indicated something was really wrong...

WIP
2010-01-04 18:02:05 +00:00
David Mudrak
51508f2591 Go workshop, go! 2010-01-04 18:01:50 +00:00
David Mudrak
e9b0f0ab97 Displays the list of submissions 2010-01-04 18:01:40 +00:00
David Mudrak
454e8dd965 Phases can be switched from the Workshop plan tool
There may be more conditions checks written in the future and the
explanation added on what can be expected to happen after the phase
switch.
2010-01-04 18:01:29 +00:00
David Mudrak
3189fb2d42 Uses tabs for all actions, removed temporary links 2010-01-04 18:01:15 +00:00
David Mudrak
da0b1f70c1 More work done on the Workshop Plan UI 2010-01-04 18:01:05 +00:00
David Mudrak
b761e6d9c6 Mostly working on the view.php UI plus some changes 2010-01-04 18:00:54 +00:00
David Mudrak
b13142daee Refactored the Workshop API class
Uses the PHP magic getter to access the underlying database record. Does
not do the serialization goulash, as the passed objects should be clear
database rows.
2010-01-04 18:00:34 +00:00
David Mudrak
39861053c4 MDL-20183 Uses some of the new Navigation API 2010-01-04 18:00:12 +00:00
David Mudrak
ed597c7756 MDL-20192 Allocators and grading strategies are proper subplugins now 2010-01-04 17:59:34 +00:00
David Mudrak
1dbbccb7a2 Fixed SQL quoting - double quotes needed here 2010-01-04 17:58:16 +00:00
David Mudrak
235b31c887 Reverts the double quotes surrounding SQL 2010-01-04 17:56:34 +00:00
David Mudrak
65ba104c5d Reverting Petr's suggestion - using stdClass instead of object again
I do not agree with using object() class for no real reason.
2010-01-04 17:55:02 +00:00
David Mudrak
2c3a86b0f7 Fixed function name typo 2010-01-04 17:54:46 +00:00