Commit graph

267 commits

Author SHA1 Message Date
poltawski
5966474298 blocks/rss_client: MDL-13932 Incease timeout when adding feeds
In order to stop 'slow loading feeds' causing performance problems
with standard moodle pages, i've set the timeout for simplepie quite
low. When cron runs i've set this timeout high and cache duration low.

The intention is that cron does all the hard work of connecting to remote
sites and users get this fast fast fast from cache.

However, in the case of adding a feed its probably better to try and get the
feed more agressively..
2009-07-31 21:19:55 +00:00
poltawski
6d2382b6d7 blocks/rss_client: MDL-13932 fix config_shownumentries typo
This caused incorrect rules/defaults to be added

Also add client side validation of the number
2009-07-31 21:19:37 +00:00
moodler
e530f3a97b blocks MDL-19010 Fixed a typo to make the title a string 2009-07-31 04:18:57 +00:00
poltawski
d175fe4c53 lib/simplepie MDL-7946 - improve simplepie defaults
- Specify default low connect timeout in order that 'interactive' pages are
  not slowed down by slow feeds
- Set default cache feed duration of 1 hour

In RSS feed block:
- Try really hard in cron to retreive the feed
- Set the cache duration low in order to help cron refresh the cache
2009-07-30 18:57:19 +00:00
poltawski
e760cced27 block/rss_client MDL-19970 - feeds failed to be deleted
The removing the rssfeed from cache is no longer relevant with simplepie,
but i'll create a bug to investigate clearning the cache.
2009-07-30 13:52:05 +00:00
nicolasconnault
52fa87553e MDL-19791 Fixed call to add_action 2009-07-30 06:29:38 +00:00
poltawski
53fe72ee1f block_rss_client/rsslib MDL-1393 Clean up
- Remove obsolete magpie configuration
- Remove block_rss_client_submitters which has not been used for some
  time
- Remove some block_rss_client setup from rsslib.php
2009-07-29 14:10:15 +00:00
poltawski
0864a0837b block_rss_client: MDL-13932/MDL-7946 - Switch to use Simplepie
Simplepie is actively maintained and supports a broader range of feeds
2009-07-29 13:44:28 +00:00
poltawski
6dcf276fb2 block_rss_client: MDL-13932 Fix equality typo 2009-07-29 13:13:04 +00:00
tjhunt
f1a34d8f05 block_rss_client: MDL-13932 Clean up a lot of the crap.
This was all in order to do MDL-19889!

* The old tabbed interface is gone.
* The manage feeds UI has been completely rewritten to be a few
separate sane scripts like managefeeds.php, editfeed.php and viewfeed.php
* This is used from both Admin -> plugins -> blocks ... and as a link from the block edit_form.php
* new edit_form.php for the block replacing config_istance.php.
* A lot of stuff to do with UI specific to this block has been removed from rsslib.php
2009-07-29 11:18:55 +00:00
tjhunt
e92c286c20 block contexts: MDL-19098 every block should have a context
even non-course and sticky blocks.

The parent context is block_instances.parentcontextid.

The block context should be used for checking permissions directly
related to the block, like moodle/block:view or moodle/site:manageblocks.

However, if the block is displaying information about the current page,
for example the participants block showing who 'here', then it may be
better to use the context of the page where the bloack is appearing -
in other words $this->page->context - to check permissions about the
user's ability to see participants here.

Or, if the block is displaying something stronly related to courses,
for example, a course meny block, the block should probably use the
context for $this->page->course to check permissions.
2009-07-13 08:37:34 +00:00
tjhunt
666e84584c MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-03 04:23:05 +00:00
skodak
9d7493399d MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:35:10 +00:00
skodak
bb4b6010f3 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:17:10 +00:00
tjhunt
f4d76b9cdf blocklib: MDL-19010 fix some minor problems with existing blocks. 2009-06-05 08:28:45 +00:00
stronk7
942cd61b2e MDL-19350 upgrade review - adding missing savepoints to blocks 2009-06-03 14:49:57 +00:00
tjhunt
f474a4e583 blocks: MDL-19010 Fix further blocks-related breakage, including removing all references to blocks_insance_old outside blocklib.php 2009-05-07 08:55:10 +00:00
tjhunt
cb6402296c blocklib: MDL-19010 remove no-longer-necessary global variable use from blocks 2009-05-06 09:28:26 +00:00
tjhunt
3179b0006a blocklib: MDL-19010 Fix blocks that were relying on ->instance in an unfortunate way 2009-05-06 09:15:33 +00:00
tjhunt
ad52c04f4c moodle_page: MDL-12212 Kill legacy url_... and blocks_... methods
Start calling $PAGE->set_url in all the places it will be necessary
Start of a stub implementation of $PAGE->blocks to stop other things breaking
Remove some of the special case methods in admin_page
2009-05-06 08:55:53 +00:00
stronk7
74c288a100 MDL-18577 drop enums support - step2: enums out from install.xml files 2009-05-01 14:07:43 +00:00
Jonathan Newman
4d933beb8a cvsimport fixups 2009-01-20 23:53:34 +00:00
dongsheng
60e40dda6c "MDL-14129, remove the rest error() in moodle2" 2008-12-12 04:53:32 +00:00
skodak
775f811a66 MDL-16002 rewritten upgrade locking and better upgrade progress tracking; MDL-16070 Do not use $a[0] syntax in lang packs + various other upgrade improvements and fixes 2008-08-16 12:16:01 +00:00
skodak
f432bebff2 MDL-11421 context levels fixed in capability definitions, sorting of caps by name, plug-ins may report used core caps, fixed some risks; merged from MOODLE_19_STABLE 2008-07-24 21:59:13 +00:00
Francois Marier
6800d78e06 Drift between CVS and git
- large deletions
- lucene updates
- error() => print_error()
- NO_MOODLE_COOKIES define
- various other things
2008-06-25 17:31:23 +00:00
skodak
b1f93b1512 MDL-15246 moving all remaining ddl function to adminlib, keeping old lib/ddllib.php only for BC withexisting code; fixed inline docs related to ddl 2008-06-15 10:32:50 +00:00
dongsheng
cb224386f7 "MDL-15138, fix breadcrumb nav, merged from MOODLE_19_STABLE" 2008-06-08 18:31:45 +00:00
skodak
f28f2d9022 MDL-14679 towards blocks conversion 2008-06-02 20:15:51 +00:00
skodak
219f652b91 MDL-14679 upgrade $DB conversion 2008-05-31 18:05:42 +00:00
dongsheng
957f6fc9d2 "MDL-14460, fix all the other get_context_instance, merged from MOODLE_19_STABLE" 2008-05-02 04:37:02 +00:00
dongsheng
e31a44ee20 fix print_error() call, see tracker 2008-04-23 07:29:51 +00:00
dongsheng
5656aea193 MDL-14129, fix print_error call 2008-04-23 07:25:01 +00:00
dongsheng
437c1c5050 MDL-14085, roll back some error() call 2008-04-08 01:51:00 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
skodak
df61da5331 MDL-14027 cron sometimes hangs in rss_client block; merged from MOODLE_19_STABLE 2008-03-23 16:24:29 +00:00
moodler
433c242f1a Merged new block versions from 1.9 2008-03-03 11:43:32 +00:00
moodler
2ace936bbd MDL-11960 Hide RSS block on tag pages 2008-02-29 07:05:12 +00:00
moodler
874da31fcd Merged a notice fix 2008-02-20 08:11:02 +00:00
moodler
92efb8f2dc Merged fix for notice when feed dies 2008-02-01 03:06:11 +00:00
skodak
6bf55889dd MDL-12782 magpie now uses download_file_content() - that should solve several remote RSS issues including proxy user/password + several download_file_content() improvements + other minor fixes; merged from MOODLE_19_STABLE 2007-12-31 15:37:12 +00:00
poltawski
82cb9cf40a MDL-5598 - Custom feed titles on RSS block did not allow spaces or other
useful characters ;)

merged from MOODLE_19_STABLE
2007-12-28 12:58:08 +00:00
skodak
5c10879f55 MDL-11814 use system context for pinned blocks; merged from MOODLE_19_STABLE 2007-12-20 16:25:49 +00:00
skodak
220a90c5a1 MDL-11561 admin tree improvements and bugfixing 2007-12-19 17:35:20 +00:00
scyrma
8e4636c26f Fix a bug passed on after commit of by http://lists.moodle.org/arc/commits/2007-12/msg00352.html
There shouldn't be html tags in this place.
2007-12-19 05:58:27 +00:00
scyrma
8d7924ba0b prevent some notices, cleaner code. 2007-12-11 05:10:10 +00:00
stronk7
28271c7205 Second pass. Some more default comments are out. MDL-11385 2007-09-24 22:10:13 +00:00
poltawski
325744cb14 MDL-9851 - RSS block links previously used to open in new window. Restoring this
behaviour. Had to tweak the cleaning to ensure the JS hack for XHTML complaint new
window gets through. Merged from MOODLE_18_STABLE
2007-09-03 10:26:44 +00:00
nicolasconnault
73c24ef80b MDL-10870 All files updated to new build_navigation() method. 2007-08-16 15:01:25 +00:00
stronk7
6aad3d297e Fix one-character-wrong-indentation. Nothing important. 2007-07-31 19:34:20 +00:00