moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
56818 commits 37 branches 540 tags 1.3 GiB
Commit graph

2227 commits

Author SHA1 Message Date
Tim Hunt
02a88f802e MDL-38279 questions: must have default mark positive. 2013-03-01 15:22:21 +00:00
Eloy Lafuente (stronk7)
a6a1b51259 Merge branch 'MDL-37967_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 2013-02-20 00:34:58 +01:00
Dan Poltawski
eb6dcde62d Merge branch 'MDL-38051_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 2013-02-19 11:23:56 +08:00
Jean-Michel Vedrine
c814b84573 MDL-37967 Improve XML question import format handling of duplicated files 2013-02-18 07:58:50 +01:00
Jean-Michel Vedrine
f60f3b6c39 MDL-38051 Annihilate all the CRLFs present in some questions/fixtures... 2013-02-16 14:47:07 +01:00
Jean-Michel Vedrine
a56ced75e7 MDL-37934 Blackboard_six question import fails in some cases 
Import fails if the same image is used several times
in the same field of the same question.
 2013-02-14 14:50:41 +01:00
Tim Hunt
772979e593 MDL-37896 qtype_essay: correct PARAM_CLEANHTML -> PARAM_RAW. 
It turns out that you should almost never use PARAM_CLEANHTML.
 2013-02-08 12:50:05 +00:00
Eloy Lafuente (stronk7)
34c5ea24f3 Merge branch 'MDL-37847_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2013-02-04 22:56:24 +01:00
Tim Hunt
53291c7256 MDL-37847 plain text essays were screwing up HTML special chars. 
This was incorrect use of PARAM_CLEANHTML for these inputs.

This fix also adds some unit tests to try to verify that this does not
break again in future.
 2013-02-04 13:08:26 +00:00
Tim Hunt
24ed210069 MDL-37746 qtype_shortanser: avoid normalizer_normalize dangers. 
When an error occurs, normalizer_normalize just silently returns null,
which is dangerous. Here, we wrap it in a safe helper function.
 2013-01-31 11:33:02 +00:00
ppichet
b05659dde4 MDL-29691 Improve numerical format in multianswer 
Allow the use of , as decsep in multianswer numerical subquestions
 2013-01-29 16:30:36 +08:00
Sam Hemelryk
c2e15c4619 Merge branch 'MDL-37172_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 
Conflicts:
	question/format/learnwise/format.php
 2013-01-28 17:28:54 +13:00
Jean-Michel Vedrine
0acd374832 MDL-37172 Hardcoded strings in some question imports formats 
AMOS BEGIN
CPY [unknownorunhandledtype,qformat_blackboard_six],[unknownorunhandledtype,question]
AMOS END
 2013-01-25 23:10:00 +01:00
Dan Poltawski
211fa38ca5 Merge branch 'MDL-37599_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2013-01-22 11:40:28 +08:00
Tim Hunt
fb5819b13c MDL-37599 question import: add missing string. 
AMOS BEGIN
 MOV [matcherror,question],[invalidgrade,question]
AMOS END
 2013-01-21 12:12:50 +00:00
Tim Hunt
af8ce622b0 MDL-28512 qtype essay: clean up properly when a question is deleted. 2013-01-18 11:52:33 +00:00
Dan Poltawski
5919718019 Merge branch 'MDL-37374_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2013-01-17 10:23:15 +08:00
Tim Hunt
4ca741e456 MDL-37374 questions: fix property_exists calls. 2013-01-16 11:21:03 +00:00
Dan Poltawski
1962821cf5 MDL-37313 question: fix trailing whitespace 2013-01-16 09:40:32 +08:00
Dan Poltawski
cd0523a78e Merge branch 'MDL-37313_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 2013-01-16 09:40:07 +08:00
Dan Poltawski
b175cf2c72 Merge branch 'MDL-37374_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2013-01-15 12:59:54 +08:00
Tim Hunt
3daceb9d5c MDL-37431 question preview: cron performance problem. 
This query was performing badly. The solution seems to be to add a
redundant JOIN and WHERE to the subquery.

I renamed the table aliases in the subquery to avoid name collisions
elsewhere. I am afraid that makes the diff rather unhelpful. The
    AND subq_qu.component = :qubacomponent2
line is new. The other lines have just had subq_ added.
 2013-01-11 13:03:28 +00:00
Tim Hunt
7d9ce8864a MDL-37374 questions: use property_exists rather than isset 
$a->field = null; isset($a->field) returns false, which is typical PHP.
I also improve the error handling a bit.
 2013-01-11 13:02:55 +00:00
Jean-Michel Vedrine
517f7729ca MDL-37313 Sample files with images for XML import 2013-01-11 09:44:56 +01:00
Jean-Michel Vedrine
eed2721b71 MDL-37313 Moodle XML import format should use draft file areas, not arrays 2013-01-11 09:44:55 +01:00
Eloy Lafuente (stronk7)
0858993db8 Merge branch 'MDL-35792_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2013-01-07 22:36:29 +01:00
Didier Raboud
7db20e0073 MDL-37157: Normalize short answers before comparison 
This ensures that ambiguous Unicode representations can be compared sanely.
Also add some tests to ensure it keeps working.

Thanks to Tim Hunt for the syntax check.
 2013-01-07 14:00:26 +08:00
Tim Hunt
18651b0bfa MDL-37068 qformat_learnwise: fix UTF8 and other issues. 2012-12-22 15:15:20 +00:00
Thanh Le
5b8d9521ee MDL-35792 question preview: way to update options without restarting. 
It is useful, and possible, to update the display options without
restarting the question. You now only have to restart if you are
changing the maximum mark or the behaviour.
 2012-12-22 15:15:06 +00:00
Tim Hunt
c0267dc549 MDL-32245 question bank: update URL after moving question between categories. 
Also, improve the URL when you go to edit the questions in a category.
 2012-12-20 12:12:37 +13:00
Tim Hunt
c49b83bccc MDL-32245 question bank: fix coding style in categories.php 2012-12-15 10:07:09 +00:00
Thanh Le
99231022af MDL-32245 question bank: fix moving categories between contexts. 2012-12-15 10:07:08 +00:00
Dan Poltawski
7350e439bf Merge branch 'MDL-36243_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 2012-12-11 16:24:34 +08:00
Dan Poltawski
3f358a021b Merge branch 'MDL-36025-negative-zero-MOODLE_23_STABLE' of git://github.com/mpetrowi/moodle into MOODLE_23_STABLE 2012-12-11 11:07:43 +08:00
Sam Hemelryk
2e6538382a Merge branch 'MDL-36942_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-12-11 15:04:17 +13:00
Dan Poltawski
b0473b9bf0 Merge branch 'MDL-36732_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-12-10 15:18:24 +08:00
Dan Poltawski
8ffe246d69 Merge branch 'MDL-35404_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-12-10 11:36:49 +08:00
Jean-Michel Vedrine
f62c457ece MDL-36243 question->questiontext and question->generalfeedback should always be strings 2012-12-08 20:47:32 +01:00
Tim Hunt
a0a83bd0bf MDL-36942 xml question import: don't add spaces. 
They are not necessary anyway, there is a \n character at the end of
each line.

Thanks to Richard Lobb for fining the problem and how to fix it.
 2012-11-30 15:53:30 +00:00
Tim Hunt
5d0f5f861d MDL-36732 Cloze qtype: review marks should not depend on feedback. 
The various review options should be independent.
 2012-11-30 15:52:14 +00:00
Tim Hunt
94215aa40d MDL-35404 question export: make it work with slasharguments off. 
Thanks to Brian King for working out the problem and how to fix it. I am
just committing his patch.
 2012-11-30 15:51:33 +00:00
Dan Poltawski
dceeeb29e0 MDL-36887 quiz: reorder upgrade.txt's 2012-11-30 11:44:33 +08:00
Tim Hunt
36ab57f922 MDL-36806 question files: fix unnecessary require_login call. 
quiz_question_pluginfile later does the correct check. Doing this
other check first means you get an error about changing $PAGE->context.
 2012-11-23 15:56:46 +00:00
Dan Poltawski
254d78b75f Merge branch 'MDL-36571_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE 2012-11-20 15:01:38 +08:00
Dan Poltawski
042a79870c Merge branch 'MDL-32865_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE 2012-11-20 12:05:46 +08:00
Tim Hunt
f88bd546eb MDL-36683 qtype match restore: better subq indentification. 
This is very similar to what MDL-30018 did for question_answers.
 2012-11-19 23:06:16 +00:00
Tim Hunt
4c1a35e34c MDL-36571 qtype multichoice: don't corrupt unicode characters. 
It seems that \s includes non-breaking space, and the typical one-byte
representation of that is the same as some parts of multibyte unicode
characters. Therefore, you need to include the u modifer on the regular
expressions.

Also, remove any number of <br /> at the end of the answer.

Thanks to Joseph Rézeau and Jean-Michel Vedrine for working out what the
problem was, and how to fix it.
 2012-11-19 18:20:38 +00:00
Jean-Michel Vedrine
58310f8845 MDL-32865 CLOZE Questions imported from another course end up with broken image links 2012-11-17 16:45:40 +01:00
Dan Poltawski
6211ff4c12 Merge branch 'MDL-36422-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE 2012-11-08 11:08:06 +08:00
Frederic Massart
8a73556f8d MDL-36422 question: Fixed malformed HTML in manual marking 2012-11-08 10:26:44 +08:00