Commit graph

2661 commits

Author SHA1 Message Date
Damyon Wiese
5389dfb0eb MDL-37539 Assignment upgrade: Disable submission comments if allow notes was not enabled.
For advanced upload of files only - this setting was stored in var2.
2013-01-17 12:15:00 +08:00
Damyon Wiese
f531ca72f9 MDL-37540 Assignment upgrade: Upgrade setting "Hide description before due date"
Advanced upload of files has this setting which is stored in var3.
2013-01-17 11:44:57 +08:00
Damyon Wiese
01d29b3907 MDL-37543 Assignment upgrade: convert advanced upload files "Send for marking" setting
Advanced upload files assignment type has "Enable send for marking" setting instead
of "Allow resubmissions". Needs special handling in upgrade code to convert to
"Require students click submit button".
2013-01-17 11:05:31 +08:00
Damyon Wiese
cb5b486040 MDL-37547 Assignment: Add unit tests for mod/assign/lib.php 2013-01-16 16:36:19 +08:00
Damyon Wiese
f93fdcef86 MDL-37546 Assignment fix assign_get_recent_mod_activity code cleanup regression. 2013-01-16 13:48:15 +08:00
Damyon Wiese
425a634b58 MDL-37527 Assignment - Change query for print_overview so it uses an index (postgres)
Reported by Mark Neilsen.
2013-01-16 13:20:27 +08:00
Eloy Lafuente (stronk7)
493d8f781c Merge branch 'MDL-37354-master' of git://github.com/mouneyrac/moodle
Conflicts:
	message/tests/externallib_test.php
2013-01-15 21:50:31 +01:00
Dan Poltawski
0a9b944a15 Merge branch 'MDL-36587-master' of git://github.com/damyon/moodle
Conflicts:
	mod/assign/locallib.php
2013-01-15 11:19:40 +08:00
David Monllao
6b21986911 MDL-37457 testing Mark current classes as deprecated 2013-01-15 11:07:45 +08:00
David Monllao
5c3c2c81be MDL-37457 testing Refactoring references 2013-01-15 11:07:43 +08:00
Sam Hemelryk
0fe5a201c0 Merge branch 'MDL-37030-master' of git://github.com/damyon/moodle
Conflicts:
	mod/assign/locallib.php
	mod/assign/submission/onlinetext/locallib.php
2013-01-15 10:37:54 +13:00
Sam Hemelryk
2d971403e6 MDL-31682 mod_assign: fixed since version on new service. 2013-01-15 10:27:40 +13:00
Sam Hemelryk
ddca5610d3 Merge branch 'MDL-31682' of git://github.com/Lightwork-Marking/moodle
Conflicts:
	mod/assign/version.php
2013-01-15 10:21:20 +13:00
Dan Poltawski
5c2aacc21c Merge branch 'MDL-37143-master' of git://github.com/mouneyrac/moodle 2013-01-14 15:34:29 +08:00
Jerome Mouneyrac
fb695f6e3d MDL-37354 clean return value for each externallib PHPUnit tests 2013-01-09 13:47:01 +08:00
Sam Hemelryk
7316589831 MDL-36904 mod_assign: Fixed whitespace issue 2013-01-09 12:33:29 +13:00
Sam Hemelryk
6f51092fbe Merge branch 'MDL-35413-master' of git://github.com/damyon/moodle
Conflicts:
	mod/assign/locallib.php
2013-01-09 11:59:43 +13:00
Damyon Wiese
e00b5c454c MDL-37244 Assignment: Submission comments plugin does not implement comments callbacks.
This allows anyone to view or modify anyone elses submission comments.
2013-01-07 10:48:26 +08:00
Damyon Wiese
47f48152f7 MDL-35413 Assignment: Add unit tests (lots of them). 2013-01-04 15:51:08 +08:00
Damyon Wiese
e5403f8c44 MDL-36904 Assignment: Fix all errors and warnings from codechecker 2013-01-04 15:46:15 +08:00
Damyon Wiese
d6c673ed4e MDL-36712: Assignment - Do not always send feedback available emails when grade is created
The entry in the assign_grades table contains grades feedback and other settings such as locked.
Only send the student an email about new feedback if it is actually grades or feedback that
has been added. This is done by using another state for the mailed flag (2) which means "unset".
2013-01-04 14:46:14 +08:00
Paul Charsley
c144959c4d MDL-31682 added mod_assign_get_submissions web service function 2013-01-03 09:46:59 +13:00
Dan Poltawski
b20d65f271 Merge branch 'MDL-37037-master' of git://github.com/damyon/moodle 2012-12-24 12:23:03 +08:00
Sam Hemelryk
bef123d608 Merge branch 'MDL-36966-master' of git://github.com/damyon/moodle 2012-12-24 11:16:26 +13:00
Damyon Wiese
2406815bbf MDL-37030 Assignment: Fix error on download all submissions.
When group submissions and blind marking are enabled, an error is thrown
when a teacher trys to download all submissions in a zip. The fix is to
move the url rewriting from the plugin to the assign class so it is
done in a standard way by all modules. The rewriting is done to make images
in a text editor field resolve correctly.
2012-12-18 12:17:25 +08:00
Damyon Wiese
afa3e637a4 MDL-37037 Assignment Some minor refactoring of the previous patch
This just makes the control flow a bit easier to read.

I also added a continue button to take you back to the grading page.
2012-12-18 09:19:23 +08:00
Michael Aherne
5c77835865 MDL-37037 assign Show message if no files to download 2012-12-18 08:54:10 +08:00
Damyon Wiese
64220210de MDL-35740 Assignment: Change the assignment index page to use a renderer.
This also cleans up the patch to prevent students from seeing the number of submissions for the assignment.
2012-12-18 08:44:53 +08:00
Raymond Wijaya
0c631fbef6 MDL-35740 Assignment: Hide the number of assignment submissions for all students that was visible to all students through the activities block 2012-12-18 08:44:53 +08:00
Raymond Wijaya
f81dc1222d MDL-36966 Assignment: Bug - Student submission appears graded by themselves.
Fix a bug when a student editing his submission after it has been graded, it changes the 'graded by' details to the student's name in the feeback summary
2012-12-18 08:39:31 +08:00
Damyon Wiese
0c7b691035 MDL-37165 Assignment: Oracle fix for count_submissions_with_status (and friends).
Oracle does not like the use of AS after a join.
2012-12-14 15:10:06 +08:00
Jerome Mouneyrac
8118dbd02f MDL-37143 External_warnings: developer should be able to modify the item/itemid/errorcode description 2012-12-13 11:15:50 +08:00
Cathal O'Riordan
6d976f3f30 MDL-36644 Assignment: prepend the course upload limit to the options array
Ensure that the course upload limit is the first option in the list of available choices for the Maximum submission size select.
2012-12-12 08:56:59 +08:00
Eloy Lafuente (stronk7)
6b9dfe731e MDL-37032 upgrade: define all the 2.4.0 points 2012-12-11 13:11:11 +01:00
Dan Poltawski
c3c2fc538a Merge branch 'MDL-36712-master' of git://github.com/damyon/moodle 2012-12-11 14:00:25 +08:00
Dan Poltawski
021504b547 Merge branch 'MDL-36591-master' of git://github.com/damyon/moodle 2012-12-11 13:56:28 +08:00
Kirill Astashov
9b7a5f654a MDL-36587 Assignment: Hide Download All links when no submission have been made 2012-12-11 11:25:05 +08:00
Dan Poltawski
74bf44284a Merge branch 'MDL-35476-master' of git://github.com/damyon/moodle 2012-12-11 10:49:12 +08:00
Sam Hemelryk
fc6acfe242 Merge branch 'MDL-36905' of git://github.com/rwijaya/moodle 2012-12-11 15:44:37 +13:00
Dan Poltawski
6434a6c76e Merge branch 'MDL-34052-master' of https://github.com/damyon/moodle 2012-12-11 10:39:19 +08:00
Sam Hemelryk
4e0c4ec70d Merge branch 'MDL-36263-master' of git://github.com/damyon/moodle 2012-12-11 10:17:57 +13:00
Dan Poltawski
6aa4fccc74 MDL-36167 fix trailing whitespace 2012-12-10 17:35:58 +08:00
Dan Poltawski
76089dc378 Merge branch 'MDL-36167-master' of git://github.com/damyon/moodle 2012-12-10 17:31:41 +08:00
Damyon Wiese
8f7e1c05af MDL-36263 Assignment: Do not count submissions of unenrolled users 2012-12-10 14:54:24 +08:00
Damyon Wiese
7a9fd6da43 MDL-36908 Assignment: Additional fixes for preventing empty submissions 2012-12-10 14:54:24 +08:00
Dan Poltawski
3b49f655b2 Merge branch 'MDL-36856' of git://github.com/kastashov/moodle 2012-12-10 14:04:22 +08:00
Dan Poltawski
9278e2dbef Merge branch 'MDL-36835-master' of git://github.com/damyon/moodle 2012-12-10 14:01:56 +08:00
Eloy Lafuente (stronk7)
b9896f9613 ie9 svg compatibility fixes 2012-12-03 19:53:36 +01:00
Aparup Banerjee
552160e844 Merge branch 'MDL-36912-master' of git://github.com/FMCorz/moodle 2012-12-03 15:54:52 +08:00
Dan Poltawski
e1c93ed97b Merge branch 'MDL-36914-master' of git://github.com/damyon/moodle 2012-12-03 14:45:04 +08:00