Commit graph

4012 commits

Author SHA1 Message Date
Andrew Nicols
4fa300b78f Merge branch 'MDL-76415-master' of https://github.com/meirzamoodle/moodle 2023-02-16 11:31:42 +08:00
Ilya Tregubov
26af3bc26e MDL-76313 forum: code style changes. 2023-02-16 10:59:55 +08:00
Ilya Tregubov
f85505169b Merge branch '76313-forum-improve-accessibility-master' of https://github.com/DSI-Universite-Rennes2/moodle 2023-02-16 10:59:32 +08:00
Meirza
1e8ed4e305 MDL-76415 mod_forum: Fixed ${var} string interpolation deprecations.
Since PHP 8.2, placing the dollar sign outside the curly brace is deprecated when
the expression inside the braces resolves to a variable or an expression.
2023-02-13 19:51:47 +07:00
Jun Pataleta
d1d808b5b4 Merge branch '76314-forum-fix-forumtype-and-groupmode-validation-master' of https://github.com/DSI-Universite-Rennes2/moodle 2023-02-13 11:39:22 +08:00
Julien Boulen
9f3baf8c4f MDL-76314 forum: add form check to prevent combining wrong parameters
Form validation prevents combining the forum type "single discussion" and the group mode "separate groups".
2023-02-10 11:07:21 +01:00
Julien Boulen
0b1e4b57b6 MDL-76312 forum: sort subscribers list by fullname 2023-02-10 10:26:31 +01:00
Jun Pataleta
5587484e3c Merge branch 'MDL-76652-master' of https://github.com/lameze/moodle 2023-01-24 18:45:46 +08:00
Jun Pataleta
fad05d7929 Merge branch 'MDL-76583-master-withoutrename' of https://github.com/andrewnicols/moodle 2023-01-19 09:44:48 +08:00
Andrew Nicols
a3cc26f8bb MDL-76583 core: Update uses of external_* classes 2023-01-19 07:34:09 +08:00
Paul Holden
af8da7c737 MDL-70070 phpunit: correct data provider method names.
They should not be prefixed `test_` because that's how actual
test methods containing assertions are identified by PHPUnit.
2023-01-16 08:28:37 +00:00
David Mudrák
50ba9dc72c MDL-76739 lang: Use the fixed strings in the tests, too 2023-01-12 09:17:27 +08:00
Helen Foster
975a127325 MDL-76739 lang: Import fixed English strings (en_fix) 2023-01-12 09:17:27 +08:00
Andrew Nicols
c81fbbfec9 Merge branch '66924-view-own-private-reply-master' of https://github.com/DSI-Universite-Rennes2/moodle 2023-01-11 15:52:41 +08:00
Julien Boulen
5f493679c3 MDL-76313 forum: improve accessibility on subscribers page
- add header on table of subscribers
- remove one redundant header
2023-01-10 11:16:31 +01:00
Julien Boulen
b87ead3384 MDL-66924 mod_forum: Allow users to see their own private messages
Allow users to see their own private messages even if they don't have
mod/forum:readprivatereplies capability

Add behat test to avoid MDL-67109 issue.

Co-authored-by: Martin Putzlocher <mputzi@users.noreply.github.com>
2023-01-09 14:41:01 +01:00
Simey Lameze
59a459c5e7 MDL-76652 behat: use data generator and remove duplicated steps 2023-01-09 10:16:14 +08:00
Simey Lameze
00bd42ea5d MDL-76652 behat: add coverage for postwithoutthrottling logic 2023-01-09 10:16:14 +08:00
Paul Holden
e395dff081 Merge branch 'MDL-32114-master' of https://github.com/srobotta/moodle 2023-01-06 11:20:46 +00:00
Ilya Tregubov
db1b807270 MDL-76251 mod_forum: Fix illegal whitespace. Another try. 2023-01-06 16:41:59 +07:00
Ilya Tregubov
f6a3144275 MDL-76251 mod_forum: Fix illegal whitespace. 2023-01-06 16:08:17 +07:00
Stephan Robotta
4a31dd69d6 MDL-32114 form: markdown must be preserved on saving post
- Markdown is saved to the DB, no conversion to HTML to keep
  ability to reedit the content without beaking it.
- Blockquote element is styled that it's distingishable from
  normal text.
2023-01-05 18:34:44 +01:00
Aya Saad
7c074d8b8e MDL-76251 mod_forum: fix responsive issues in discussion 2023-01-05 11:47:15 +02:00
Amaia Anabitarte
31d84aaa2c MDL-75441 mod_forum: Show add new post button to guest users 2022-12-13 18:49:53 +01:00
Ilya Tregubov
05535e38df Merge branch 'MDL-76497-master' of https://github.com/junpataleta/moodle 2022-12-01 08:56:09 +03:00
Ilya Tregubov
9ba9589f09 Merge branch 'MDL-74853-master' of https://github.com/marinaglancy/moodle 2022-12-01 08:55:34 +03:00
Andrew Nicols
f4053b291b Merge branch 'MDL-65939-master' of https://github.com/ewallah/moodle 2022-11-29 15:41:14 +08:00
Marina Glancy
a800e7e62f MDL-74853 various: add second parameter to htmlentities functions
Default value of the $flag argument changed in PHP 8.1 from ENT_COMPAT to ENT_QUOTES | ENT_SUBSTITUTE
To ensure consistent behavior across different PHP version the second parameter is now required for the functions:
htmlspecialchars(), htmlentities(), htmlspecialchars_decode(), html_entity_decode() and get_html_translation_table()
2022-11-28 16:12:20 +01:00
Jun Pataleta
c6ab792ddf MDL-76497 upgrade: add the 4.1.0 separation line to all upgrade scripts 2022-11-28 14:43:04 +08:00
Andrew Nicols
08a19dbed8 Merge branch 'MDL-76403-master' of https://github.com/junpataleta/moodle 2022-11-24 10:18:22 +08:00
Helen Foster
74828e8149 MDL-76395 lang: Import fixed English strings (en_fix) 2022-11-23 17:03:58 +00:00
Jun Pataleta
00bae8b8a4 MDL-76403 versions: bump all versions and requires near release 2022-11-23 09:45:23 +08:00
Sara Arjona
2322d783dc Merge branch 'MDL-73620-master_grouperror' of https://github.com/alexmorrisnz/moodle 2022-11-17 18:00:21 +01:00
info@eWallah.net
1f16e9b76f MDL-65939 phpunit: Maildigest tests can query a wrong adhoc task 2022-11-17 15:54:58 +01:00
Andrew Nicols
eecbc3ce15 MDL-70071 forum: Convert post threshold warnings to info 2022-11-03 13:10:22 +08:00
Víctor Déniz
04d8fc6070 Merge branch 'MDL-68437-master' of https://github.com/mihailges/moodle 2022-10-28 17:44:50 +01:00
Alex Morris
43fd7457e3
MDL-73620 mod_forum: Fix issue with discussion permission check
Users with access to some groups but not all would receive an error
page when creating a discussion topic that was set to send to all
groups
2022-10-11 08:30:38 +13:00
Mihail Geshoski
de4d940d41 MDL-68437 forum: Support to show only active course users in grader
The following change adds support to show only active course users
in the forum grader and generally replicates the behaviour from the
assignment grader which relies on certain config settings, user
permissions and capabilities.
2022-09-30 12:01:08 +08:00
Eloy Lafuente (stronk7)
0ed53be9b2 MDL-66902 tests: Fix all incorrect namespaces
This issue just goes over all the currently incorrect
namespaces in test cases and:

1. Change the namespace to the correct one.
2. Move/rename it to correct location if needed (level 2 and down).
3. Remove not needed MOODLE_INTERNAL check when possible.
4. Remove file phpdoc when the file only has one class.
5. Make small adjustments in case the change of namespace requires it.
2022-09-26 14:12:16 +02:00
Mihail Geshoski
3001995be8 MDL-75153 grade: Update behat tests 2022-09-20 00:17:56 +08:00
Andrew Nicols
d0f6744d66 Merge branch 'MDL-75029' of https://github.com/paulholden/moodle 2022-08-18 11:17:19 +08:00
Andrew Nicols
903f04a320 Merge branch 'MDL-74608' of https://github.com/timhunt/moodle 2022-08-18 10:52:02 +08:00
Tim Hunt
8babdbd396 MDL-74608 activities: a new option to force the activity language
For a long time, Moodle has had the feature to force the language
for a whole course. This change adds the same feature at activity
level.

The course-level feature was controlled by a capability
moodle/course:setforcedlanguage, and I decided to use the same
capability to control this feature. I think a new capability would be
overkill.
2022-08-15 22:15:52 +01:00
Paul Holden
e15444e1ec MDL-75029 block_news_items: indicate posts made by deleted users. 2022-08-04 09:43:30 +01:00
Kevin Pham
c67bc6c10a MDL-49795 mod_forum: Add usermodified foreign key to forum_discussions 2022-08-03 15:17:04 +10:00
Jun Pataleta
3c6fdb1993 Merge branch 'MDL-71062-master' of https://github.com/sharidas/moodle 2022-07-13 11:39:08 +08:00
Sujith Haridasan
73d604369d MDL-71062 core: Step 1 deprecation of print_error function 2022-07-13 08:20:54 +05:30
Eloy Lafuente (stronk7)
b12b4c10a4 MDL-71747 upgrade: remove adhoc tasks not used anymore
This code was used only by deleted upgrade steps so it's safe
to proceed with straight deletion, considering it internal.
Deletion has been documented in corresponding upgrade.txt files:

  - \mod_forum\task\refresh_forum_post_counts adhoc task

And these is the list of code that has NOT been removed
because it may be needed in the future:

  - \core_search\manager::clean_up_non_existing_area(), used by
  - adhoc task: \core\task\clean_up_deleted_search_area_task adhoc task
2022-07-07 20:30:11 +02:00
Eloy Lafuente (stronk7)
58b56e2395 MDL-71747 upgrade: remove all the < 3.9.0 upgrade steps
This just deletes all the upgrade steps previous to 3.9.0. Some
small adjustments, like tweaking globals can also be applied
when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2020061500 (v3.9.0) as anti-cheating measure.

The next commits will proceed to deprecate / remove functions
that were exclusively (usually belonging to upgradelib) being
used by those, now removed, upgrade steps. This is the list
of code to remove and document in upgrade.txt files:

  - upgrade_analytics_fix_contextids_defaults()
  - upgrade_convert_hub_config_site_param_names()
  - upgrade_rename_prediction_actions_useful_incorrectly_flagged()
  - \mod_forum\task\refresh_forum_post_counts adhoc task.

And these is the code that has NOT been removed
because it may be needed later (no matter there aren't uses now):

  - \core_search\manager::clean_up_non_existing_area(), used by
  - \core\task\clean_up_deleted_search_area_task adhoc task
2022-07-07 19:16:37 +02:00
Jun Pataleta
f9af45eff5 Merge branch 'MDL-75058-master' of https://github.com/jleyva/moodle 2022-07-07 12:07:55 +08:00