Commit graph

29698 commits

Author SHA1 Message Date
Víctor Déniz
8c5c7070c0 MDL-73582 registration: Add endpoint to provide version to linkchecker 2022-02-16 20:40:23 +00:00
Eloy Lafuente (stronk7)
ebdb05461b Merge branch 'MDL-73373-master-fix' of https://github.com/junpataleta/moodle 2022-02-16 17:30:24 +01:00
Sara Arjona
73a9aa130f Merge branch 'MDL-73854-master' of https://github.com/HuongNV13/moodle 2022-02-16 17:20:03 +01:00
Jun Pataleta
3d6255b749 MDL-73373 output: No Enrolments in tertiary nav in module context
Enrolments should not be displayed on the tertiary navigation
when it is being displayed in the module context.
2022-02-17 00:18:41 +08:00
Jun Pataleta
57ba064022 MDL-73912 templates: Proper type value for back to user menu button 2022-02-16 22:46:47 +08:00
Jun Pataleta
6b65550240 Merge branch 'MDL-73373-master' of https://github.com/peterRd/moodle 2022-02-16 21:14:26 +08:00
Jun Pataleta
ed3d0904ff Merge branch 'MDL-73248-master' of https://github.com/sarjona/moodle 2022-02-16 21:09:52 +08:00
Ilya Tregubov
08d2c0fb9f Merge branch 'MDL-73868-master' of https://github.com/sarjona/moodle 2022-02-16 13:04:52 +02:00
Jun Pataleta
8c609a715a Merge branch 'MDL-73827-master' of https://github.com/sarjona/moodle 2022-02-16 16:52:08 +08:00
Shamim Rezaie
3e88bfd5b6 Merge branch 'MDL-73721-master' of git://github.com/rezaies/moodle 2022-02-16 14:24:01 +11:00
Peter Dias
2bbc664302 MDL-73373 navigation: Fix breadcrumbs when within a course.
Disable the mycourses node from showing up in the breadcrumbs
if it is set as the default homepage
2022-02-16 10:59:43 +08:00
Peter Dias
9170025088 fixup! MDL-73373 roles: Enable tertiary navigation in module context 2022-02-16 09:28:04 +08:00
Paul Holden
4ad5dda50d MDL-73822 user: fix Gravatar integration for missing user images. 2022-02-15 20:52:58 +00:00
Ilya Tregubov
256804d2ed Merge branch 'MDL-73532-master-1' of https://github.com/mihailges/moodle 2022-02-15 13:37:24 +02:00
Andrew Nicols
0491ccb6c8 MDL-73883 behat: Display actual step during testing
Because of the way in which we check for exceptions, we always show the
following string during behat pretty output:

    behat_hooks::i_look_for_exceptions()

We can easily modify this to only show this value when the
i_look_for_exceptions() test itself fails, but otherwise to show the
actual step that is run.
2022-02-15 14:57:00 +08:00
Huong Nguyen
46bbf6e74b MDL-73854 Calendar: Fix calendar controls cannot be translated
Fix the issue that calendar page and block are showing only English names
of next and previous months despite switching the language
2022-02-15 12:16:32 +07:00
Jun Pataleta
5725b0f950 MDL-73721 enrol: Pre-fill enrolled users node
Add the Enrolled users in the tertiary navigation when the user has
the capability to view enrolled users but not review enrolments but has
other user administration capabilities in the course.
2022-02-15 15:22:09 +11:00
Jun Pataleta
b503ab169e Merge branch 'MDL-73826' of https://github.com/stronk7/moodle 2022-02-15 11:51:44 +08:00
Peter Dias
bdf4f8a651 MDL-73273 navigation: Add checks to enforce action param types
* Added checks in navigationlib to enforce the data type of the passed in action
* Add nodes with non moodleurls to the end of the secondary nav
2022-02-15 11:30:07 +08:00
Sara Arjona
c4e6ac585d MDL-73868 oauth2: Remove multiple slashes in image URL
There is an issue with the current Badgr manifest because the image
URL contains double slash which is causing an error when storing it
in the database (https://api.test.badgr.com/static//images/logo.png).
This issue parses image URL and removes multiple slashes in URL.
2022-02-14 11:30:19 +01:00
Mihail Geshoski
bf27303955 MDL-73532 navigation: Update unit tests
Updates the existing unit tests related to the secondary navigation
class and includes cases where the given course uses single activity
format.
2022-02-14 09:35:04 +08:00
Mihail Geshoski
98c89410f9 MDL-73532 navigation: Secondary navigation for single activity course
Creates secondary navigation dedicated for the single activity course
format. To accomodate these chanages a new property
'showchildreninsubmenu' is introduced in navigation_node which can be
used to define whether the node's children should be displayed in a
submenu when applicable. Also, new method get_page() is added in
settings_navigation which can be used to get the $page class property.
2022-02-14 09:35:03 +08:00
Eloy Lafuente (stronk7)
d66a5316ae MDL-73826 phpunit: Allow curl mock responses to handle empty strings
Before this commit, is_empty() was being applied before returning
the mock response. But we want to be able to mock the empty response
for some tests, hence moving the condition to null/isset, that is
the value that array_pop() returns where there aren't more elements
in the array.

With that change performed, we can test lti_load_cartridge() with
empty responses, hence adding a new test for that.
2022-02-11 23:50:05 +01:00
Sara Arjona
ee289b4286 Merge branch 'MDL-69542-master-fixes-historyfix' of https://github.com/snake/moodle 2022-02-11 17:07:43 +01:00
Sara Arjona
256232ad46 MDL-73248 adminpresets: Improvements to the Starter preset
This is the list of changes applied to the Starter preset, following
the community suggestions and the latest features included in 4.0:

- Hide Online users, Recently accessed courses and Starred courses.
- Re-enable Description and Essay question types.
- Disable guest enrolment and hide guest login button.
- Reduce the information displayed in the activity chooser.

Apart from that, the User menu items has been removed because it had
the same value in both presets (so it makes no sense having there).
2022-02-11 16:41:06 +01:00
Jun Pataleta
9af545659c Merge branch 'MDL-72928-rebase' of https://github.com/Chocolate-lightning/moodle 2022-02-11 22:28:11 +11:00
Jun Pataleta
ae14ff321b MDL-72928 core: Remove Remember username 2022-02-11 12:01:26 +08:00
Mathew May
ecb92c7ed9 MDL-72928 login: Update styling and functionality 2022-02-11 12:01:26 +08:00
Jake Dallimore
66b76c4545 MDL-69542 enrol_lti: remaining changes for dynamic registration support
- Allow the tool to generate secure, one time, dynamic registration
URLs for use in supporting platforms.
- Registration endpoint, which validates the one time URL, makes
the registration requqest to the platform and adds the approriate
tool registration changes in the tool on success.
- Admin settings pages make use of the 'copy to clipboard' module
which is now in core.
2022-02-11 11:06:05 +08:00
Jake Dallimore
c9636d261b MDL-69542 core_lib: make lti tool generator default to legacy version
This means existing tests won't need to change.
2022-02-11 11:01:26 +08:00
Jake Dallimore
6c0ffde138 MDL-69542 libraries: Add the LTI 1.3 library 2022-02-11 10:07:39 +08:00
Limekiller
3c60f8a0ce MDL-73450 installation: Support Aurora MySQL >= 8.0.0 2022-02-10 15:14:35 -05:00
Eloy Lafuente (stronk7)
83497580cb Merge branch 'MDL-73669-master' of https://github.com/marinaglancy/moodle 2022-02-10 16:39:06 +01:00
Ilya Tregubov
8685968870 Merge branch 'MDL-73764' of https://github.com/stronk7/moodle 2022-02-10 14:18:34 +02:00
Sara Arjona
3daeecd3d2 MDL-73827 lib: Fix URL blocked error for userinfo endpoint
When the oAuth2 issuer hasn't any userinfo endpoint, a call to
$this->get(false) was done, which was returning "The URL is
blocked".
This is a regression from MDL-70649, which added some cURL security
checks.
2022-02-10 10:43:38 +01:00
Paul Holden
ff6e5cc71d MDL-73797 output: swap order of buttons in save/cancel dialogs.
The primary button should swap position with the secondary button,
so that it's displayed on the right hand side of the dialog.
2022-02-10 08:34:04 +00:00
Shamim Rezaie
e30493108d Merge branch 'MDL-73722' of https://github.com/paulholden/moodle 2022-02-10 17:21:10 +11:00
Bas Brands
d9cefeba09 MDL-73795 theme_boost: align header actions on mobile 2022-02-09 15:06:04 +01:00
Ilya Tregubov
7e34d42298 Merge branch 'MDL-73773' of https://github.com/paulholden/moodle 2022-02-09 13:28:43 +02:00
Jun Pataleta
7d743b255d Merge branch 'MDL-73633-master' of git://github.com/mihailges/moodle 2022-02-09 17:45:54 +08:00
Eloy Lafuente (stronk7)
3bb4a4009c MDL-73764 tool_xmldb: Regenerate all the files detected by the report
Note that, instead of going one by one to them from the XMLDB Editor
(load, makes some tiny change, save, revert the change, save), the
report includes a commented line that, once uncommented, does regenerate
the file while reporting.

I've left it there as a commodity for the developer.
2022-02-08 19:25:03 +01:00
Jun Pataleta
939cb7a90f Merge branch 'MDL-72246-master-2' of https://github.com/andrewnicols/moodle 2022-02-08 11:36:59 +08:00
Andrew Nicols
70cc41eec8 MDL-72246 core_completion: Only fetch other completion data on requested
Prior to this patch, the code was fetching all completion data for all
activities in a course, even when the activity was not requested. This
leads to recursion issues as the data has not been added to the cache
before this operation occurs.

To handle this situation, only the requested CM is fetched in full, and
a boolean flag is used to store whether the full data has been fetched.

When returning a partially fetched value from the cache, the flag is
used to determine whether more data must be fetched, and the cache
updated.

The flag is filtered out before the value is returned.

Note: Many of the tests were updated as these were inspecting private
features of the API which should not really be tested.
2022-02-08 11:35:23 +08:00
Andrew Nicols
adc61dddc3 MDL-72246 core_completion: Test coverage improvements for completion 2022-02-08 11:22:14 +08:00
Andrew Nicols
a999b12e02 MDL-72246 core_completion: Stop testing the inner workings of get_data() 2022-02-08 11:22:14 +08:00
Andrew Nicols
95c6d3c8d9 Merge branch 'MDL-73716' of https://github.com/stronk7/moodle 2022-02-08 10:59:34 +08:00
Andrew Nicols
df154ecb72 Merge branch 'MDL-73116' of https://github.com/roland04/moodle 2022-02-08 10:57:40 +08:00
Andrew Nicols
b710e57ebd Merge branch 'MDL-73766-master' of https://github.com/lucaboesch/moodle 2022-02-08 10:54:44 +08:00
Peter Dias
81492f900f MDL-73373 roles: Enable tertiary navigation in module context 2022-02-08 09:04:04 +08:00
Eloy Lafuente (stronk7)
c5e2a4ded0 Merge branch 'MDL-73601-master' of https://github.com/aanabit/moodle 2022-02-07 12:01:19 +01:00