Commit graph

111143 commits

Author SHA1 Message Date
Mark Johnson
0ac2936c11
MDL-74054 questions: Fix question bank header widths
Chrome ignores min-width on table headers with table-layout:fixed,
meaning that question bank headers could be resized so that the controls
were overlapping, and could be too narrow by default.

This removes min-width: min-content in the headers and instead uses
Javascript to calculate a constrain a min width based on the content of
the headers.
2023-09-22 22:52:36 +08:00
Ilya Tregubov
216060b637
Merge branch 'MDL-78217-master' of https://github.com/rezaies/moodle 2023-09-22 18:06:25 +08:00
Shamim Rezaie
7b8aa2daf1 MDL-78217 grade: Fixing invalid input as early as possible 2023-09-22 19:40:13 +10:00
Ilya Tregubov
403b62a06b
Merge branch 'MDL-77035-integration-master' of https://github.com/mihailges/moodle 2023-09-22 17:37:15 +08:00
Mihail Geshoski
6a4cf000b3 MDL-77035 grades: Fix checkbox spacing to satisfy accessibility criteria 2023-09-22 11:29:53 +02:00
Huong Nguyen
67db7b900b
Merge branch 'MDL-78129-behat-remove' of https://github.com/HuongNV13/moodle 2023-09-22 13:18:49 +07:00
Huong Nguyen
9a517653b1
MDL-78129 communication_matrix: Remove Behat test
This change requires a change in the mock server which we don't have
    time to do before Beta. This will be done in the coming days and this
    commit content reverted.
This one will be re-introduced in MDL-79460
2023-09-22 13:17:21 +07:00
Huong Nguyen
af14974b13
Merge branch 'MDL-78129-behat' of https://github.com/HuongNV13/moodle 2023-09-22 11:48:08 +07:00
Huong Nguyen
436e522cd8
MDL-78129 communication_matrix: Skip Behat test
This change requires a change in the mock server which we don't have
time to do before Beta. This will be done in the coming days and this
commit content reverted.
2023-09-22 11:42:28 +07:00
Huong Nguyen
bd323aede7
Merge branch 'MDL-78129-master' of https://github.com/andrewnicols/moodle 2023-09-22 10:29:54 +07:00
Andrew Nicols
84cfc8beeb
MDL-78129 communication: Fix all phpcs isuses
This is a brand new subsystem, plugin-type, and plugin. They are written
from the ground up by us. They should not contain any coding style
violations.
2023-09-22 11:08:04 +08:00
Ilya Tregubov
d22800ca42
Merge branch 'MDL-78217-master' of https://github.com/rezaies/moodle 2023-09-22 10:53:55 +08:00
Andrew Nicols
e36d84ee31
Merge branch 'MDL-74054-master-fixes' of https://github.com/marxjohnson/moodle 2023-09-22 10:53:55 +08:00
Mark Johnson
4630043f46
MDL-74054 qbank_columnsortorder: Improve and expand unit tests 2023-09-22 10:53:54 +08:00
Mark Johnson
330908868b
MDL-74054 qbank_columnsortorder: Fix column reset by allowing null values 2023-09-22 10:53:54 +08:00
Andrew Nicols
697ac9b913
MDL-74054 qbank_customfields: Fix behat tests 2023-09-22 10:53:54 +08:00
Andrew Nicols
a3cfd50482
MDL-74054 qbank: Miscellaneous coding style fixes 2023-09-22 10:53:53 +08:00
Andrew Nicols
813c2441a1
MDL-74054 qbank_columnsortorder: Correct dataProvider name 2023-09-22 10:53:53 +08:00
Andrew Nicols
94de1567c3
MDL-74054 qbank_columnsortorder: Move away from ModalFactory 2023-09-22 10:53:53 +08:00
Mark Johnson
33e52fe4ed
MDL-74054 qbank_viewquestiontext: Convert from filter to question bank control
This replaces the "Show question text in the question list?" filter, which was
never really a filter, with a new widget displayed alongside other question bank
controls like "Create a new question" and "Reset columns".

It also refactors the logic of displaying the question text field or not, so that
it is all handled within the qbank_viewquestiontext plugin rather than relying on
code in the view.
2023-09-22 10:53:53 +08:00
Mark Johnson
63894ec2fe
MDL-74054 qbank_columnsortorder: Progressively enhance question bank actions
This modifies the question_data fragment used by the filter code to make its
parameters closer to the URL parameters of the question/edit.php page. This
Allows us to progressively enhance the add, remove and reset actions on the
question bank page, using this same fragment to reload the question table after
each change. This re-uses the same actions.js module used for enhancing these
actions on the qbank_columnsortorder admin screen.
2023-09-22 10:53:52 +08:00
Mark Johnson
3685a3355f
MDL-74054 qbank: Updates to plugins to support qbank customisation 2023-09-22 10:53:52 +08:00
Mark Johnson
82599bef84
MDL-74054 mod_quiz: Prevent question bank customisations in custom view 2023-09-22 10:53:52 +08:00
Mark Johnson
93ca1cdc32
MDL-74054 theme: Style changes to support question bank UI cusomisation 2023-09-22 10:53:52 +08:00
Mark Johnson
37d69fff6b
MDL-74054 qbank_columnsortorder: Implement add, remove and resize
This updates the admin interface, and hooks into the question bank view
for users to override admin defaults with their preferences.
2023-09-22 10:53:52 +08:00
Mark Johnson
6001ee3dfd
MDL-74054 core_question: Define unique question bank column IDs
This also resolves MDL-78829.
Some question bank plugins use a separate class for each plugin they
define. However, qbank_customfields (and potentially others in the
future) uses a single class to define multiple fields. Using the class
name as an ID for the column doesn't give us a way of reliable
instantiating an object for the column. Previously, qbank_customfields
appended the field name as though it was a namespaced class, but this
had to be manually constructed and deconstructed by detecting this
particular column class.

This change introduces a standard way of constructing a unique ID for
each question bank column, in the form
pluginname\columnclass-columnname. This ensures that the ID will be
unique for each column, and the ID can be used to instatiate the
column's object.
2023-09-22 10:53:51 +08:00
Nathan Nguyen
2be0e10a80
MDL-74054 core_question: Add additional plugin points
This refactors the question bank view class to support new plugin points
required for the question bank UI customisation features.
2023-09-22 10:53:51 +08:00
Mark Johnson
feef716c91
MDL-74054 core_question: Re-apply filters when performing a qbank action
This changes the root element used by the fragment when
applying filters, so that the whole of display_question_list()
is reloaded.

This ensures that the returnurl will be updated correctly on the
question actions and bulk actions without manipulating then
further in Javascript.
2023-09-22 10:53:46 +08:00
Andrew Nicols
2a096dc5ad
MDL-78129 communication_matrix: Skip unit test
This change requires a change in the mock server which we don't have
time to do before Beta. This will be done in the coming days and this
commit content reverted.
2023-09-22 10:51:50 +08:00
Andrew Nicols
07e0094f8c
MDL-78129 communication_matrix: Persist any user with a non-moodle power level 2023-09-22 10:44:04 +08:00
Andrew Nicols
01a3461bbb
MDL-78129 communication_matrix: Simplify power level setting
This change introduces a new API call to fetch the current power levels.

The result of this are used to fetch current admin users so as not to
remove them.

The update of existing users is simplified to only set users who do not
have the default level.
2023-09-22 10:44:04 +08:00
Andrew Nicols
eb991355fe
MDL-78129 communication_matrix: Stop marking users as synced
No need to sync users for role changes.

Power level changes do not need to happen after being added to a room.
They can happen in any order and persist after a user is removed.
2023-09-22 10:44:04 +08:00
Andrew Nicols
01679678cf
MDL-78129 communication_matrix: Coding style fixes 2023-09-22 10:44:03 +08:00
Andrew Nicols
d72ebf1bf2
MDL-78129 communication_matrix: Update room membership on unennrol 2023-09-22 10:44:03 +08:00
Andrew Nicols
2dc30d662e
MDL-78129 communication_matrix: Tidy up API calls 2023-09-22 10:44:03 +08:00
Safat
e9743431a6
MDL-78129 communication_matrix: Add support for matrix power level 2023-09-22 10:44:02 +08:00
Shamim Rezaie
59046ab0d2 Merge branch 'MDL-77035-master-2' of https://github.com/mihailges/moodle 2023-09-22 06:44:56 +10:00
Shamim Rezaie
c428c0195a MDL-78217 grade: Keep category total updated in the UI 2023-09-22 05:36:22 +10:00
Shamim Rezaie
aa30501b80 MDL-78217 grade: Recalculate Parent Weights on Zero Child Weights
The maximum grade for that category is considered as zero when all child
weights within a category are zero.
2023-09-22 05:36:22 +10:00
Shamim Rezaie
6aa05cfb9a MDL-78217 grade: Refine front-end weight handling and add validation
In this commit, the front-end experience for grade item weights in the
gradebook setup page is refined, building upon the improvements made in
the previous commit.

Firstly, overridden weights are excluded from automatic adjustments.
This enhancement guarantees that user-specified weights remain unchanged
by front-end calculations, thereby preserving the flexibility of custom
weight assignments.

Additionally, front-end form validation has been introduced to enhance
the user experience. Now, users will see validation errors if they
submit invalid values, giving them the opportunity to correct the values
themselves. This ensures that weights are not automatically normalised
by the back-end code, preserving the values as entered by the user.
2023-09-22 05:36:16 +10:00
Andrew Nicols
148e779651
Merge branch 'MDL-78649-master' of https://github.com/meirzamoodle/moodle 2023-09-21 22:25:14 +08:00
Jun Pataleta
e2f900b2ad
Merge branch 'MDL-79323-master-enfix' of https://github.com/vmdef/moodle 2023-09-21 15:29:40 +02:00
Ilya Tregubov
e25dd12c5c
Merge branch 'MDL-79341' of https://github.com/paulholden/moodle 2023-09-21 14:50:28 +08:00
Safat
3e47253787
MDL-78129 core_communication: Add update membership api 2023-09-21 13:28:20 +08:00
Ilya Tregubov
69b347d1e1
Merge branch 'MDL-71955' of https://github.com/paulholden/moodle 2023-09-21 09:14:33 +08:00
Ilya Tregubov
f647af9cc6
Merge branch 'MDL-79301-master' of https://github.com/NashTechOpenUniversity/moodle 2023-09-21 09:00:14 +08:00
Ilya Tregubov
b27e31b60d
Merge branch 'MDL-68712' of https://github.com/paulholden/moodle 2023-09-21 08:47:19 +08:00
Mathew May
7f33dfc887 MDL-77035 grades: Update toggleall for a11y 2023-09-20 23:53:44 +02:00
Mihail Geshoski
255165f786 MDL-77035 grades: Fix PHP coding style issues
Fixes some preexisting PHP coding style problems in
grade/edit/tree/index.php.
2023-09-20 23:53:44 +02:00
Mihail Geshoski
cda31407e7 MDL-77035 grades: Fix accessibility violation in modals
Adds the aria-labelledby attribute to the .modal element in order to
comply with the modal accessibility requirements.
2023-09-20 23:53:44 +02:00