Commit graph

28023 commits

Author SHA1 Message Date
Jake Dallimore
9a4cfdeabb Merge branch 'MDL-66979-master-7' of git://github.com/andrewnicols/moodle 2021-01-29 15:41:03 +08:00
Andrew Nicols
bead2a1d96 MDL-66979 behat: Add a step to set a timeout factor for a test 2021-01-29 14:15:24 +08:00
Eloy Lafuente (stronk7)
adc8204a83 MDL-66979 behat: Goutte driver doesn't implement setTimeouts()
Also, change:

get_real_timeout(30000)

to:

get_real_timeout(30) * 1000

because the original functions are defined to use seconds, and
having the 1000 around will help us detecting cases in the case
of a hypothetical review of uses.
2021-01-29 14:15:20 +08:00
Eloy Lafuente (stronk7)
653101964d MDL-66979 behat: Goutte driver doesn't implement setTimeouts()
Also, change:

get_real_timeout(30000)

to:

get_real_timeout(30) * 1000

because the original functions are defined to use seconds, and
having the 1000 around will help us detecting cases in the case
of a hypothetical review of uses.
2021-01-28 12:23:05 +01:00
Eloy Lafuente (stronk7)
2eebe68cad Merge branch 'MDL-66979-master-7' of git://github.com/andrewnicols/moodle 2021-01-28 09:07:39 +01:00
Andrew Nicols
5d8e4e9fd4 MDL-66979 behat: Set script timeout with timeout factor 2021-01-28 15:27:50 +08:00
Andrew Nicols
991c8a9e78 MDL-66979 behat: Handle driver stop failure properly
An case was found where the webdriver stop() call could fail in an
AfterScenario hook, leading to a complete rerun if no other errors were
experienced.
2021-01-28 15:07:52 +08:00
Víctor Déniz
d0e99460e7 Merge branch 'MDL-70585' of git://github.com/paulholden/moodle 2021-01-27 10:52:58 +00:00
Andrew Nicols
05fca85d8e MDL-66979 behat: Warn about old behat.yml file location 2021-01-23 20:43:20 +08:00
Paul Holden
81fdd46315 MDL-70585 course: deeper clean of path names in course export.
This fixes an issue on those systems that don't fully support unicode
characters within zip structures, which subsequently led to broken
links when browsing downloaded course content.
2021-01-22 08:15:16 +00:00
Andrew Nicols
14a267e862 MDL-66979 behat: Rename and warn on old config 2021-01-22 14:52:12 +08:00
Andrew Nicols
c876d6298e MDL-66979 behat: availability field extends textarea
The availability behat field extends the textarea type, and therefore
needs to include this type.
2021-01-22 14:52:11 +08:00
Andrew Nicols
a9bd31810f MDL-66979 behat: Improve chromeOptions configuration
Simplify the chromeOptions configuration to improve readability.
2021-01-22 14:52:11 +08:00
Andrew Nicols
7d777911af MDL-66979 behat: Remove unused var 2021-01-22 14:52:11 +08:00
Andrew Nicols
d5f211d00f MDL-66979 behat: Whitespace fix 2021-01-22 14:52:11 +08:00
Andrew Nicols
afecc583aa MDL-66979 behat: Remove manually triggered events
Behat should not trigger Synthetic browser events. It is incorrect to do
so as the UI should be used to trigger events correctly.

The W3C WebDriver specification explicitly states when and where these
events will be triggered from (the browser) and therefore there is no
ambiguity and no need to synthetically trigger them from Behat.
2021-01-22 14:52:10 +08:00
Andrew Nicols
0121d366bf MDL-66979 behat: Scroll nodes into view before hover
The W3C Specification does not require that a NodeElement be in the
current viewport before triggering a mouseOver. As a result the
mouseOver will generate an Exception because the element is not in the
viewport, and the X/Y co-ordinates are invalid.

To handle this the node is scrolled into view.
2021-01-22 14:52:10 +08:00
Andrew Nicols
6a2a2e957b MDL-66979 behat: Fix window switching
Normalise switching of window contexts by setting the main window name
to a null.

Where the window has no name (null/empty), then the root context is
selected.
2021-01-22 14:52:10 +08:00
Andrew Nicols
fd5621554a MDL-66979 behat: Update passwordunmask form field control
Update the passwordunmask form field type for behat to interact with the
form element as a human would rather than via synthetic event triggers.
2021-01-22 14:52:10 +08:00
Andrew Nicols
2a969d891a MDL-66979 behat: iFrames must have a name for switchTo
The W3C WebDriver protocol supports switching of contexts using a named
context, and not the class asscoiated with that context.
2021-01-22 14:52:10 +08:00
Andrew Nicols
041b75f00a MDL-66979 behat: Handle JS on elements better
This change introduces a new function to execute Javascript directly on
a node.

This should not, ordinarily, be used directly by steps, but may be
required in other parts of the Behat interaction.
2021-01-22 14:52:10 +08:00
Andrew Nicols
c96cde27ea MDL-66979 behat: Rename selenium config to webdriver
The PHP WebDriver Mink Driver does not necessarily require Selenium. It
supports Selenium 3 upwards, and can be used directly with ChromeDriver,
EdgeDriver, SafariDriver, GeckoDriver, and others.

It therefore uses a slightly different configuraitno path.
2021-01-22 14:52:09 +08:00
Andrew Nicols
50b9866e54 MDL-66979 behat: Core updates for W3C WebDriver
This commit updates core Behat features to make use of the
php-webdriver/webdriver library instead of the legacy Instaclick
library.

Most of these changes relate to use of features of WebDriver which we
are required to use directly rather than through the Mink Driver.
2021-01-22 14:52:09 +08:00
Jake Dallimore
3d5c1693b9 NOBUG: Fixed file access permissions 2021-01-22 11:30:38 +08:00
Jun Pataleta
afc39f38af Merge branch 'MDL-70297-master' of git://github.com/ilyatregubov/moodle 2021-01-21 12:19:15 +08:00
Adrian Greeve
3f2462a5c7 Merge branch 'MDL-57020-master-allow_delete_unused_scale' of https://github.com/sharidas/moodle 2021-01-21 12:01:32 +08:00
Jun Pataleta
a61fbcd27d Merge branch 'MDL-70301' of https://github.com/Chocolate-lightning/moodle 2021-01-21 11:33:43 +08:00
Mathew May
6d253061de MDL-70301 lib: Update thirdpartylibs scssphp 2021-01-21 10:33:09 +08:00
Mathew May
cda207d07f MDL-70301 lib: Upgrade scssphp to 1.4.1 2021-01-21 10:32:58 +08:00
Adrian Greeve
dc77f45fdb Merge branch 'MDL-70302-master' of git://github.com/peterRd/moodle 2021-01-21 09:49:55 +08:00
Peter Dias
05498a0afd MDL-70302 core: Update the lib's readme, xml and upgrade files 2021-01-21 09:32:53 +08:00
Eloy Lafuente (stronk7)
9fe648d4da Merge branch 'MDL-70055-master' of https://github.com/kabalin/moodle 2021-01-20 19:44:45 +01:00
Eloy Lafuente (stronk7)
f291fd3007 Merge branch 'MDL-70291-master-1' of git://github.com/peterRd/moodle 2021-01-20 19:17:20 +01:00
Eloy Lafuente (stronk7)
9d8e42ac31 Merge branch 'MDL-70296-master-1' of git://github.com/peterRd/moodle 2021-01-20 17:17:44 +01:00
Jun Pataleta
cc6868891d Merge branch 'MDL-70319-master' of git://github.com/ilyatregubov/moodle 2021-01-20 22:40:41 +08:00
Jun Pataleta
cdcc37ad68 Merge branch 'MDL-70300' of https://github.com/Chocolate-lightning/moodle 2021-01-20 17:13:18 +08:00
Mathew May
ca64b0af46 MDL-70300 core_lib: Update thirdpartylibs php-css-parser 2021-01-20 15:52:11 +08:00
Mathew May
f2cc1a8a34 MDL-70300 lib: Apply php css parser patches 2021-01-20 15:52:11 +08:00
Mathew May
3b244c0e16 MDL-70300 lib: Upgrade php css parser to 8.3.1 2021-01-20 15:52:11 +08:00
Jake Dallimore
5a24764390 Merge branch 'MDL-69333-fingerprint-checks' of https://github.com/brendanheywood/moodle 2021-01-20 11:23:49 +08:00
Brendan Heywood
a6e9ac9af7 MDL-69333 report_security: Add checks for many public & private urls 2021-01-20 11:19:14 +11:00
Eloy Lafuente (stronk7)
333472ce2a Merge branch 'MDL-70159' of git://github.com/paulholden/moodle 2021-01-19 23:43:55 +01:00
Jun Pataleta
b935998bee Merge branch 'MDL-70292-master' of git://github.com/ilyatregubov/moodle 2021-01-20 00:12:22 +08:00
Sara Arjona
b0f2fb291d Merge branch 'MDL-70303-master' of git://github.com/ferranrecio/moodle 2021-01-19 16:50:01 +01:00
Ferran Recio
23b681c7b5 MDL-70303 libraries: upgrade GeoIP to 2.11.0 and MaxMind DB to 1.9.0 2021-01-19 16:35:04 +01:00
Ilya Tregubov
976c6d34e5 MDL-70319 core: Moodle customizations. 2021-01-19 10:03:03 +02:00
Ilya Tregubov
c3eff2e3b4 MDL-70319 core: Upgrade php-enum to 1.7.7 2021-01-19 10:02:00 +02:00
Ilya Tregubov
db0f3ee517 MDL-70297 libraries: Moodle customizations. 2021-01-19 09:47:13 +02:00
Jake Dallimore
790cb18211 Merge branch 'MDL-69522-custom-message-m' of https://github.com/Peterburnett/moodle 2021-01-19 15:38:01 +08:00
Ilya Tregubov
602498c5e4 MDL-70297 libraries: xhprof upgraded to 2.2.3 2021-01-19 09:31:19 +02:00