Commit graph

239 commits

Author SHA1 Message Date
nicolasconnault
f04873a9ea MDL-10636
Attempting to fix a number of bugs related to backup/restore for gradebook
2007-07-28 09:23:32 +00:00
toyomoyo
b0e1ed348a MDL-10557, adding format_string prior to return of grade item name in order to support multilang filger 2007-07-27 01:59:47 +00:00
skodak
31a170930d added proper rs_close($rs) 2007-07-22 16:02:57 +00:00
skodak
23207a1a6a MDL-10563 item excluding implemented;
improved/fixed grade edit page;
some other improvements and cleanup
2007-07-21 14:24:39 +00:00
skodak
9acbd7269c MDL-10364 improved internal formula format 2007-07-21 08:43:51 +00:00
skodak
d14ae855a2 MDL-10524 fixed aggregation for course item + other minor improvements 2007-07-19 17:36:36 +00:00
skodak
3ee5c20149 MDL-10525 renaming class grade_grades and grade_grades_text - singulars for all grade class names 2007-07-19 08:15:19 +00:00
skodak
9580a21f1c MDL-9137 added new aggregation needed for upgrade - weighted + extra credit
minor item edit form cleanup
fixed minor bug in grader/lib.php
2007-07-18 19:29:32 +00:00
nicolasconnault
8c5a416edd MDL-10478 Added category preference aggregationview. This one is linked with the more global preferences and $CFG. However, a category-specific preference needs implementing: grade_report_categorystate{$catid}, which equals GRADE_CATEGORY_EXPANDED or GRADE_CATEGORY_CONTRACTED. I've written a stub in grade/report/grader/lib.php around line 492 for pruning out the grade_tree according to these prefs.
We'll also need to implement the actions for the -/+ icons.
2007-07-18 14:54:35 +00:00
nicolasconnault
5e623a335f MDL-10345 Fixed bug that changed a null scale finalgrade to 1 due to passing through bounded_number(1, null, 3) 2007-07-18 05:17:45 +00:00
skodak
cea2542bfe MDL-10111 aggragationcof for weighted categories and extra items in old gradebook 2007-07-17 07:24:35 +00:00
skodak
b8e9305e70 use min max bounds in update_final_grade() 2007-07-16 07:16:08 +00:00
skodak
79eabc2ab2 major grade editing fixes and improvements - grader form now knows if grade is editable; fixed broken quickgrading; feedback format is handled the same way as in the rest of moodle - automatically converted to FORMAT_HTML when editor enabled; fixed calculation of grades that was breaking locking 2007-07-12 22:31:20 +00:00
skodak
920a0fb2eb MDL-10437 moved editing forms to grade/edit/ directory - these should be shared by all reports, there were too many files in grader directory anyway 2007-07-12 19:40:28 +00:00
skodak
9d452f139f MDL-10364 calcualtion validation improvements 2007-07-12 17:36:18 +00:00
skodak
9029762c3c MDL-10364 calcualtion validation improvements 2007-07-12 17:23:29 +00:00
toyomoyo
7e3c9767db grade edit form, and adding set_locktime for grade_grades and grade_item 2007-07-12 06:42:44 +00:00
nicolasconnault
474bad4698 MDL-9628 Enabling multiple feedback and grades update. Feedbacks now working, but grades don't (at least scales don't) 2007-07-11 16:54:11 +00:00
skodak
a4820aef30 fixed notice in update_raw_grade 2007-07-11 14:53:47 +00:00
skodak
de359e3c2e fixed notice in update_final_grade 2007-07-11 14:33:09 +00:00
skodak
c86caae78a MDL-9137 new grade_grades field overridden; item edit form fixes; other minor fixes and improvements 2007-07-10 18:08:24 +00:00
skodak
d3f14e423d MDL-10364 fixed de/normalization of calculation formulas in item edit form 2007-07-08 19:24:41 +00:00
skodak
5132aa7fd5 fixed default needsupdate property 2007-07-08 18:18:32 +00:00
skodak
15b462da4b MDL-10226 fixed breakage in grade computing 2007-07-08 15:03:46 +00:00
skodak
f8e6e4dbea MDL-10226 improved regrading of final grades - optimised db access, partial regrading when raw grade updated 2007-07-08 14:57:19 +00:00
skodak
aaff71daf4 MDL-10365 Improved handling of history when inserting/updating/deleting in new grade reports;first part 2007-07-06 12:49:28 +00:00
skodak
c3146da7ac complete unit tests for grade_item + minor cleanup in insert and update 2007-07-04 17:52:43 +00:00
nicolasconnault
13b1072464 More language strings, minor edits. 2007-07-03 17:54:56 +00:00
skodak
6639ead31e complete unit tests for grade_category, minor API cleanup, fixed forced regrading in grade_category 2007-07-03 10:06:08 +00:00
skodak
739196ba10 MDL-10224 fixing some more regressions in grade reports; adding proper CSS; more fixes and improvements 2007-07-01 19:45:13 +00:00
skodak
f13002d53e MDL-9629 fixed regressions in grade reports caused by my previous commits, added unfinished forms for category and item edit 2007-06-30 21:12:47 +00:00
skodak
314c433698 MDL-10224 some more improvements in grader report related to total course grade and category grade + other bugfixes 2007-06-28 22:55:46 +00:00
skodak
82bf496e9c MDL-10224 finishing the commit, grrr 2007-06-28 19:18:52 +00:00
skodak
b3ac6c3ef0 MDL-10224 total course grade implemented + lots of other changes and improvements; there are still some regressions and bugs - going to fix them ASAP; some unit tests still missing too 2007-06-28 13:20:30 +00:00
nicolasconnault
97d608ba05 Changed grade_item so that its grademax is count(scale_items) and grademin is 1, to be consistent with use of scales throughout Moodle. 2007-06-26 08:50:22 +00:00
skodak
22e23c78a0 MDL-10251 finished hiding implementation for grades, items and categories + unit tests 2007-06-25 15:29:31 +00:00
skodak
79f2b1ef1c fixed locking problem in update_raw_grade() 2007-06-25 08:30:03 +00:00
skodak
c4e4068fa2 moving event trigger from update_grade() to grade_item->update_raw_grade(); removing itemnumber generation for now 2007-06-25 07:56:25 +00:00
skodak
f92dcad81a MDL-10233 improved static factory methods of grade obejcts fetch() and fetch_all(); implemented default values of grade objects, fixed null values for some properties that are not required - unit tests included, tested with PHP4 and PHP5 2007-06-24 22:26:33 +00:00
skodak
61c33818d5 MDL-10231 merge grade_calculations and grade_items table + calculation improvements
MDL-10233 fixed grade_*::fetch() - does not modify $this anymore, we can now use it from normal methods to fetch other objects of the same class.
2007-06-23 16:33:17 +00:00
skodak
2e53372c37 MDL-10226 regrading of final grades improved, calculation cleanup before MDL-10231 2007-06-22 18:33:32 +00:00
skodak
2cc4b0f90d MDL-10223 Implement locking of grades and grade items - cron support still not implemented;
this patch also contains improvements in handling of needsupdate, though it is not yet fully working for calculated grades
2007-06-22 08:57:39 +00:00
skodak
ac9b080524 MDL-10202 merge raw and final grade tables 2007-06-20 23:06:29 +00:00
skodak
df3cb76fc4 MDL-9137 calculated grades should work now, some other minor cleanup 2007-06-18 22:52:55 +00:00
skodak
c2a897b044 MDL-9137 removing obsoleted function, finals now processed only by update_final_grade() 2007-06-18 20:14:16 +00:00
skodak
b8ff92b66b MDL-9137 various grading improvements
1/ initial support for migration of old grade_items and categories (not tested)
2/ rewritten grade update and calculation logic
3/ initial support for calculation formulas
4/ minor API refactoring and cleanup
5/ various small bugfixes
6/ fixed use of grademax with scales
7/ fixed some unit tests

TODO:
* implement proper locking of grades - needs discussion
* force recalculation of all formulas after adding/removing/changing of grade items
* better delete flag support
* support for NULLs n backup - Eloy already proposed a solution
* support for NULLs in set_field()
* speedup
* more unit tests nd functional tests
2007-06-18 13:43:40 +00:00
nicolasconnault
1c307f2186 grade_item idnumber now self generated if needed.
deleted flag implemented in grade_item::update method
added GRADE_TYPE_NONE to gradelib and updated grade_item object
Implemented multiple items (generation of itemnumber when not explicitly given)
2007-06-07 12:45:24 +00:00
skodak
75e1038756 fixing uninitilaized scale problems in last commit 2007-06-06 19:16:37 +00:00
skodak
612607bd47 MDL-9516 new central grading function update_grade(); to be improved/tested more tomorrow 2007-06-05 22:58:37 +00:00
nicolasconnault
210611f6ee MDL-9629 Changed grade_item.gradetype default to 1, added GRADE_TYPE_NONE constant = 0, incrementing existing constants by 1. Set up auto-generation of idnumber for grade_item if itemmodule and iteminstance are set, only a temporary stub if they are not set (must be replaced by correct generation code). New category form now has server-side validation (not using formslib) 2007-06-05 08:50:24 +00:00