Commit graph

2120 commits

Author SHA1 Message Date
Zig Tan
6bcc6f877a MDL-61870 mod_assign: Fix/clean up imported group override duedates
- Prevent group override duedate events from being imported when groups are excluded
- Clean up any existing group override duedate events when editing assignment in upgradelib.php
- Updated lib.php unit tests
2018-08-02 12:55:12 +08:00
David Monllao
f3e240e7e0 Merge branch 'MDL-59611-master' of git://github.com/damyon/moodle 2018-07-31 13:30:41 +02:00
Jun Pataleta
77b6d458e5 Merge branch 'MDL-58768-master-2' of git://github.com/rezaies/moodle 2018-07-31 16:18:44 +08:00
Adrian Greeve
5454e72c21 MDL-55188 events: First deprecation of eventslib.php 2018-07-30 09:23:54 +08:00
Shamim Rezaie
fda4374a67 MDL-58768 mod_assign: Added userid param to calendar callbacks
The mod_assign_core_calendar_is_event_visible and mod_assign_core_calendar_provide_event_action
functions now accept a new parameter ($userid) so they are not always dependet to the logged in user.
2018-07-28 07:51:33 +10:00
Shamim Rezaie
faa5d173cc MDL-58768 mod_assign: Add $user param to assign::can_grade 2018-07-28 07:51:32 +10:00
Tony Butler
9ed5b0c1f6 MDL-59611 mod_assign: Move help icons for subplugin types out of labels 2018-07-25 12:23:08 +08:00
Mihail Geshoski
10bd37fabd MDL-54742 general: Remove strings deprecated in 3.2 2018-07-23 14:25:14 +08:00
Neill Magill
650779d609 MDL-49025 assign: Submissions of an empty directory should not save
Before this change if only a folder was submitted the submission_is_empty
check would return true. This meant that the draft area would be saved.
The is_empty check would then be called which would return false. This
caused the submission form to indicate to the user that the submission
had failed.

Now is_empty and submission_is_empty should both return false if only
folders are submitted.
2018-07-13 14:03:42 +01:00
Neill Magill
3ebfab9810 MDL-49025 assign: Test than an empty directory will not submit 2018-07-13 14:03:41 +01:00
David Monllao
58b987282e Merge branch 'MDL-42818-master' of git://github.com/zig-moodle/moodle 2018-07-10 11:31:24 +02:00
David Monllao
cbc67cba73 Merge branch 'MDL-62533-master' of git://github.com/zig-moodle/moodle 2018-07-10 07:37:19 +02:00
Jake Dallimore
793fe5fc4c Merge branch 'MDL-62772-master_always_show_disclosure' of https://github.com/jmcgettrick/moodle 2018-07-10 08:59:34 +08:00
David Monllao
381bb72153 Merge branch 'MDL-62831-master' of git://github.com/damyon/moodle 2018-07-09 13:36:05 +02:00
John McGettrick
9481cc0e06 MDL-62772 mod_assign: Show disclosure for all submitters 2018-07-09 09:26:38 +01:00
Damyon Wiese
166fa40a98 MDL-62782 assign: viewgrades allows files
Grade viewer role should be able to see feedback files for an assignment submission.
2018-07-04 14:17:28 +08:00
Damyon Wiese
e655cbb857 MDL-62831 mod_assign: Download as folders help
The help string for the download as folders setting should not mention the number of files
submitted by the student. It is not related to that, it is only dependant on the value of this setting.
2018-07-04 12:20:24 +08:00
Jake Dallimore
bbaab1bae7 Merge branch 'MDL-44081-master' of git://github.com/zig-moodle/moodle 2018-07-04 10:50:25 +08:00
David Monllao
2af5c8e7ef Merge branch 'MDL-60014-master-catcherror-nopermission-annotatepdfcron' of https://github.com/Eva-Dv/moodle 2018-07-03 23:33:01 +02:00
David Monllao
772ae9d4fd Merge branch 'MDL-62691-master' of git://github.com/bmbrands/moodle 2018-07-03 23:33:00 +02:00
Jake Dallimore
25a592ff5f Merge branch 'MDL-62715-master' of git://github.com/andrewnicols/moodle 2018-07-03 08:49:35 +08:00
Helen Foster
9722f6a25e MDL-62763 lang: Merge English strings from the en_fix language pack
Significant string changes:

* various strings in tool_dataprivacy and tool_policy - 'Data Protection
  Officer' changed to 'privacy officer'
* idnumbermod_help,core - mentioning resource and custom reporting
2018-07-02 11:15:26 +02:00
Zig Tan
a8f7818beb MDL-62533 assign: Show assign hidden status on grading summary page 2018-06-29 09:37:57 +08:00
Zig Tan
bc87f6a2e3 MDL-44081 assign: Fix Grader annotation button accessibility ordering 2018-06-29 09:26:58 +08:00
Eva Davitasvili
88c77c8ea3 MDL-60014 assign: Annotate PDF - catch no permission error 2018-06-25 14:11:24 -04:00
Adrian Greeve
11d828ef6f MDL-62755 mod_assign: Update to unit tests.
Overrides are now checked to be exported properly.
2018-06-25 09:49:13 +08:00
Adrian Greeve
ea24047619 MDL-62755 mod_assign: Fix override export problem.
The cutoffdate and allowsubmissionsfromdate were not
being exported.
2018-06-25 09:49:13 +08:00
Andrew Nicols
de06b63344 MDL-62715 mod_assign: Bump submissions back when grading in tests 2018-06-21 08:40:39 +08:00
David Monllao
62dc3fde0a Merge branch 'MDL-61482-master' of git://github.com/zig-moodle/moodle 2018-06-20 13:29:17 +02:00
Zig Tan
8be71d396b MDL-61482 mod_assign: Clean html in offline grading CSV 2018-06-19 23:19:13 +08:00
Bas Brands
c8c595e6d0 MDL-62691 Theme boost: editpdf hide dropdown close btn 2018-06-19 16:57:10 +02:00
Zig Tan
fcb7d2a976 MDL-42818 assign: Add grading UI indicator about followup submission 2018-06-19 14:06:17 +08:00
Damyon Wiese
994d0da35e MDL-60950 assign: Update incompatible unit test
Maintain compatibility with unit test changes after MDL-55609.
2018-06-19 10:56:53 +08:00
Damyon Wiese
c957707106 MDL-60950 assign: Rename class
testable_assign was renamed to mod_assign_testable_assign
2018-06-19 10:53:51 +08:00
Damyon Wiese
07d237840e MDL-60950 assign: Robust filtering of grading table
For assignments with gradetype set to none, we need special handling when generating the query to filter submissions that need grading.
2018-06-19 10:09:42 +08:00
Damyon Wiese
a5ff898f90 MDL-60950 assign: Test for the requires grading filter
This test covers when the requires grading filter is applied, but the
assignment has no grade and the feedbackcomments plugin is disabled.
2018-06-19 10:09:42 +08:00
Damyon Wiese
43c8e1f596 MDL-62643 assign: Skip empty online text files
Online text assignment submissions with no text entered into the editor should not
create a blank html document for providing feedback.
2018-06-15 14:07:08 +08:00
David Monllao
bcb4a27dd6 Merge branch 'MDL-55609-master' of git://github.com/andrewnicols/moodle 2018-06-12 10:07:35 +02:00
Jun Pataleta
43cc39bbc2 Merge branch 'MDL-62225-master' of https://github.com/lucisgit/moodle 2018-06-06 11:16:31 +02:00
Orzu Ionut
403f553623 MDL-61670 assign: show uploaded files timestamp
Amended to fix commit message. Rename variable to lower.
2018-06-06 11:16:22 +02:00
David Monllao
b321d231ff Merge branch 'MDL-42366-master' of https://github.com/lucisgit/moodle 2018-06-04 13:17:07 +02:00
Andrew Nicols
b762445485 MDL-55609 mod_assign: Deprecate base_test 2018-06-01 07:31:50 +08:00
Andrew Nicols
a6b8fc7830 MDL-55609 assignfeedback_comments: Remove shared setUp 2018-06-01 07:30:32 +08:00
Andrew Nicols
a41bf00517 MDL-55609 mod_assign: Move fixture to folder 2018-06-01 07:30:32 +08:00
Andrew Nicols
757d5b7cdc MDL-55609 mod_assign: Remove shared setUp for all tests 2018-06-01 07:30:32 +08:00
Tony Butler
8e64242131 MDL-62225 assignfeedback_editpdf: Add alt text for nav button shortcuts 2018-05-30 15:58:18 +01:00
Tony Butler
166ac972c3 MDL-42366 assignfeedback_editpdf: Improve meaningfulness of cursor image
Various improvements to make the cursor image more accurately reflect
the currently selected editing tool or action:
 * Replace crosshair with default cursor for read-only student view
 * Use currently selected stamp image as cursor when using stamp tool
 * Use text cursor for text higlighter tool and improve its accuracy
 * Use default cursor for select tool (as indicated by its button icon)
2018-05-30 14:50:34 +01:00
Eloy Lafuente (stronk7)
00977e984e MDL-62478 upgrade: add 3.5.0 separation line to all upgrade scripts 2018-05-28 13:15:48 +02:00
Marina Glancy
3960ad53a7 MDL-62430 privacy: validate context when deleting all user data 2018-05-14 18:13:27 +08:00
Eloy Lafuente (stronk7)
4f510bea17 Merge branch 'MDL-62384-master' of git://github.com/andrewnicols/moodle 2018-05-11 18:12:45 +02:00