Commit graph

5120 commits

Author SHA1 Message Date
stronk7
b692e95816 Looking much better now! B-)
More tests tomorrow (IE, mainly)
2006-04-24 00:11:59 +00:00
skodak
69e3c41688 page parameter cleanup 2006-04-23 21:07:44 +00:00
skodak
d2b23346c9 block editing now uses PARAM_BOOL 2006-04-23 20:58:06 +00:00
skodak
5d00b3ad99 page parameter cleanup 2006-04-23 20:33:01 +00:00
stronk7
0e8d48e9d5 Now the resize script supports both resources with and
without navigation menu.
2006-04-23 17:22:45 +00:00
stronk7
57eb7bb905 Styles are now 100% out from here. 2006-04-23 17:00:18 +00:00
gbateson
3da3e957f9 micro-increment version number to 2006042101 (release = v2.1.16) 2006-04-23 11:55:02 +00:00
gbateson
df795ee950 two fixes connected with UTF migration: (i) remove $CFG->prefix from all index names, (ii) force type of "name" field in "hotpot_questions" table to "text" 2006-04-23 11:53:38 +00:00
gbateson
ec161357c9 set $result even when $fromenc=="utf-8", to fix "unassigned variable" errors 2006-04-23 11:51:17 +00:00
stronk7
af6f079c3c Moving some harcoded styles in ims cp to standard 2006-04-23 11:49:33 +00:00
gbateson
5320d678e9 type of "name" field in "hotpot_questions" table should be "text" after migrate 2006-04-23 11:48:58 +00:00
skodak
1182171459 moved php end tag from comment revisited 2006-04-23 11:40:25 +00:00
skodak
6550339d39 moved php end tag from comment 2006-04-23 11:37:57 +00:00
stronk7
3f5e294b97 Now the resize script hasn't anymore harcoded widths. 2006-04-23 09:59:04 +00:00
stronk7
0a1cf79f5f TOC needs _parent because it's rendered in the iframe. 2006-04-23 02:21:00 +00:00
stronk7
dce3a7cb61 Now double-headers are out 100%
Some incorrect targets are out.
Scorm API (dummy) is working fine.

TODO: Move css styles to standard.
2006-04-23 01:57:02 +00:00
stronk7
282bf4a3f3 Moving script to a proper place (for XHTML validation)
(although the page still continues with some errors)
2006-04-22 22:52:34 +00:00
stronk7
13615e23c6 Avoid some warnings... 2006-04-22 22:51:15 +00:00
skodak
9cae379921 fixed typo, undefined $ents 2006-04-22 17:33:22 +00:00
skodak
f393f545d1 typo - fixed undefined $courseid 2006-04-22 17:29:46 +00:00
skodak
117987949a fixed undefined $timenow 2006-04-22 17:28:18 +00:00
skodak
54bb46f55b fixed undefined $course 2006-04-22 17:25:37 +00:00
skodak
d850b4e621 typo in switch 2006-04-22 13:38:24 +00:00
toyomoyo
2712ac665c fix for 5205 2006-04-21 07:55:57 +00:00
moodler
c125d80c3e Fixed Bug #5012 - assignment type uploadsingle does not log view actions 2006-04-21 07:01:01 +00:00
moodler
9e0f5d2abf Added save changes button at top (Bug #1043 - submit button at top of journal report) 2006-04-21 02:23:33 +00:00
gustav_delius
6037288eeb Fixed code that relied on globals hack. Fixed bug 5261 2006-04-20 23:10:45 +00:00
urs_hunkler
0e2b7205f5 removed width for multichoice feedback 2006-04-20 08:37:00 +00:00
moodler
20a730762f No need for noapprovalrequired string 2006-04-20 07:55:07 +00:00
wildgirl
4c85af7b01 Added a check for is_object($item) to prevent possible warnings in preview_ims_generate_toc
Restored use of textlib in preview_ims_generate_toc
2006-04-20 06:53:07 +00:00
wildgirl
676fb87edc Added a check for isset($this->resource->reference) to prevent warnings in resource_ims
Added a check for is_object($item) to prevent warnings in ims_generate_toc
Restored use of textlib in ims_generate_toc
2006-04-20 06:51:55 +00:00
moodler
ec536d7a48 Make sure the number is stored as a proper number 2006-04-20 04:07:50 +00:00
moodler
59f3b71781 New number field type 2006-04-20 04:02:30 +00:00
martinlanghoff
f83edcb114 mod/chat - use empty value instead of erroring out if $USER->lastIP and getremoteaddr() don't yield any interesting value
Sometimes we can't get any useful IP for the user -- and this may even be a
valid situation. So fudge an empty value -- the DB needs it as the IP field
is NOT NULL.
2006-04-19 21:22:36 +00:00
skodak
ef45822122 some extra cleaning of comments and feedback before storage. normaly the text is cleaned before display, this is just a preventive measure because I did not want to study this code all day ;-) 2006-04-19 20:21:42 +00:00
skodak
34ffb5cae2 some extra cleaning of comments and feedback before storage. normaly the text is cleaned before display, this is just a preventive measure because I did not want to study this code all day ;-) 2006-04-19 20:10:04 +00:00
skodak
d2963541e2 Security related parameter cleanup in workshop code, please test it. No bug fixes... 2006-04-19 19:48:46 +00:00
skodak
7282d18cf0 isguest() must be checked AFTER require_login() because the user may not be logged in yet ;-) 2006-04-19 19:42:47 +00:00
moodler
7b54f5636d Fix group picture in HTML mail when no CSS is used 2006-04-19 12:47:30 +00:00
gbateson
30b8cc87e1 fixed bug which prevented display of JCross clues on PHP 5.1.2 2006-04-19 06:20:37 +00:00
vyshane
feb00a54d0 Setting $data->listtemplateheader and $data->listtemplatefooter to '' if we
are resetting the listtemplate.
2006-04-19 04:21:23 +00:00
vyshane
8d4a31bd3c Removed javascript for resetting templates. We reload the page to reset
templates.
2006-04-19 02:54:07 +00:00
mjollnir_
fbc525bc0b Correcting code to remove warning originating from earlier commit
Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-19 02:31:32 +00:00
martinlanghoff
930413b133 mod/chat: Normal method - introducing "Stream" updates.
This is an alternative version of jsupdate.php that acts
as a long-running daemon. It will feed/stall/feed JS updates
to the client. From the module configuration select "Stream"
updates.

The client connection is not forever though. Once we reach
CHAT_MAX_CLIENT_UPDATES (currently 1000), it will force
the client to re-fetch it.

This buys us all the benefits that chatd has, minus the setup,
as we are using apache to do the daemon handling.

Chat still defaults to the normal update method, which is now
optimised to take advantage of keepalives -- so this change is
safe. The instructions in the config page also indicate that this
mode may not be well supported everywhere. It hasn't been
tested on IIS for starters.

In terms of relative cost -- if each hit on jsupdate.php incurs
on ~20 db queries and delivers one update to the client, each hit
on jsupdate takes ~20 queries, and then roughly 2~3 queries to
serve each of the next 1000 updates. On busy sites, the difference
is huge.

There is still room for enhancements in both keepalive and stream
update methods. I am pretty sure we can trim DB queries more.
2006-04-19 02:20:48 +00:00
mjollnir_
eb55a1bfb9 Avoiding warning in last commit:
mod/quiz/index changes to only display quiz grades when teacher allows
Changes to index.php to only allow student to view overall quiz scores when
teacher has not set options forbidding this, and it can't give away what
scores were for attempts where results should still be hidden.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:57:28 +00:00
mjollnir_
40377b188b mod/quiz/index changes to only display quiz grades when teacher allows
Changes to index.php to only allow student to view overall quiz scores when
teacher has not set options forbidding this, and it can't give away what
scores were for attempts where results should still be hidden.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:55:28 +00:00
mjollnir_
d78a1cf6d8 mod/quiz/locallib bugfix get_qn_options now uses more sensible defaults.
Previously get_question_options used options for
after-attempt-while-quiz-open, when called while a attempt was still in
progress.  Changed it to use options for immediately-after-attempt instead.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:54:51 +00:00
mjollnir_
309c0d55b2 mod/quiz/view changes to only display attempt grades when teacher allows.
Changed view.php to only display grades when the teacher has not set
options forbidding it.  Further, where there is some attempts that are
allowed to be displayed, and others not, highligting of the highest score,
and printing of the overall grade allocation has been disabled to ensure
the hidden grade is not revealed.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:54:10 +00:00
mjollnir_
15db443c87 mod/quiz/review only display grade summary if student allowed to see scores
Change to review.php so that the student will only see the grade summary
if they are allowed to view their scores - as determined by quiz options
set by the teacher.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:50:04 +00:00
mjollnir_
9f7f01db04 mod/quiz/review quiz options loaded once per pageload, not once per qn.
Moved loading of quiz review options from loop iterating over each qn to be
displayed, to the top of the pageload.  Should give efficency gains
on quizes with long pages, as well as making the options available
earlier in the process.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:47:56 +00:00