Commit graph

172 commits

Author SHA1 Message Date
Tim Hunt
3fa5724a1f javascript MDL-26098 manual grading was not working when quiz_attempts.id and question_attempts.id were out of synch. 2011-01-29 14:03:02 +00:00
Tim Hunt
3708abd0f2 javascript MDL-26098 make the review this question in a previous state popup work. 2011-01-29 13:59:51 +00:00
Tim Hunt
94dbfb3a82 quiz editing MDL-24750 The Add random button should also let you add questions from an existing category.
Also includes a fix for MDL-24749 by Sam Hemelryk. Thanks Sam.

This commit also includes a certain amount of code cleaning up.
2010-11-22 09:52:42 +00:00
Pierre Pichet
710903a6b3 MDL-25104 correcting import_or_save_files() function 2010-11-12 20:30:09 +00:00
Tim Hunt
69988ed452 questions MDL-25104 and MDL-25088 fix question editing and import
Editing of some qtypes was broken since a previous commit by me earlier in the week.

Import of XML and GIFT should now work, but could use some more testing.
2010-11-12 17:11:34 +00:00
Tim Hunt
9203b70576 question deletion MDL-25173 when a question is deleted, all the associated files must be deleted. 2010-11-12 11:29:53 +00:00
Tim Hunt
cf991c1d85 question editing MDL-25151 Notices when editing random questions. 2010-11-12 10:23:29 +00:00
Tim Hunt
5d548d3e0a question bank MDL-24995 clean up a lot of deprecated code to do with moving questions around.
This should also fix MDL-25172, MDL-23021 and MDL-23073. In other words, moving questions between categories should now work.
2010-11-11 21:54:22 +00:00
Tim Hunt
a9efae50e3 question upgrade MDL-16094 fix up earlier mistakes in the text format upgrade.
There was a mistake in the text format upgrade in the question bank. The wrong conversions were performed, and the wrong arguments were passed to text_to_html in the conversions that were done.

Also, not all the calls to format_text had been updated to use the values in the new format columns.

I think this change fixes everything, but I have only had very limited time to test it. I am committing it anyway, because that seems to me to be the best way to maximise testing. I think that the new code is certainly better than the old code was.
2010-11-11 17:32:25 +00:00
Dongsheng Cai
cde2709a88 MDL-15573, question export rewrite 2010-11-05 06:34:00 +00:00
Eloy Lafuente
41941110fd MDL-22138 backup - I know smaller cathedrals than this, yay quizzes! 2010-10-24 10:43:42 +00:00
Tim Hunt
fb6dcdab11 quiz & qbank MDL-24453 fix all the ways you can edit a question, so that that returnurl paramterer acutally works.
I hope. Please test thoroughly.
2010-10-18 15:28:59 +00:00
Petr Skoda
7f38934243 MDL-24321 switching to stdClass in /question/ - I am sure Tim will be very happy 2010-09-21 08:20:46 +00:00
Eloy Lafuente
7660715f65 MDL-22164 backup - finished cleaning of questions backup code 2010-09-21 00:23:26 +00:00
Tim Hunt
2d01a9168f question import/export MDL-23198 extra_question_fields not handling special characters properly.
Thanks to Oleg Sychev for the fix.
2010-08-11 19:05:47 +00:00
Dongsheng Cai
fe6ce23489 MDL-16094 File storage conversion Quiz and Questions 2010-08-10 09:56:48 +00:00
Tim Hunt
ff065f96bc mod quiz + questions MDL-22370 convert JavaScript to YUI3 and modules.
Note, quiz editing JS has not been done yet.
2010-08-04 15:22:04 +00:00
Tim Hunt
b97d264489 qtype base: NOBUG improve comments and private function name. 2010-07-05 16:53:50 +00:00
Tim Hunt
4ba32cf15d question base type: Fix typo. 2010-04-06 11:49:50 +00:00
David Mudrak
16be897441 MDL-21652 html_table rendering refactored
* class html_component does not exist any more
* class html_table rendered via html_writer::table()
* html_table, html_table_row and html_table_cell have public $attributes property to set their CSS classes
* dropped rotateheaders feature, should be added again after more research of possible ways (<svg> is not nice IMHO)
* dropped possibility to define CSS classes for table heading, body and footer - can be easily done and better done using just table class and context
2010-03-20 22:15:54 +00:00
Tim Hunt
e65701ee2d nobug: whitespace fixes. 2010-02-23 14:31:07 +00:00
Petr Skoda
9bf163146b MDL-20204 more html_link converstions 2010-02-11 18:50:55 +00:00
Petr Skoda
9dec75dbcc MDL-21240 shortened urls now start with / everywhere 2010-01-18 20:57:32 +00:00
Petr Skoda
4bcc51185c MDL-21217, MDL-21198 simplified/improved outputlib help icon related apis + several fixed regresions 2009-12-30 15:19:55 +00:00
Petr Skoda
2f67a9b3a5 MDL-20700 whitespace terror returns yet again 2009-12-16 22:22:37 +00:00
Petr Skoda
b5d0cafc6f MDL-20787 final switch to new $OUTPUT->pix_url() - yay! 2009-12-16 21:50:45 +00:00
Petr Skoda
78946b9bdb MDL-20204 first batch of major theme changes, some regressions are still there, expect more changes and improvements soon; see tracker for details and list of subtasks 2009-12-16 18:00:58 +00:00
Sam Hemelryk
a5d96f9307 question MDL-20910 Fixed buggy conversion of link_to_popup_window 2009-12-07 02:43:35 +00:00
Tim Hunt
e14de5aa1c random question history MDL-20951: Two minor bugs in the fix for MDL-20776.
Thanks to Oleg Sychev for noticing these problems.
2009-11-24 11:49:21 +00:00
Tim Hunt
6224d7a10d question editing from quiz: MDL-20709 better return URL. 2009-11-19 19:09:04 +00:00
Tim Hunt
5c86dc7c72 question history: MDL-20776 state history was not shown for random questions
I took the opportunity to clean up the code that generates the history.
Thanks to Gbor Katona for helping to find the problem.
2009-11-19 19:03:55 +00:00
Tim Hunt
5ffd1421a5 manual grading: MDL-20581 Fix potential XSS problem.
Thanks to Penny for spotting this.
Merged from MOODLE_19_STABLE.
2009-11-19 17:31:41 +00:00
Petr Skoda
aeb15530b8 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:52 +00:00
tjhunt
88bc20c30f question types: MDL-20157 export_to_xml and import_from_xml functions for question types using extra_question_fields.
Thanks to Oleg Sychev for the implementation.
2009-09-30 13:38:36 +00:00
samhemelryk
1d58b567be question MDL-19820 Replaced deprecated functions 2009-09-25 04:16:27 +00:00
nicolasconnault
80e7bb44cf MDL-19820 Upgraded calls to link_to_popup_window() 2009-08-20 13:17:43 +00:00
nicolasconnault
a941387a02 MDL-19820 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:49:11 +00:00
nicolasconnault
fef8f84e4b MDL-19822 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:19:00 +00:00
nicolasconnault
beb677cda6 MDL-19820 Converted print_box* to $OUTPUT->box* 2009-08-10 05:01:23 +00:00
nicolasconnault
9b59580b36 MDL-19820 Converted all print_footer() calls 2009-08-06 14:19:16 +00:00
nicolasconnault
04a7ba52e9 MDL-19756 Removed explicit aligning CSS class from $OUTPUT->heading() calls 2009-08-06 08:55:02 +00:00
nicolasconnault
723d610c91 MDL-19820 Migrated calls to print_heading 2009-08-06 08:26:06 +00:00
tjhunt
ddedf979b4 MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-03 06:19:25 +00:00
tjhunt
f2a1963c43 MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-02 11:09:15 +00:00
tjhunt
25ddb7efc9 javascript: MDL-19475 replace require_js calls with $PAGE->requires->js.
This is the final batch.
2009-06-15 07:57:53 +00:00
skodak
fc29e51b2d MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 18:34:43 +00:00
skodak
bb4b6010f3 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:17:10 +00:00
tjhunt
cf6155226c ajaxlib/require_js: MDL-16693 $PAGE->requires->... deprecates require_js etc.
There is a new implementation of require_js in lib/deprecatedlib.php,
based on $PAGE->requires.

There were a few other recently introduced functions in lib/weblib.php,
namely print_js_call, print_delayed_js_call, print_js_config and
standard_js_config. These have been removed, since they were never in
a stable branch, and all the places that used them have been changed
to use the newer $PAGE->requires->... methods.

get_require_js_code is also gone, and the evil places that were calling
it, even though it is an internal function, have been fixed.

Also, I made some minor improvements to the code I committed yesterday
for MDL-16695.

All that remains is to update all the places in core code that are
still using require_js.

(This commit also fixes the problem where the admin tree would not
start with the right categories expanded.)
2009-06-12 12:13:07 +00:00
tjhunt
50da63ebd9 qtypes: MDL-18711 Allow qtype plugins to have custom CSS and JavaScript on the editing page. 2009-03-30 09:15:46 +00:00
tjhunt
5995f17f72 qtypes: MDL-18559 questions showing penalty information when they shouldn't.
We had a !== when it should have been !=, and our constants were defined as strings not ints. This problem has been there since forever, but no one had noticed before. Thanks to Alan Trick for finally spotting it!
2009-03-16 01:52:47 +00:00