Commit graph

101098 commits

Author SHA1 Message Date
Marina Glancy
4d2c96861d MDL-71397 mod_glossary: empty category is the same as all categories
In PHP8 empty string is not equal to zero
2021-04-23 11:46:01 +02:00
Sara Arjona
146a38dc45 weekly release 4.0dev 2021-04-23 10:46:53 +02:00
Sara Arjona
a080f64c01 NOBUG: Fixed SVG browser compatibility 2021-04-23 10:46:51 +02:00
Mathew May
54b57cb7dc MDL-71329 tool_moodlenet: Check to see if we get errors before curl 2021-04-23 15:43:58 +08:00
Jun Pataleta
24a5f53086 Merge branch 'MDL-71171_master' of git://github.com/mdjnelson/moodle 2021-04-23 12:41:15 +08:00
Mark Nelson
5eb3d47403 MDL-71171 customfield_text: ensure we set defaults properly 2021-04-23 12:31:53 +08:00
abgreeve
ea362206a3 Merge branch 'MDL-70818-master-4' of git://github.com/rezaies/moodle 2021-04-23 12:19:51 +08:00
Andrew Nicols
db49294748 Merge branch 'MDL-70903-master' of git://github.com/roland04/moodle 2021-04-23 11:56:47 +08:00
Andrew Nicols
1a34066129 Merge branch 'master-MDL-71376' of https://github.com/rjnl/moodle 2021-04-23 11:52:21 +08:00
Shamim Rezaie
ac2b200a6e MDL-70818 mod_workshop: implement activity_dates for the workshop module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
0b64b10eb9 MDL-70818 mod_workshop: cache workshop times in modinfo for performance 2021-04-23 13:46:28 +10:00
Shamim Rezaie
2ad16d8d9e MDL-70818 mod_scorm: implement activity_dates for the scorm module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
31288bd1a6 MDL-70818 mod_forum: implement activity_dates for the forum module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
b284e9e705 MDL-70818 mod_forum: cache forum times in modinfo for performance 2021-04-23 13:46:28 +10:00
Shamim Rezaie
b3b7c3f95a MDL-70818 mod_feedback: implement activity_dates for the feedback module 2021-04-23 13:46:28 +10:00
Shamim Rezaie
6b243c62e6 MDL-70818 mod_data: implement activity_dates for the database module 2021-04-23 13:46:28 +10:00
Andrew Nicols
8b7a5809b3 Merge branch 'MDL-71394-master' of git://github.com/marinaglancy/moodle 2021-04-23 11:42:00 +08:00
Andrew Nicols
b124832fe6 Merge branch 'MDL-70970' of git://github.com/paulholden/moodle 2021-04-23 11:26:53 +08:00
Andrew Nicols
33173e7223 Merge branch 'MDL-70902-master' of git://github.com/dravek/moodle 2021-04-23 11:12:15 +08:00
ScottVerbeek
8bd9dca9a8 MDL-66673 groups: Stop notice when messaging system is disabled 2021-04-23 08:52:48 +10:00
Sara Arjona
80b1bb4751 Merge branch 'MDL-57831' of git://github.com/paulholden/moodle 2021-04-22 18:13:04 +02:00
Paul Holden
f9f679611d MDL-57831 tool_monitor: update Behat tests for message preferences. 2021-04-22 16:11:30 +01:00
Ferran Recio
201a37e6aa MDL-70909 behat: context freeze and not freeze steps 2021-04-22 15:50:55 +02:00
Sara Arjona
841df2a216 Merge branch 'MDL-71136_master' of https://github.com/TomoTsuyuki/moodle 2021-04-22 13:56:37 +02:00
Ferran Recio
45048b8796 MDL-70909 core: add cannotmatchanyrows to capabilities join 2021-04-22 13:16:35 +02:00
Sara Arjona
c9c18da021 Merge branch 'MDL-71400-master' of git://github.com/mihailges/moodle 2021-04-22 13:16:23 +02:00
Shamim Rezaie
0ca7548443 MDL-71144 mod_scorm: Deprecate scorm_get_completion_state() 2021-04-22 21:11:43 +10:00
Shamim Rezaie
7d102bb67d MDL-71144 mod_quiz: custom_completion should not use deprecated function
This commit also removes an unnecessary DB query.
2021-04-22 21:11:43 +10:00
Shamim Rezaie
d9d0ae01d3 MDL-71144 mod_quiz: Deprecate quiz_get_completion_state() 2021-04-22 21:02:02 +10:00
Jun Pataleta
c070f3e66d Merge branch 'MDL-71170_master' of git://github.com/mdjnelson/moodle 2021-04-22 18:55:28 +08:00
Noel De Martin
168f28fa75 MDL-71386 behat: Support for 3.9.5+ mobile app 2021-04-22 12:14:18 +02:00
Paul Holden
4264f85063 MDL-71200 mod_folder: ensure "Download folder" option is backed up. 2021-04-22 10:29:25 +01:00
Paul Holden
250944bc1e MDL-70979 search: validate external user search parameters.
Clean return value in unit test for same.
2021-04-22 10:22:35 +01:00
Paul Holden
0de5ab4b43 MDL-71392 mod_quiz: don't display grade to pass if not set. 2021-04-22 09:53:24 +01:00
Mihail Geshoski
4e714cebae MDL-71400 assignfeedback_offline: Fix message after worksheet upload 2021-04-22 13:08:15 +08:00
Jun Pataleta
e853e6b7db Merge branch 'MDL-71156-master' of git://github.com/lameze/moodle 2021-04-22 11:51:59 +08:00
Andrew Nicols
81d5ed8184 Merge branch 'MDL-69460' of https://github.com/paulholden/moodle 2021-04-22 11:11:40 +08:00
Jun Pataleta
7af3fa1cdd Merge branch 'MDL-71288-master' of git://github.com/lameze/moodle 2021-04-22 10:29:25 +08:00
Simey Lameze
5b0282847e MDL-71156 core: machinery to recover orphaned calendar events
The machinery to fix orphaned calendar events that were broken by MDL-67494.

The solution consists of:

1) Upgrade step that checks if this site has executed the problematic upgrade steps and
   if positive, it will schedule a new run for calendar_fix_orphaned_events adhoc task.

2) Adhoc task that will self-spawn calling the recovery machinery, running until
   all the orphaned calendar events are fixed. It also sets the maximum runtime of
   60 seconds. It is also possible to override that number by specifing the desired
   number setting the ->calendareventsmaxseconds in your config.php

3) CLI script that will look for all the calendar events which userids
   where broken by a wrong upgrade step, affecting to Moodle 3.9.5
   and up.

   It performs checks to both:
     a) Detect if the site was affected (ran the wrong upgrade step).
     b) Look for orphaned calendar events, categorising them as:
       - standard: site / category / course / group / user events
       - subscription: events created via subscriptions.
       - action: normal action events, created to show common important dates.
       - override: user and group override events, particular, that some activities support.
       - custom: other events, not being any of the above, common or particular.

   By specifying it (--fix) try to recover as many broken events (missing userid) as
   possible. Standard, subscription, action, override events in core are fully supported but
   override or custom events should be fixed by each plugin as far as there isn't any standard
   API (plugin-wise) to launch a rebuild of the calendar events.

4) Unit tests and helper functions to generate calendar events. We have decided to
   keep the tests simple, testing only true and false and not using data generators because
   the code is purely to recover the calendar events and won't turn into an API or something
   and also due to the urgency of this issue.
   The helpers have been created in calendar/tests/helpers.php since there are no data generators
   for calendar.
2021-04-22 10:28:52 +08:00
Andrew Nicols
5104159fcc Merge branch 'MDL-70412-master' of git://github.com/aanabit/moodle 2021-04-22 10:10:38 +08:00
Simey Lameze
f518f61757 MDL-71288 completion: add fallback for plugins
This commits adds a fallback for plugins which does not have
custom_completion implementation.

For those cases, it will search for {modulename}_get_completion_state
callback in the plugin and call get_overall_completion() method in
cm_completion_details class to get the overall completion state for
a course module and user.
2021-04-22 09:45:11 +08:00
abgreeve
8a53fe7f6b Merge branch 'MDL-28452-master' of git://github.com/bmbrands/moodle 2021-04-22 09:38:50 +08:00
Shamim Rezaie
a2bf666a0c MDL-71144 mod_lesson: Deprecate lesson_get_completion_state() 2021-04-22 10:08:11 +10:00
Shamim Rezaie
b4c8f0f8a6 MDL-71144 mod_survey: Deprecate survey_get_completion_state() 2021-04-22 10:08:11 +10:00
Shamim Rezaie
5f9aa4d35f MDL-71144 mod_glossary: Deprecate glossary_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
c9fa4f9cd7 MDL-71144 mod_forum: Deprecate forum_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
c10dfd7583 MDL-71144 mod_feedback: Deprecate feedback_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
08fb6a71b7 MDL-71144 mod_data: Deprecate data_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
17c3c4dc75 MDL-71144 mod_choice: Deprecate choice_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
d484b3e371 MDL-71144 mod_assign: Deprecate assign_get_completion_state() 2021-04-22 10:08:04 +10:00