Commit graph

53 commits

Author SHA1 Message Date
Andrew Nicols
6212b71318 MDL-74291 mod_bigbluebuttonbn: Allow students to join moderated meetings 2022-03-22 16:09:45 +08:00
Eloy Lafuente (stronk7)
984669aeb2 Merge branch 'MDL-73193' of https://github.com/call-learning/moodle 2022-03-15 23:07:47 +01:00
Laurent David
1587ab4c27 MDL-73193 mod_bigbluebuttonbn: Fix random failures in behat tests
* On selenium chrome this fixes random failure of the "I can delete a recording"
test due to race condition between the popup being closed and the script waiting
for it to be displayed
2022-03-15 19:22:46 +01:00
Paul Holden
61e5f6da55 MDL-74194 mod_bigbluebuttonbn: access checks for inplace editables. 2022-03-15 09:57:55 +06:00
Andrew Nicols
68c0b45ca3 MDL-73308 mod_bigbluebuttonbn: Ensure breakout data is in metadata 2022-03-01 12:03:01 +08:00
Víctor Déniz
af0e3bcadc Merge branch 'MDL-73855' of https://github.com/ssj365/moodle 2022-03-01 01:56:11 +00:00
Andrew Nicols
05ef98134e Merge branch 'MDL-73308' of https://github.com/call-learning/moodle 2022-02-28 14:06:38 +08:00
Laurent David
5c719062d4 MDL-73962 mod_bigbluebuttonbn: Fix issue with buttons on recording table
* The button labels were not correctly matched with language strings resulting
 in empty buttons
2022-02-26 08:53:57 +01:00
Shamiso Jaravaza
2aa61b3a06 MDL-73855 mod_bigbluebuttonbn: Recording Icon settings removed 2022-02-24 18:07:05 -03:30
Andrew Nicols
e1b9d5f3cd MDL-73915 js: Drop support for IE and android
Moodle announced that support for IE would be dropped back in August
2020 with Moodle 3.9 but not active steps were taken at that time. That
decision was made in MDLSITE-6109 and this particular step was meant to
be taken in Moodle 3.10.

This is the first step taken to actively drop support for IE.

This commit also bumps the browser support pattern from 0.25% to 0.3%.
The percentage here includes any browser where at least this percentage
of users worldwide may be using a browser. In this case it causes
support for Android 4.3-4.4 to be dropped, which relate to Android
KitKat (released 2013).

This combination of changes means that all of the supported browsers in
our compatibility list support modern features including async,
for...of, classes, native Promises, and more which has a huge impact on
the ease of debugging code, and drastically reduces the minified file
size because a number of native Polyfills included by Babel are no
longer included.
2022-02-23 08:55:20 +08:00
Andrew Nicols
0a4047ab31 MDL-73915 js: Switch amd minification to terser
Unfortunately the babel minify-mangle plugin seems to be abandoned and
in certain circumstances can be very buggy. The only safe options are to
disable it, or to switch to a different minification library.

Not minifying our javascript is not ideal, so this commit updates the
javascript tasks to use a rollup, combined with babel, and terser.

Babel still converts code from ES/UMD/AMD to AMD modules with the
relevant browser support, whilst terser minifies the code.

The rollup bundler handles tracking and creation of sourcemaps, and
supports better parallelisation of the tasks.

Since the upgrade to Node LTS/Gallium requires an upgrade to @babel/core
and eslint, which change the built files anyway, this seems like the
ideal time to make this change.
2022-02-23 08:55:09 +08:00
Andrew Nicols
aa7f7957ea MDL-73915 js: Upgrade babel and eslint 2022-02-23 08:53:54 +08:00
Víctor Déniz
774a0a06b6 Merge branch 'MDL-73192' of https://github.com/call-learning/moodle 2022-02-21 23:53:11 +00:00
jfederico
8c9f20e645 MDL-73192 mod_bigbluebuttonbn: Lock settings not working
* The lock settings from the instance were not sent to the BBB API
* The global settings related to lock settings did not show
* lockSettingLockOnJoinConfigurable is not working so removed for now
* Fixed lockSettingsLockOnJoin setting
2022-02-21 15:00:46 +01:00
Víctor Déniz
efdd77a157 MDL-73812 lang: Replace modified strings in tests 2022-02-18 16:14:02 +00:00
Helen Foster
7ff6b2daef MDL-73812 lang: Import fixed English strings (en_fix) 2022-02-18 15:50:26 +00:00
Sara Arjona
fb19d1cc1f NOBUG: Fixed SVG browser compatibility 2022-02-18 15:03:54 +01:00
Víctor Déniz
649fb3cc49 Merge branch 'MDL-73724' of https://github.com/call-learning/moodle 2022-02-17 22:33:21 +00:00
Laurent David
628ee05f98 MDL-73308 mod_bigbluebuttonn: Breakout room
* Fetch recording attached to breakout meetings
* Add tests for breakoutrooms
2022-02-17 18:23:56 +01:00
Laurent David
c25c134728 MDL-73724 mod_bigbluebuttonbn: Error when joining meeting
* When pre-uploaded presentation is uploaded, the meeting refuses to start and
and error is thrown.
2022-02-17 17:26:38 +01:00
Sara Arjona
af7a0ed1a1 Merge branch 'MDL-73313_master' of https://github.com/tasosb/moodle 2022-02-17 08:38:08 +01:00
Anastasios Bithas
c3f4123b38 MDL-73313 mod_bigbluebutton: Option to disable default welcome message
General configuration BBB default messages now work properly.
The option to disable BBB default messages for a course is now available.
2022-02-16 18:52:51 +02:00
Víctor Déniz
a0aeaca013 Merge branch 'MDL-73368' of https://github.com/call-learning/moodle 2022-02-15 15:38:45 +00:00
Ilya Tregubov
256804d2ed Merge branch 'MDL-73532-master-1' of https://github.com/mihailges/moodle 2022-02-15 13:37:24 +02:00
Laurent David
749b416473 MDL-73312 mod_bigbluebuttonbn: Fix sort by date for recordings
* Fix sorting for dates in recording table
* Code review and getString usage in JS
2022-02-15 08:07:51 +01:00
Mihail Geshoski
4a9c83ac9e MDL-73532 navigation: Modify methods that extend the setting nav
Introduces some changes to the exising _extend_settings_navigation()
methods that utilize the global $PAGE object. In order to accomodate
the changes done for the secondary navigation for single activity
courses, the methods that extend the settings navigation can no longer
rely on the $PAGE object, instead the more reliabe way to obtain this
infomation is through the get_page() method from settings_navigation
class.
2022-02-14 09:40:27 +08:00
Víctor Déniz
1a42a95e8d Merge branch 'MDL-73279' of https://github.com/call-learning/moodle 2022-02-07 18:13:20 +00:00
Laurent David
e1d255c95b MDL-73368 mod_bigbluebuttonbn: update activity icon
* Add the new icon (svg and png)
* Remove unused icon and font (the glyph was used once in the removed style)
2022-02-04 10:44:19 +01:00
Amaia Anabitarte
4c7fac1957 MDL-71712 lib: Set Moodle files after PHP-JWT upgrade 2022-02-01 16:25:35 +01:00
Laurent David
4d726630b1 MDL-73279 mod_bigbluebuttonbn: Remove notify change option in settings
* As 'Send content change notification' is standard in all activities in Moodle 4.0
 we should be removing 'Notify this change to users enrolled'
* Fix and adjust tests
2022-02-01 15:39:31 +01:00
Laurent David
9877868c6f MDL-73254 mod_bigbluebuttonbn: Fix hide recording functionality
* The hide recording is working in combination with several settings and should
allow the Record button to be hidden either globally on in a given activity
2022-01-24 08:33:45 +01:00
Andrew Nicols
68a711ba9b Merge branch 'MDL-73218' of https://github.com/call-learning/moodle 2022-01-18 11:15:25 +08:00
Laurent David
64d9f988f4 MDL-73206 mod_bigbluebuttonbn: Fix issue with participant roles
* Participant roles could not be updated to moderator and always defaults to viewer
* Remove additional DB query in form to retrieve the current module information
2022-01-17 11:48:31 +01:00
Laurent David
3d197d7493 MDL-73218 mod_bigbluebuttonbn: Remove phased out settings
* Remove deprecated settings :
  - bigbluebuttonbn_recordings_validate_url,
  - bigbluebuttonbn_recordings_html_default,
  - bigbluebuttonbn_recordings_html_editable
2022-01-17 09:17:15 +01:00
Andrew Nicols
bbf9b5561b Merge branch 'MDL-73511' of https://github.com/call-learning/moodle 2022-01-12 11:38:45 +08:00
Laurent David
c7b706186c MDL-73511 mod_bigbluebuttonbn: exception raised when editing activity
* When editing an activity and the voicebridge_editable is set, there is an exception raised
2022-01-06 20:13:41 +01:00
Ilya Tregubov
9e95cb81b4 MDL-73306 mod_bigbluebuttonbn: Fix unit tests. 2022-01-06 12:20:16 +02:00
Laurent David
09ba0cb9a8 MDL-73306 mod_bigbluebuttonbn: "Recently Activity" block display
* The callback 'xxx_print_recent_activity' needed to be created in order to display
the activities in the block
* Use the print_recent_activity_note api function
2022-01-03 15:04:21 +01:00
jfederico
88ee5b8552
MDL-73200 mdl_bigbluebuttonbn: change default server_url on upgrade 2021-12-21 20:26:07 +00:00
jfederico
3007e0e40b
MDL-73200 mod_bigbluebuttonbn: Fix Behat issue with shared secret 2021-12-20 14:58:39 +00:00
jfederico
cea29ffebc
MDL-73200 mod_bigbluebuttonbn: Replaced credentials provided by default 2021-12-20 14:51:44 +00:00
Víctor Déniz
c8abe79865 Merge branch 'MDL-73199' of git://github.com/jfederico/moodle 2021-12-16 16:57:40 +00:00
jfederico
36caeca30a
MDL-73199 bigbluebutton: fix protect recording action not being disabled 2021-12-16 16:24:33 +00:00
Víctor Déniz
91ad6d08d9 Merge branch 'MDL-73198' of https://github.com/jfederico/moodle 2021-12-15 13:23:05 +00:00
Sara Arjona
78f2461d45 Merge branch 'MDL-73196' of https://github.com/jfederico/moodle 2021-12-13 12:58:30 +01:00
jfederico
fbbf30dd04
MDL-73198 mod_bigbluebuttonbn: restored synchrony of recordings 2021-12-10 03:13:28 +00:00
Laurent David
8c1568d047 MDL-73220 mod_bigbluebuttonbn: "Recently accessed items" block display
* The BBB activity did not send the right event trigger when activity was viewed hence
the block_recentlyaccesseditems did not pick up information from any BBB activity
2021-12-07 21:03:08 +01:00
jfederico
bef53cf1b8
MDL-73196 mod_bigbluebuttonbn: Fix blocked participant selection 2021-12-07 16:45:03 +00:00
Sara Arjona
5ae7fa42b7 NOBUG: Fixed SVG browser compatibility 2021-11-26 15:26:18 +01:00
Eloy Lafuente (stronk7)
103a4b5c92 MDL-70658 phpunit: never apply for time() in data providers
Data providers are executed at the beginning of the execution
of the phpunit run, not when the test is run.

So, setting anything on them being dependent of current time
has high chances or fail when the test is executed (maybe some
hours later in slow databases / systems).

Data provider only can contain the relative values and then,
when the test is effectively run, they are applied to *current* time.
2021-11-25 18:13:51 +01:00