Eloy Lafuente (stronk7)
85f47bae7f
MDL-65204 phpunit: various fixes to assertions
...
Namely:
- 3rd param of assertEquals() cannot be null.
- Some incorrect uses of assertNotEmpty().
- Comparing 2 strings now uses strict (===) evaluation.
Link: https://github.com/sebastianbergmann/phpunit/issues/3185
Solution here is one of:
a) Return to the previous situation, making the comparison
softer. That can achieved by forcing different types, so
float == string works.
b) Changing APIs (both forms and database return strings) to
perform some conversion to floats. That would make float
comparison (with floats or strings) to work too.
The patch here follows the a) approach. Changing all the internals
for proper float handling sounds excesive when it has been working
perfectly since ever. So we went the easier route, just getting
rid of the new === comparisons when needed by changing expectation
types to float.
2019-04-03 10:39:19 +08:00
Tim Hunt
be492e2a8f
MDL-65245 question engine: response vars should always be PHP strings
2019-04-02 16:32:40 +01:00
Tim Hunt
6c91e515b0
MDL-65245 question_attempt: fix PHPdoc and other PHPstorm warnings
2019-04-02 16:32:36 +01:00
Simey Lameze
d499cb3593
MDL-65050 core: delete orphaned files and functions
2019-04-01 12:57:05 +08:00
Simey Lameze
9c164d26fc
MDL-65050 core: add question_stats_cleanup_task scheduled task
...
This commit also removes orphaned question/engine/statisticslib.php
2019-04-01 12:57:05 +08:00
Simey Lameze
10810f421b
MDL-65050 core: move function code to question_preview_cleanup_task
...
This commit also deletes the legacy question_preview_cron() function.
2019-04-01 12:57:05 +08:00
Simey Lameze
9bec0e7e74
MDL-65207 core: replace typos by actually
2019-04-01 08:49:18 +08:00
Tim Hunt
05ea7ab19e
MDL-65222 questions: explain question walkthrough tests
2019-03-29 14:49:39 +00:00
Tim Hunt
f1ffd134d3
MDL-65029 questions: change question div id to acutally be unique
...
This is largely based on Simey Lameze's work.
2019-03-29 13:37:44 +00:00
Simey Lameze
2cfd8d1678
MDL-62992 question: conditionaly enable question tags feature
2019-03-27 10:16:05 +08:00
Adrian Greeve
d08e28a3bb
Merge branch 'MDL-21904' of git://github.com/jmvedrine/moodle
2019-03-20 14:14:02 +08:00
Jean-Michel Vedrine
5dd1cf33ab
MDL-21904 qformat_aiken: add export feature.
2019-03-19 08:01:56 +01:00
Adrian Greeve
ebdd345054
Merge branch 'MDL-63905' of git://github.com/jmvedrine/moodle
2019-03-07 09:10:30 +08:00
Jean-Michel Vedrine
48aad79a63
MDL-63905 qtype_multianswer: validate imported questions
2019-03-06 08:35:04 +01:00
Eloy Lafuente (stronk7)
8ab1bd2f5e
Merge branch 'MDL-64943-master-enfix' of git://github.com/mudrd8mz/moodle
2019-03-05 11:08:32 +01:00
Martin Gauk
3e24d6f663
MDL-64941 qtype_multianswer: keep order of existing wrapped questions
2019-03-01 09:46:40 +00:00
Helen Foster
38dc5b9677
MDL-64943 lang: Import fixed English strings (en_fix)
...
Significant string changes:
* importgroups_help,core_group - Correcting optional fieldnames
(removing picture, hidepicture and adding groupidnumber, groupingname
and enablemessaging)
* penaltyforeachincorrecttry_help,core_question - additional paragraph
about scoring logic
* resultdownloadready,tool_dataprivacy - wording corrected (no need to
go to a download page)
* auth_dbfielduser,auth_db - varchar data type requirement
2019-02-28 09:50:18 +01:00
Sara Arjona
7afeb1b1d2
Merge branch 'MDL-62454-master' of git://github.com/bmbrands/moodle
2019-02-27 08:57:51 +01:00
Mathew May
2627162480
MDL-58428 renderer: Move renderer override from Question bank
2019-02-26 16:24:49 +08:00
Bas Brands
5fe9aca3a1
MDL-62454 theme_boost: numerical qtype answer inline
2019-02-21 14:19:42 +01:00
Eloy Lafuente (stronk7)
cb8fc12489
Merge branch 'MDL-64749' of https://github.com/mkassaei/moodle
2019-02-20 17:01:56 +01:00
M Kassaei
3e697596b4
MDL-64749 Question gapselect: Replace 'Choose...' with blank
2019-02-20 11:06:51 +00:00
Eloy Lafuente (stronk7)
84dd2193c1
Merge branch 'MDL-64242' of git://github.com/timhunt/moodle
2019-02-19 23:22:52 +01:00
VinhLe
d02247448b
MDL-63944 Question: Add toggle all to Quiz Activity
2019-02-15 14:42:07 +07:00
Andrew Nicols
270fd3f5e4
MDL-63944 Question: Convert toggle all to generic module
2019-02-15 10:07:08 +07:00
VinhLe
b65bc972e6
MDL-63944 Questions Bank: Select all checkbox should be checked
...
When checkbox item be chosen then "Select All" be chosen.
When "Select All" be chosen then all checkbox item be chosen.
2019-02-15 10:07:08 +07:00
Eloy Lafuente (stronk7)
752e2f85e7
Merge branch 'MDL-64420-2' of https://github.com/timhunt/moodle
2019-02-12 12:56:18 +01:00
David Monllaó
6f5d32ea4d
Merge branch 'MDL-64590' of https://github.com/timhunt/moodle
2019-02-12 12:45:48 +01:00
David Monllaó
f4a99aa5eb
Merge branch 'MDL-64646' of https://github.com/mkassaei/moodle
2019-02-12 12:42:48 +01:00
John Beedell
0d3be6d648
MDL-64420 qtype: gapselect unit tests unsafe
2019-02-11 13:53:24 +00:00
Andrew Nicols
232906959a
Merge branch 'MDL-64393' of https://github.com/timhunt/moodle
2019-02-11 15:11:20 +08:00
Tim Hunt
822b4abb1e
MDL-64242 qtype_essay: more efficient query in restore code
...
Thanks to Juan Ibarra for the suggestion that lead to this fix.
2019-02-08 15:52:44 +00:00
Eloy Lafuente (stronk7)
28f7d52523
Merge branch 'MDL-64551-master' of git://github.com/rezaies/moodle
2019-02-06 23:44:35 +01:00
Eloy Lafuente (stronk7)
255e815d19
Merge branch 'MDL-64469-master' of https://github.com/lethevinh/moodle
2019-02-06 22:53:23 +01:00
Eloy Lafuente (stronk7)
89b1f3ac95
Merge branch 'wip-MDL-64404-master' of https://github.com/Beedell/moodle
2019-02-05 01:28:54 +01:00
M Kassaei
5179a01ab6
MDL-64646 drag-drop questions: improve editing forms
...
Users were getting confused between choice numbers and
group numbers. So choice numbers now show as [[1]] to
match what appears in the question text. Groups are now
letters A, B, ...
2019-02-01 10:20:08 +00:00
Eloy Lafuente (stronk7)
aa612f259e
Merge branch 'MDL-64464' of https://github.com/timhunt/moodle
2019-01-29 19:40:14 +01:00
Shamim Rezaie
029d3b471b
MDL-52132 qbehaviour_manualgraded: no change when comment is left blank
2019-01-24 16:20:01 +08:00
Marina Glancy
48f9ebcd62
MDL-64324 question: do not expect form id to be mform1
2019-01-23 17:37:52 +01:00
Jake Dallimore
b028dc05b8
Merge branch 'MDL-52132-master' of git://github.com/rezaies/moodle
2019-01-23 09:20:27 +08:00
Tim Hunt
d387f50fcd
MDL-64590 questions: wrong comments shown in the state history table
2019-01-18 18:00:42 +00:00
Andrew Nicols
f93e2c5c1e
MDL-52132 core_question: Comment is different if format has changed
2019-01-15 18:56:12 +11:00
Shamim Rezaie
305d2716f6
MDL-52132 qbehaviour_manualgraded: unit test for changing comment format
2019-01-15 18:56:03 +11:00
Shamim Rezaie
98e019455e
MDL-64551 core_question: Fix double ampersand escaping in tag button
2019-01-14 18:21:41 +11:00
Tim Hunt
e5153d93c0
MDL-64393 drag-drop qtypes: be more robust when page layout changes
2019-01-11 11:25:13 +00:00
Tim Hunt
096a5b9949
MDL-64464 drag-drop qtypes: allow <span lang=".."> id draggables
...
This is for accessibility, so that screen readers can read the drag
items with correct pronunciation.
2019-01-11 11:13:11 +00:00
Tim Hunt
c942cad763
MDL-64465 qtypes: fix incorrect context passed to format_string
2019-01-11 11:12:24 +00:00
VinhLe
2ea8fbb0bd
MDL-64469 Question bank: Change link questions in category question.
...
Make it easier to navigate from the category list to the questions in a category.
2019-01-11 11:28:49 +07:00
Eloy Lafuente (stronk7)
dbe8fe303b
Merge branch 'MDL-64479' of https://github.com/timhunt/moodle
2019-01-09 23:33:36 +01:00
Tim Hunt
d434dd7ae7
MDL-64479 dd-qtypes: fix questions with non-consecutive groups
2019-01-09 10:18:19 +00:00