Commit graph

111142 commits

Author SHA1 Message Date
Shamim Rezaie
fb3f018cf6 MDL-78082 core_grades: Fix locking issue with natural aggregation
Problem:
When the aggregation method is set to "natural," grade items' weights
and the maximum grade of the grade category's item get recalculated,
causing the needsupdate flag to be set to true. As a result, the locking
process was skipped, leading to unexpected behaviour.

Solution:
To address the issue, the set_locked method has been modified. Instead
of skipping the locking process, the method now schedules the locking of
grade items to occur slightly in the past, specifically one second in
the past. This ensures that the grade item will be automatically locked
after the recalculations are completed.

Explanation:
By making this adjustment, we ensure that the locking process is not
skipped during natural aggregation, maintaining consistent behaviour and
preventing any unintended consequences related to grade item locking.
2023-09-06 22:19:40 +10:00
Shamim Rezaie
a1cf8f143a MDL-78082 gradereport_grader: Enter should submit the form
Problem:
Previously, when users pressed the Enter key while interacting with the
grader report, instead of submitting the form, a table column was
inadvertently expanded or collapsed. This behaviour occurred due to the
expand/collapse buttons lacking an explicit 'type' attribute within the
form. As a result, these buttons were mistakenly treated as submit
buttons.

Solution:
In this commit, we have addressed the issue by ensuring that the
expand/collapse buttons now have the correct 'type' attribute set,
explicitly identifying them as non-submit buttons. This adjustment
prevents them from interfering with form submission unintentionally.

Explanation:
By making this fix, we improve the user experience in the grade book,
allowing users to navigate and interact with the interface more
smoothly. Pressing the Enter key will now trigger the form submission as
expected, rather than inadvertently activating expand/collapse actions.
2023-09-06 22:18:40 +10:00
Marina Glancy
3b160c7b71 MDL-79241 tool_mfa: correctly setup standard plugin type 2023-09-06 09:14:25 +01:00
Noel De Martin
87d4c398e3 MDL-79277 tool_mobile: Fix warning 2023-09-06 09:05:10 +02:00
Ilya Tregubov
4fa5a40f34
Merge branch 'MDL-76865-master' of https://github.com/daledavies/moodle 2023-09-06 14:48:15 +08:00
Andrew Nicols
aa7f105139
Merge branch 'MDL-79205' of https://github.com/paulholden/moodle 2023-09-06 12:52:28 +08:00
Andrew Nicols
add1afeea1
Merge branch 'MDL-79244-master' of https://github.com/lucaboesch/moodle 2023-09-06 12:49:24 +08:00
Andrew Nicols
1629a219e9
MDL-78779 gradereport_user: Replace wait steps with expectations 2023-09-06 12:40:45 +08:00
Andrew Nicols
4bfd20983d
MDL-78779 core: Do not re-render combo searchresults if term unchanged 2023-09-06 12:28:36 +08:00
Andrew Nicols
c7a05345b6
MDL-78779 core: Wrap combobox debounce in pending Promise
This addresses a random failure with the combobox search results where
the debounce causes the results to be shown, and then the same search
result is returned again, re-rendered, and replaced after Behat has
moved on.
2023-09-06 12:27:45 +08:00
Ilya Tregubov
bf109995b0
Merge branch 'master_MDL-67774' of https://github.com/mattporritt/moodle 2023-09-06 11:51:56 +08:00
meirzamoodle
3c3021a641 MDL-79210 lib: Code adjustments to the PHPSpreadSheet 1.29.0 2023-09-06 10:51:08 +07:00
meirzamoodle
e55ecbac8c MDL-79210 lib: Upgrade PHPSpreadSheet to 1.29.0 2023-09-06 10:51:08 +07:00
Matt Porritt
1560be7b7e MDL-67774 Authentication: Specify password peppers in config.php
Add a pepper to the users supplied password.
The pepper is stored in CFG and user to add extra security to
the password hash. By effectively breaking the information to
create the hashed password into two and storing it in more
than one place.
2023-09-06 13:47:51 +10:00
Jun Pataleta
5b06e8b01c
MDL-79057 gradereport_singleview: Use proper hidden attribute value
HTML attribute hidden="1" is invalid. It either needs to be set to an
empty string or use the keyword "hidden" for its value.
2023-09-06 10:32:33 +08:00
Ilya Tregubov
e8ac466426
Merge branch 'MDL-76459' of https://github.com/stronk7/moodle 2023-09-06 10:02:19 +08:00
Luca Bösch
45c9000653 MDL-79244 backup: fix typo for questioncannotberestored.
AMOS BEGIN
 MOV [questionegorycannotberestored,backup],[questioncannotberestored,backup]
AMOS END
2023-09-05 22:30:36 +02:00
Jun Pataleta
b8fe5b3a0e
MDL-79057 gradereport_singleview: Remove tabindex > 0 for elements
A tab index with a non-zero value messes up with the logical tab order
of a page.
2023-09-06 00:32:55 +08:00
Paul Holden
fd968053ec
Merge branch 'MDL-76419-master' of https://github.com/rjnl/moodle 2023-09-05 17:18:30 +01:00
Andrew Nicols
00f0613f99
on-demand release 4.3dev+ 2023-09-05 22:27:40 +08:00
Andrew Nicols
cc60490854
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2023-09-05 22:27:36 +08:00
AMOS bot
64bb886164 Automatically generated installer lang files 2023-09-05 14:25:23 +00:00
Gregor Eichelberger
f1e12ca909
MDL-79264 tiny: Replace hardcoded contextid
The `contextid` argument of the `tiny_equation_filter` AJAX call is
hardcoded to 1, which causes trouble if the context table does not start
with id 1.

Signed-off-by: Gregor Eichelberger <gregor.eichelberger@tuwien.ac.at>
2023-09-05 13:24:50 +02:00
Paul Holden
7d32eabbd2
MDL-78254 libraries: upgrade to version 5.65.15 of CodeMirror. 2023-09-05 10:06:57 +01:00
Paul Holden
56cd63a8f9
MDL-71494 mod_feedback: final removal of deprecated constructor param. 2023-09-05 09:09:26 +01:00
Paul Holden
259c496e73
MDL-75740 block_news_items: show full date format for all posts.
Co-authored-by: Przemek Kaszubski <przemka@amu.edu.pl>
2023-09-05 09:08:29 +01:00
Paul Holden
6e9e73aba0
MDL-79205 webservice: gracefully handle invalid functions in docs. 2023-09-05 08:51:51 +01:00
meirzamoodle
78e0fb0818 MDL-78244 lib: Update jQuery to 3.7.1 2023-09-05 14:30:30 +07:00
Jun Pataleta
f566bf4601
Merge branch 'MDL-78874-master' of https://github.com/danghieu1407/moodle 2023-09-05 12:05:59 +08:00
Ilya Tregubov
88ce8754b2
Merge branch 'MDL-77296-master' of https://github.com/davewoloszyn/moodle 2023-09-05 11:59:29 +08:00
Andrew Nicols
77dc50a76a
Merge branch 'MDL-79132' of https://github.com/AnupamaSarjoshi/moodle 2023-09-05 11:52:36 +08:00
Andrew Nicols
258698e6f3
MDL-75268 core: Add tiny_premium to list of standard plugins 2023-09-05 11:44:07 +08:00
Jake Dallimore
3ea06421de
MDL-78258 libraries: update 3rd party libs xml for lti1p3 2023-09-05 11:41:29 +08:00
Jake Dallimore
8800487194
MDL-78258 libraries: upgrade lti1p3 to v5.4.1
This is required since we updated php-jwt to 6.8.1 in MDL-78249.
2023-09-05 11:41:29 +08:00
Andrew Nicols
b3d8c1a862
Merge branch 'MDL-75268-master' of https://github.com/davewoloszyn/moodle 2023-09-05 11:39:41 +08:00
Andrew Nicols
ba1093c973
Merge branch 'MDL-78865' of https://github.com/danmarsden/moodle 2023-09-05 11:28:30 +08:00
Andrew Nicols
bbfa50946e
Merge branch 'MDL-79253-master' of https://github.com/junpataleta/moodle 2023-09-05 11:25:26 +08:00
Andrew Nicols
4e5ce1469c
Merge branch 'MDL-79060-master' of https://github.com/junpataleta/moodle 2023-09-05 11:23:46 +08:00
Jun Pataleta
4aeada159d
MDL-79060 course: Deprecate unused aria:courseimage lang string 2023-09-05 11:12:18 +08:00
Jun Pataleta
40da6b8f0c
MDL-79060 course: Use course name for the course image link 2023-09-05 11:10:13 +08:00
Andrew Nicols
ce4d696004
Merge branch 'MDL-79230' of https://github.com/paulholden/moodle 2023-09-05 10:56:28 +08:00
Ilya Tregubov
cbe667fe66
Merge branch 'MDL-78744-master' of https://github.com/roland04/moodle 2023-09-05 10:54:52 +08:00
Andrew Nicols
ee81bfabe8
Merge branch 'MDL-77061' of https://github.com/dravek/moodle 2023-09-05 10:53:19 +08:00
Andrew Nicols
1e6e9052ba
Merge branch 'MDL-79236' of https://github.com/paulholden/moodle 2023-09-05 10:40:53 +08:00
Andrew Nicols
2c830e04eb
Merge branch 'MDL-79237' of https://github.com/paulholden/moodle 2023-09-05 10:35:19 +08:00
Andrew Nicols
4e5510fcd7
Merge branch 'MDL-79238' of https://github.com/paulholden/moodle 2023-09-05 10:34:57 +08:00
Andrew Nicols
146a410d3a
Merge branch 'MDL-78946' of https://github.com/paulholden/moodle 2023-09-05 10:34:40 +08:00
Andrew Nicols
0d6650a928
Merge branch 'MDL-79191' of https://github.com/paulholden/moodle 2023-09-05 10:32:48 +08:00
Andrew Nicols
67bf116bfc
Merge branch 'MDL-79088-master' of https://github.com/marinaglancy/moodle 2023-09-05 10:28:46 +08:00
Jun Pataleta
b5b63270c5
MDL-78549 qtype_multianswer: Configure feedback popover trigger via JS
* For some reason, the `data-trigger="hover focus"` does not work when
rendering the popover via HTML. It just defaults to click, so the
feedback popover for qtype_multianswer questions does not show on hover.
Configuring the feedback popover's trigger via JS seems to work.
2023-09-05 09:34:33 +08:00