Commit graph

161 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
9215f9d294 NOBUG: Fixed SVG browser compatibility 2021-05-07 16:54:50 +02:00
Eloy Lafuente (stronk7)
0e077d9b68 Merge branch 'MDL-71343-m310' of https://github.com/rjnl/moodle into MOODLE_310_STABLE 2021-05-06 23:07:46 +02:00
Sara Arjona
373c263482 MDL-71408 h5plib_v124: Add required changes after lib upgrade
- The mbstring extension is required since Moodle 3.9 onwards so
the upgrading steps have been removed because they are not
required any more.
- The pull-request for fixing some minor PHP7.4 problems has been
integrated so this patch is not required.
2021-05-04 17:22:47 +02:00
Sara Arjona
ac7cd6c603 MDL-71408 h5plib_v124: Upgrade H5P core library to 1.24.02 2021-05-04 17:22:47 +02:00
Rajneel Totaram
f902e75bae MDL-71343 core_h5p: Convert all line-endings to UNIX format 2021-04-30 23:45:21 +12:00
Andrew Nicols
8fd5eb7be5 MDL-71343 core_h5p: Add unit test for helper::parse_js_array
Signed-off-by: Rajneel Totaram <rjnlfj@yahoo.com>
2021-04-30 23:40:49 +12:00
Sara Arjona
9e52a6a0e1 MDL-69415 core_h5p: prepend H5P libraries in autoloader
Core and mod_hvp are using the same namespace for some H5P
libraries. This is causing some random errors.
In order to get the expected behaviour in Moodle core, this patch
prepends H5P libraries in order to guarantee they are loaded first.
Plugins using same libraries will need to use a different namespace
if they overlap and a different version of these libraries should
be used.
2021-03-22 12:41:02 +01:00
Ilya Tregubov
f0260219fa MDL-70009 h5pactivity: Split get_pluginfile_hash in two methods. 2021-01-12 09:10:57 +02:00
cescobedo
53f9417795 MDL-70327 core_h5p: Add preventredirect to the player 2020-11-25 16:30:46 +01:00
Eloy Lafuente (stronk7)
b0a1b4ce8b MDL-70089 versions: bump all versions and requires near release
version = 2020110900 release version
requires= 2020110300 current beta+ (week6roll1) version

Note that, because we are under parallel development period,
this is being done in the branch that is going to be released
(MOODLE_310_STABLE already existing) for Moodle 3.10.0 and
not in master, that is the one getting the bump under normal
(non-parallel) periods.
2020-11-03 19:34:52 +01:00
Eloy Lafuente (stronk7)
35bc26b516 MDL-67673 phpunit: Remove deprecated assertContains() uses on strings
Both assertContains() and assertNotContains() are deprecated in PHPUnit 8
for operations on strings. Also the optional case parameter is. All uses
must be changed to one of:

- assertStringContainsString()
- assertStringContainsStringIgnoringCase()
- assertStringNotContainsString()
- assertStringNotContainsStringIgnoringCase()

More info: https://github.com/sebastianbergmann/phpunit/issues/3422

Regexp to find all uses:

ag 'assert(Not)?Contains\('
2020-10-21 12:46:05 +02:00
Eloy Lafuente (stronk7)
d81a94807b MDL-67673 phpunit: Fix the return type of template methods
All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...
2020-10-21 12:46:04 +02:00
Sara Arjona
cb4418bc5b Merge branch 'MDL-69736-310' of git://github.com/ferranrecio/moodle into MOODLE_310_STABLE 2020-10-19 09:03:51 +02:00
Jun Pataleta
30eccfabaa Merge branch 'MDL-69520-310' of git://github.com/sarjona/moodle into MOODLE_310_STABLE 2020-10-15 13:53:36 +08:00
Eloy Lafuente (stronk7)
12fce2a4bd Merge branch 'MDL-69813-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE 2020-10-14 22:47:12 +02:00
Sara Arjona
dde0818f6c MDL-69520 core_h5p: unit tests for covering example and tutorial 2020-10-14 18:35:52 +02:00
Sara Arjona
ad28920d0b MDL-69520 core_h5p: add example and tutorial links 2020-10-14 18:35:50 +02:00
Jun Pataleta
05a3e35677 Merge branch 'MDL-69257-310' of git://github.com/mihailges/moodle into MOODLE_310_STABLE 2020-10-09 11:12:16 +08:00
Mihail Geshoski
03058394f2 MDL-69257 core_h5p: Move $maxsize outside the foreach loop
There is no reason to repeatedly obtain the maximum size for uploading
files as a part of foreach loop.
2020-10-09 10:36:01 +08:00
Martin Gauk
1a80427018 MDL-69257 H5P: Check size of uploaded files and virus scan 2020-10-09 10:36:01 +08:00
Ferran Recio
a0999ab66f MDL-69736 core_h5p: enable player reporting 2020-10-06 13:05:33 +02:00
Paul Holden
7e3f7e3d7c MDL-69813 h5p: fix undefined addon ordering in framework test. 2020-10-06 10:48:06 +01:00
Amaia Anabitarte
5af206ad2a MDL-69712 core_h5p: Remove 'whitelist' key uses 2020-10-05 10:28:07 +02:00
Sara Arjona
d23f05828f MDL-69087 core_h5p: add renderer to let personalize styles
Existing mod_hvp pluging has a renderer to let Moodle instances
alter styles, Javascript, semantics (fields in the editor) and
content: https://github.com/h5p/moodle-mod_hvp/blob/stable/renderer.php

The approach for core_h5p is exactly the same, to let people
to reuse their existing code.
2020-09-24 19:56:42 +02:00
Sara Arjona
7805d0bb44 MDL-68909 h5p: move temporary editor files to draft area 2020-09-17 09:16:51 +02:00
Sara Arjona
330ba8cb10 MDL-69174 h5p: add component to the embed H5P code
When the Moodle component is passed to the player, xAPI tracking
is enabled so, if the component implements required xAPI API methods
(for instance, mod_h5pactivity does), grades and responses are sent.
Adding this component to the embed code will help to add
the embed code from a mod_h5pactivity to any other place (such as label,
page or book), and being able to track the responses to the original
mod_h5pactivity.
2020-08-28 12:26:38 +02:00
Adrian Greeve
dddff390da Merge branch 'MDL-69479-310' of git://github.com/mihailges/moodle into MOODLE_310_STABLE 2020-08-27 11:40:11 +08:00
Victor Deniz Falcon
e29edbe89e MDL-68921 core_h5p: Add H5P libraries metadata settings
An upgrade step updates installed H5P libraries
2020-08-25 00:30:02 +01:00
Eloy Lafuente (stronk7)
fe9ecef92b MDL-69479 upgrade: Change all 4.0 occurrences to 3.10
Under parallel development, when something is worth being commented
in upgrade.txt notes, it will be applied to all the development branches
using the "earliest" one to be released. So, if something changes
in 3.10 (and also is applied to master), the upgrade.txt notes will
show 3.10 in both branches.

Of course, if something only goes to one dev branch (say master), then the
master version will be used in the notes (4.0 in this case).
2020-08-24 14:08:46 +08:00
Jordan Tomkinson
ef8dff0565 MDL-69207 core_h5p: Add muc cache support for h5p library files 2020-08-06 02:40:24 +01:00
Sara Arjona
1826ac971a Merge branch 'MDL-68902-master' of git://github.com/ferranrecio/moodle 2020-06-10 17:57:40 +02:00
Jake Dallimore
337e2e2b23 Merge branch 'MDL-68973' of https://github.com/stronk7/moodle 2020-06-10 16:13:57 +08:00
Adrian Greeve
fc9be99323 Merge branch 'MDL-68985-master' of git://github.com/sarjona/moodle 2020-06-10 09:39:45 +08:00
Helen Foster
1ab405f4a2 MDL-68972 lang: Import fixed English strings (en_fix) 2020-06-09 20:56:34 +02:00
Ferran Recio
4b6e92b8e9 MDL-68902 core_h5p: add essay h5p package 2020-06-09 16:58:17 +02:00
Eloy Lafuente (stronk7)
115cc0214f MDL-68973 versions: bump all versions and requires near release
version = 2020061500 release version
requires= 2020060900 current rc1 (week7roll1) version
2020-06-09 16:23:09 +02:00
Sara Arjona
982a9a5919 MDL-68985 core_h5p: fix issue with composed code languages
Composed code languages, such as 'Spanish, Mexican' are different
in H5P and Moodle:
- In H5P, they use '-' to separate the language from the country.
For instance: es-mx.
- However, in Moodle, they have '_' instead of '-'. For example: es_mx.
2020-06-09 14:38:27 +02:00
Ferran Recio
346c51690c MDL-68873 core_h5p: fix editor H5P file update 2020-06-08 10:44:23 +08:00
Adrian Greeve
8d20e3c688 Merge branch 'MDL-68922-master' of git://github.com/sarjona/moodle 2020-06-08 10:16:53 +08:00
Jake Dallimore
5c361ed9af Merge branch 'MDL-68917-master' of git://github.com/sarjona/moodle 2020-06-08 09:41:27 +08:00
Sara Arjona
5eb78045d4 MDL-68704 h5plib_v124: upgrade JQuery version to 1.12.4 2020-06-05 19:44:38 +01:00
Sara Arjona
4c2cdbe261 MDL-68922 core_h5p: upgrade content with newer libraries
The H5P editor always uses the latest libraries version.
Besides, H5P has a mechanism for upgrading content created
using older libraries. So, in order to be able to edit
existing content created with older libraries, we can assume
the library may change (for instance, from
"Course presentation 1.20" to "Course presentation 1.22")
because the $content->h5plibrary contains both (machinename and
major/minor version).
2020-06-05 09:17:06 +02:00
Víctor Déniz Falcón
88036713a5 MDL-68641 core_h5p: test dropped because the tested method was deleted 2020-06-04 19:27:59 +01:00
Sara Arjona
9df9251c96 MDL-68917 core_h5p: use the correct libraryUrl
The libraryUrl was empty (because ->out was missing)
and pointing to the wrong URL (because 'core' is not required,
because it's added by the method).
2020-06-04 14:28:05 +02:00
Víctor Déniz Falcón
96a4d3f309 Merge branch 'MDL-68641-master' of git://github.com/aanabit/moodle 2020-06-04 12:46:11 +01:00
Amaia Anabitarte
6157f5930f MDL-68641 core_h5p: Fixing capability checks in ajax.php 2020-06-04 13:44:23 +02:00
Víctor Déniz Falcón
0e6d73245b Merge branch 'MDL-68904-master' of git://github.com/sarjona/moodle 2020-06-03 16:59:43 +01:00
Sara Arjona
881dca064d MDL-68904 core_h5p: order libraries by title 2020-06-03 12:01:59 +02:00
Amaia Anabitarte
6219740b8e MDL-68578 contenttype_h5p: Add name attribute to editor iframe
The switch_to_class_iframe step needs a name attribute for the iframe.
H5P third party library does not add that name attribute, so we add it.
2020-06-02 16:17:22 +02:00
Amaia Anabitarte
3149defec1 MDL-68578 contenttype_h5p: Save content title from uploaded H5P file 2020-06-02 16:17:22 +02:00