Commit graph

20598 commits

Author SHA1 Message Date
Andrew Nicols
e3138b870e MDL-62514 behat: Rewrite handling of autocomplete
This includes a minor restructure of the autocomplete JS to make use of
promises and improve tracking of pending JS.

In particular it improves the way in which throttled text input is
handled to ensure that the behat does not continue until:
- typing is fully complete; and
- all possible ajax requests have been sent; and
- all possible ajax requests complete; and
- the suggestions are updated.

A number of conditions existed where behat would move on to the next
step too early in a race condition effect between Behat and Autocomplete.
2019-01-30 08:26:31 +08:00
Sara Arjona
2844f968b0 Merge branch 'MDL-64313-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2019-01-29 12:35:49 +01:00
Mihail Geshoski
7c815adea4 MDL-47247 mod_folder: Apply site config when showexpanded is not set 2019-01-29 08:59:05 +08:00
Sara Arjona
a5fb32a623 Merge branch 'MDL-62668-35' of git://github.com/jleyva/moodle into MOODLE_35_STABLE 2019-01-28 19:43:34 +01:00
Sara Arjona
4a6403f068 Merge branch 'MDL-56604-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2019-01-28 13:33:07 +01:00
Garrett Boone
4fc6d79fa3 MDL-64640 feedback: Fix target link on deletion 2019-01-27 18:15:51 +08:00
Damyon Wiese
be1f9cfba2 MDL-56604 assign: Group submission status
On the page listing all assignments for the course,
show the status of the group submission if teamsubmissions is enabled
for the assignment.
2019-01-24 14:34:47 +08:00
Eloy Lafuente (stronk7)
8eaffb287a Merge branch 'MDL-64240-35' of git://github.com/mickhawkins/moodle into MOODLE_35_STABLE 2019-01-24 00:57:03 +01:00
Sara Arjona
f958fafc60 Merge branch 'MDL-64107-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2019-01-23 10:22:32 +01:00
Sara Arjona
70a11e3daa Merge branch 'MDL-63628-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2019-01-23 08:25:19 +01:00
Eloy Lafuente (stronk7)
2baaed1860 Merge branch 'MDL-63870_35' of https://github.com/timhunt/moodle into MOODLE_35_STABLE 2019-01-23 00:09:47 +01:00
Sara Arjona
279ec1f986 Merge branch 'MDL-64486-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2019-01-22 08:23:31 +01:00
Michael Hawkins
b52735e2b4 MDL-63892 mod_forum: Updating lib unit test 2019-01-22 13:55:10 +08:00
Michael Hawkins
ee95b9c319 MDL-63892 mod_forum: Fix last post details in forum view 2019-01-22 13:55:10 +08:00
Michael Hawkins
81e8a74a7b MDL-63892 mod_forum: Correction to timestamp added to edit strings 2019-01-22 13:55:10 +08:00
Damyon Wiese
152e59f56d MDL-63628 accessibility: Trigger file links with keyboard 2019-01-22 08:41:01 +08:00
Jake Dallimore
284b7c820e Merge branch 'MDL-28445-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2019-01-21 15:59:10 +08:00
Tim Hunt
901c95587f MDL-63870 quiz: new preview should abandon, not finish, current attempt 2019-01-17 17:55:41 +00:00
Peter
a67284cb47 MDL-28445 mod_glossary: Use compound strings as opposed to anglicised
* Use compound strings on buttons to help with proper translations
* Updated behat tests
2019-01-17 10:59:13 +08:00
Sara Arjona
a660a74f7a Merge branch 'MDL-64346-35' of git://github.com/abgreeve/moodle into MOODLE_35_STABLE 2019-01-15 15:38:40 +01:00
Adrian Greeve
017578d64f MDL-64346 mod_resource: Fix problems with # in file name. 2019-01-15 14:30:35 +01:00
Sara Arjona
fcd19e1faf Merge branch 'MDL-60082-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2019-01-14 12:28:30 +01:00
Jake Dallimore
96457d1739 Merge branch 'MDL-64375-35' of git://github.com/damyon/moodle into MOODLE_35_STABLE 2019-01-09 15:34:06 +08:00
Eloy Lafuente (stronk7)
67d77a2456 MDL-24951 mod_forum: Apply new string to related scenarios
Plus amend an scenario name that was clearly incorrect.
2019-01-08 16:48:25 +01:00
Eloy Lafuente (stronk7)
80f46ee1c0 Merge branch 'MDL-64509-35-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_35_STABLE 2019-01-08 16:19:56 +01:00
Andrew Nicols
7c512ad12f Merge branch 'MDL-24951-35' of git://github.com/Chocolate-lightning/moodle into MOODLE_35_STABLE 2019-01-08 14:20:25 +08:00
Andrew Nicols
68da8600b7 Merge branch 'MDL-64400-35' of git://github.com/aanabit/moodle into MOODLE_35_STABLE 2019-01-08 08:32:16 +08:00
Eloy Lafuente (stronk7)
712fc8341c Merge branch 'MDL-63809-35-5' of git://github.com/rezaies/moodle into MOODLE_35_STABLE 2019-01-07 22:13:40 +01:00
Helen Foster
ed72175e45 MDL-64509 lang: Import fixed English strings (en_fix) 2019-01-07 20:21:09 +01:00
Damyon Wiese
aa3c3bd353 MDL-64375 gradingform_rubric: Styles for overflow
Allow people to define lots of levels, and make the scroll region just the rubric table,
not the entire content region.
2019-01-04 08:44:41 +08:00
Peter
f8be708257 MDL-64486 mod_glossary: Add missing separator for special links 2019-01-03 08:39:46 +08:00
Peter
40bf3feacd MDL-63148 mod_scorm: Accept userid param in event action
* Update lib scorm functions to accept and use a passed in userid
* Additional phpunit tests
2019-01-02 14:36:20 +08:00
Amaia Anabitarte
ecb4b0260e MDL-64400 core_messages: Mark notifications sent via email as read 2018-12-27 09:32:25 +01:00
Mathew
3430f5252a MDL-49651 mod_forum: Respect course visibility in cron
This checks the courses' current visibility and the users permissions.
If they have the permission to view the course when it is hidden they'll get messages.

We already have checks for the users enrolled & subscription status.
2018-12-24 09:34:47 +08:00
Mathew
2f56e8a287 MDL-24951 mod_forum: Check user capability to know what message to show.
If the user has the following capabilty: mod/forum:canposttomygroups then show them
the more technical of the strings. Otherwise we use something a bit easier for them to ask their
tutor or teacher about.
2018-12-24 09:13:36 +08:00
Andrew Nicols
56ec2b0949 Merge branch 'MDL-63512-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2018-12-19 10:01:00 +08:00
Michael Hawkins
9d046294fb MDL-64240 mod_forum: Clean forum post text before storing
Previously only edited messages were cleaned, so longer strings could
be stored in the database, which would never be displayed.
This update takes into account trusted text before cleaning (as editing does).
2018-12-18 15:10:21 +08:00
Michael Hawkins
968c6115dc MDL-64240 mod_forum: Update word count to use current message length
Previously this used the length of the message stored in the database,
before scripts etc are cleaned to display the content. That resulted
in cases where the count would seem much larger than the message size.
2018-12-18 15:10:16 +08:00
Tim Hunt
1340c03ba6 MDL-63809 question bank: ensure question_has_capability_on can be called 2018-12-18 15:44:36 +11:00
Damyon Wiese
16668320a6 MDL-60082 assign: Grading worksheet with no grade
If the grade type is NONE - do not include the maxgrade column.
2018-12-18 11:14:19 +08:00
Eloy Lafuente (stronk7)
7650dbcaae MDL-63891 assignfeedback_editpdf: add missing UK to install.xml
Backport of MDL-57610.
2018-12-17 11:22:18 +01:00
Adam Olley
4015cb2d05 MDL-63891 assignfeedback_editpdf: integration cleanup
* Add a note to upgrade.php to notify devs/admins of the new setting.
* Replace update_record with set_field.
* Add missing phpdoc.

Backport of MDL-57610.
2018-12-17 11:22:17 +01:00
Adam Olley
b1aac17d18 MDL-63891 assignfeedback_editpdf: Add test coverage for conversion task
Without this, we have no coverage of the convert_submissions task. This test
validates it both works normally, and that it also skips queued items that have
exceeded the conversion attempt limit introduced in this improvement.

Backport of MDL-57610.
2018-12-17 11:21:38 +01:00
Adam Olley
de341c20d4 MDL-63891 assignfeedback_editpdf: remove queued jobs that keep failing
Without this, its possible to get a document in the editpdf conversion queue
that keeps failing - and in some cases completely crashing the PHP script
despite exception handling - which ends up blocking the processing of the queue
entirely.

This change allows for a configurable number of attempts the conversion
task will perform before removing the item from the queue.

Backport of MDL-57610.
2018-12-17 11:21:38 +01:00
Andrew Nicols
613d4f9e6d Merge branch 'MDL-61633-35' of https://github.com/lucisgit/moodle into MOODLE_35_STABLE 2018-12-17 15:29:40 +08:00
Damyon Wiese
ee38a8d1e4 MDL-64107 questions: Increase highlight contrast
When a question has just been edited, it is highlighted. We need to ensure
the colour contrast of text on background is accessible.
2018-12-17 12:36:03 +08:00
Peter
f13544412e MDL-63512 mod_lesson: Fix video links provided in feedback 2018-12-14 10:27:12 +08:00
Tony Butler
773e24cad4 MDL-61633 assignfeedback_editpdf: Scroll back to top when changing pages 2018-12-13 12:21:07 +00:00
Jake Dallimore
583799d5b9 Merge branch 'MDL-63150-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2018-12-12 08:32:55 +08:00
Jake Dallimore
7f0903200f Merge branch 'MDL-63145-35' of git://github.com/peterRd/moodle into MOODLE_35_STABLE 2018-12-12 08:30:20 +08:00