Commit graph

84037 commits

Author SHA1 Message Date
Rajesh Taneja
ade50a118a
MDL-58056 behat: Catch webdriver exception if element removed
While checking for element visibility, ensure
that element is there in dom
2017-02-23 14:44:43 +08:00
AMOS bot
be5e864416 Automatically generated installer lang files 2017-02-23 00:05:13 +08:00
David Mudrák
bb2924d018 MDL-58050 message: Commit the transaction before the early return
If there was no conversation found and the method returned early, the
active transaction was not marked as committable and the error was
reported by the request shutdown handler.

Attaching a unit test for the case just because it did not seem to be
covered. I was trying to reproduce the thrown error in the unit test but
it can't be used in this case. The shutdown handler puts the warning
directly into the error_log and it is not guaranteed where such messages
go (depending on the PHP configuration). And we do not even raise it
during the unit test execution (presumably due to noise it would
produce) anyway.
2017-02-22 13:56:02 +01:00
David Mudrák
0c44da7887 MDL-58050 message: Fix the DB transaction handling
Consumer code is not supposed to call commit_delegated_transaction()
method directly, this was incorrect usage of the delegated transactions.
2017-02-22 13:42:05 +01:00
Daniel Thee Roperto
b80caca188 MDL-57840 libraries: Fixed missing fields in get_users_by_field(). 2017-02-22 16:07:14 +11:00
Ankit Agarwal
3e40dc8c61 MDL-58032 core_user: Fix case when acting user is a visitor 2017-02-22 09:00:45 +05:30
Eloy Lafuente (stronk7)
492099d929 Merge branch 'MDL-57527-master' of git://github.com/danpoltawski/moodle 2017-02-22 00:52:03 +01:00
Eloy Lafuente (stronk7)
5c73061bb9 Merge branch 'wip-mdl-57765' of https://github.com/rajeshtaneja/moodle 2017-02-21 23:53:39 +01:00
Eloy Lafuente (stronk7)
edc44ac356 Merge branch 'MDL-57633-master' of git://github.com/jleyva/moodle 2017-02-21 23:45:14 +01:00
Sam Chaffee
29be72373c MDL-58041 tool_monitor: Fix event monitor subscription behat failures 2017-02-21 11:19:40 -07:00
Tim Hunt
898da28afd MDL-58040 blocklib: never use global in block manager class
This switches everything to ->page, including coverting static method to real one.
2017-02-21 15:19:11 +00:00
David Monllao
73eceea93f Merge branch 'wip-MDL-40838-master-2' of git://github.com/marinaglancy/moodle 2017-02-21 09:30:31 +01:00
David Monllao
b98b37c670 Merge branch 'MDL-57602-master' of https://github.com/lucisgit/moodle 2017-02-21 08:43:16 +01:00
Adam Olley
767761b7d8 MDL-58030 gradingform_guide: Init $commentchooser before use
The initialisation of $commentschooser was moved into an IF condition,
whilst still using it outside of that IF conditions scope. As such, if
there are no comments to choose from, the variable is never init'd but
it still goes to use it, emitting a PHP notice.
2017-02-21 14:31:20 +10:30
Eloy Lafuente (stronk7)
3cb7fc4f9a Merge branch 'MDL-57619-master' of git://github.com/ankitagarwal/moodle 2017-02-21 01:06:29 +01:00
Eloy Lafuente (stronk7)
ac1837e6d6 Merge branch 'wip-MDL-57113-master' of https://github.com/kwiliarty/moodle 2017-02-21 00:59:54 +01:00
Eloy Lafuente (stronk7)
860b099f46 Merge branch 'wip-mdl-56616' of https://github.com/rajeshtaneja/moodle 2017-02-21 00:56:26 +01:00
Eloy Lafuente (stronk7)
aedde678c7 Merge branch 'MDL-55867_m33v1' of https://github.com/sbourget/moodle 2017-02-21 00:52:20 +01:00
Eloy Lafuente (stronk7)
fbbda1ec6e Merge branch 'MDL-56206-text-enrolled-users-page-aligned' of https://github.com/lucaboesch/moodle 2017-02-20 19:15:23 +01:00
David Monllao
74d2cce2fa Merge branch 'MDL-57576-33-updatefeedbackfile' of git://github.com/roperto/moodle 2017-02-20 12:27:26 +01:00
Dan Poltawski
f1b1c85b63 Merge branch 'MDL-57962-master' of git://github.com/dpalou/moodle 2017-02-20 11:19:16 +00:00
David Monllao
4163871cea Merge branch 'MDL-57795-master' of https://github.com/snake/moodle 2017-02-20 10:28:16 +01:00
David Monllao
742043f3b7 Merge branch 'MDL-57801-master' of https://github.com/lucisgit/moodle 2017-02-20 10:10:01 +01:00
David Monllao
2e57a90e0e Merge branch 'MDL-57859-master' of git://github.com/merrill-oakland/moodle 2017-02-20 09:42:25 +01:00
David Monllao
cb0f30cf77 Merge branch 'MDL-58014_master' of git://github.com/markn86/moodle 2017-02-20 09:32:11 +01:00
David Monllao
6c6492a284 Merge branch 'MDL-56679-master' of git://github.com/junpataleta/moodle 2017-02-20 09:20:11 +01:00
David Monllao
49b8fa7fce Merge branch 'MDL-57274-master' of https://github.com/snake/moodle 2017-02-20 09:07:18 +01:00
David Monllao
6b9d6d2eab Merge branch 'MDL-50729-master' of git://github.com/ankitagarwal/moodle 2017-02-20 08:26:39 +01:00
Mark Nelson
29c3b0b4d2 MDL-58014 core_message: fixed unread message count 2017-02-20 13:29:13 +08:00
Marina Glancy
0c30e89f34 MDL-55547 tool_monitor: fix exceptions when course was deleted
Delete subscriptions when course is deleted
2017-02-20 12:11:29 +08:00
Marina Glancy
92253b15b7 MDL-40838 backup: restore enrolment methods without users 2017-02-20 12:08:35 +08:00
Jake Dallimore
a448a38b1d MDL-57274 upgrade: fix curl security notices during upgrade/install
Handles the case where $CFG->curlsecurityxxx vars don't yet exist
during install or upgrade by treating not set the same as empty.
2017-02-20 08:55:57 +08:00
Jake Dallimore
5cb060b878 MDL-57795 mod_assign: fix for filters killing review pane when grading
Fixes a bug in which the review pane was destroyed if the user selected
a combination of filters resulting in no matched users. Now, the pane
is just hidden in such cases, and displayed again if subsequent filter
changes return one or more users.
2017-02-20 08:51:35 +08:00
Dan Poltawski
c7abec68a6 Merge branch 'MDL-57967_master' of git://github.com/markn86/moodle 2017-02-19 19:44:51 +00:00
Matteo Scaramuccia
cdf8238b14 MDL-57379 Files: Improved file argument evaluation.
get_file_argument() is responsible to extract the relative path
of the file to be served by a specific Moodle component
like a theme or a module.
Some modules like scorm and imscp require slasharguments support
and they force it when creating the URLs to serve their files.
It should honor the slasharguments setting but this could break
those instances where existing hard-coded links still make usage of
the "old" format, the one when slasharguments is set to No i.e. '?file='.

Its logic has been improved by looking at when the URL is related to
serving a plug-in file in a "forced" slasharguments way of serving it
i.e. using '/pluginfile.php/' and not '/pluginfile.php?'.
2017-02-19 16:39:04 +01:00
Dan Poltawski
ddc1306c97 MDL-57557 calendar: remove YUI module 2017-02-17 14:05:30 +00:00
Dan Poltawski
6e24853aa1 MDL-57557 calendar: convert from yui module to bootstrap popovers 2017-02-17 14:05:29 +00:00
Dan Poltawski
facf039a00 MDL-57557 boost: allow any type of popover 2017-02-17 14:05:29 +00:00
Tony Butler
efa7d24168 MDL-57801 core_filestorage: Delete temp file if disk space runs out 2017-02-16 12:41:06 +00:00
Tony Butler
961323a05f MDL-57801 core_filestorage: Verify hash of temp file before committing
This addresses an edge scenario on NFS filesystems with no space
remaining, where subsequent uploads fail silently while zero byte files
are saved to the pool (and for some reason the filesize check passes).
2017-02-16 12:38:58 +00:00
Tony Butler
eb43ef6c97 MDL-57602 mod_assign: Add 'Granted extension' filter for grading UI 2017-02-16 11:23:41 +00:00
Tony Butler
696bd4d68b MDL-57602 mod_assign: Add 'Granted extension' filter for grading table 2017-02-16 11:23:41 +00:00
Gergely Kún
2a00bd159d MDL-56679 core: Initialise $SESSION if necessary 2017-02-16 16:17:14 +08:00
Dan Poltawski
9ec952f237 weekly release 3.3dev 2017-02-16 08:14:32 +00:00
Dan Poltawski
3129b28a28 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2017-02-16 08:14:28 +00:00
Dan Poltawski
1fff8332cf Merge branch 'wip-MDL-4782-fix' of https://github.com/marinaglancy/moodle 2017-02-16 07:51:02 +00:00
Ankit Agarwal
d58adec8de MDL-57619 behat: Final deprecation of old behat steps 2017-02-16 11:54:10 +05:30
Mark Nelson
f512355b31 MDL-57967 core_message: do not process conversations from deleted users 2017-02-16 13:01:06 +08:00
Marina Glancy
024d120ffc MDL-4782 install: add major db change version 2017-02-16 09:28:29 +08:00
David Monllao
c181f152d7 MDL-57697 survey: Remove unexisting param 2017-02-15 11:02:02 +01:00