Commit graph

122 commits

Author SHA1 Message Date
Marina Glancy
d2941e8808 Merge branch 'MDL-42471-master' of git://github.com/andrewnicols/moodle 2013-11-01 09:00:05 +08:00
Andrew Nicols
6a2da367aa MDL-42471 JavaScript: Adding missing dependency to toolbox 2013-10-25 13:40:40 +08:00
Dan Poltawski
012b0472c5 Merge branch '42299-26' of git://github.com/samhemelryk/moodle
Conflicts:
	version.php
2013-10-24 15:47:48 +08:00
Dan Poltawski
181b0b3c3e Merge branch 'MDL-42117-master' of git://github.com/andrewnicols/moodle 2013-10-22 12:11:42 +02:00
Andrew Nicols
d5367fb566 MDL-42117 JavaScript: Ensure that new activities are fully set up
We don't need to set up anything specifically for toolboxes any more, but
other third-party JS may require additional setup following new module
creation.
2013-10-22 11:26:44 +08:00
Andrew Nicols
b676db838b MDL-42117 JavaScript: Don't rely on node data for course toolboxes
The YUI versions of getData and setData do not store the data in the DOM,
but in an instance of YUI. If you make modifications in one instance, but
apply them in another, then the data values are not accessible between
these two instances.

Additionally, there's no benefit to storing the instances on
initialisation - if anything, it increases the load overhead.

This change moves toolboxes to calculating their ancestors on click in the
same way it was done in the initialiser.
2013-10-22 11:26:36 +08:00
Dan Poltawski
9c5ab08e5a Merge branch 'MDL-34209-master' of git://github.com/andrewnicols/moodle 2013-10-21 13:58:14 +08:00
Sam Hemelryk
d5de874727 MDL-42299 course: management interface remember categories expanded by AJAX
Categories that have been expanded using AJAX are now remember and
expanded again autoamtically when something triggers a page refresh.
2013-10-17 08:41:12 +13:00
Eloy Lafuente (stronk7)
cbef1d9d3f MDL-42302 course: re-shitfering management module. 2013-10-16 00:53:58 +02:00
Sam Hemelryk
b155a17034 MDL-42302 course: fixed bugs while changing visibility
* No longer uses show which is resvered on MySQL
* Selected category courses are now always returned.
2013-10-16 08:25:08 +13:00
Andrew Nicols
9f3f4a3c3f MDL-34209 JavaScript: Tidy up dragdrop code. 2013-10-10 14:42:06 +08:00
Andrew Nicols
b57bc5855c MDL-34209 JavaScript: Simplify section drag/drop to fix reordering issues 2013-10-10 14:42:06 +08:00
Damyon Wiese
033f721362 MDL-31830 course: Remove unused shifter built js files 2013-10-07 15:58:59 +08:00
Sam Hemelryk
7fd307b153 MDL-31830 course: fixed up minor points as noted by Damyon's integration review
* Fixed typo breaking drag and drop of courses.
* Fixed the ' ' title for the create new button plus two other icons I found as well.
* Adding padding to items displayed in the action menu drop down. base + bootstrapbase.
* Padding adjusted to the same as on the course page. base + bootstrapbase.
* Removed hover icon from categories. base only.
* Fixed categroy typo
* Removed min-width that was being applied to coursename making its clickable area larger than normal.
* The category tree is now presented using aria attributes as per http://www.w3.org/WAI/GL/wiki/Using_ARIA_trees
* Bulk action selectors now use aria-labelledby
* Category course count now given access hidden label.
* Pagination links now have better titles.
* The course action icons now present with role=button
2013-10-07 19:41:52 +13:00
Sam Hemelryk
8aa3aa3dfd MDL-31830 course: management behat tests corrected after fixes 2013-10-07 17:34:09 +13:00
Sam Hemelryk
484c4c6cf3 MDL-31830 course: several management interface improvements
* Tidied up course detail permissions so that user is not shown information they couldn't access elsewhere.
* category link dimming now accounts for course creation as an action as well.
* category single select when in courses view mode is now limited to courses user can action in.
* There is now a check at the start of the management page to redirect to course/index.php if the user isn't able to manage in any category.
* Tweaked navigation again, to give the limited users a navbar structure similar to the system cap'd user.
* Cancelling a category delete now takes you back to the category you were viewing.
* Fixed undefined notice
* Improved placement of course request and approval links.
* Several styling tweaks/improvements to the base theme.
* Several styling tweaks/improvements to the bootstrapbase theme.
2013-10-07 10:22:57 +13:00
Sam Hemelryk
c46996ea5a MDL-31830 course: improvements to JS coding style 2013-10-07 10:22:51 +13:00
Sam Hemelryk
f454e3247d MDL-31830 course: management interface fixes as noted
* Fixed the highlighing of the default category when no categories have been selected.
* Fixed the bug preventing the action menu for AJAX loaded categories from functioning.
* Repositioned course idnumber infront of course actions.
* Fixed display of moveup on first item and movedown on last item (courses and categories)
* Fixed up resort selected categories string.
2013-10-07 10:22:45 +13:00
Sam Hemelryk
5dc361e16e MDL-31830 core_course: new course category management interface
* Implemented a new course and category management page.
* Deprecated the old management interface.
* Unit tests to cover the new API and core functions.
* Behat tests to cover the new interface.
2013-10-07 10:21:41 +13:00
rwijaya
983c46a8a7 MDL-40829 frontpage course heading: add padding to coursename and fix info ajax 2013-10-03 15:47:47 +08:00
rwijaya
faf6010b10 MDL-40829: courses heading: remove headerblock class from header and fix heading levels.
Also, changing h3 classname from name to categoryname.
    Added note to theme/upgrade.txt to describe the heading level changes.
2013-10-02 09:46:26 +13:00
Sam Hemelryk
73cc3bdeb0 Merge branch 'MDL-41227_dd' of https://github.com/andyjdavis/moodle
Conflicts:
	course/yui/toolboxes/toolboxes.js
2013-09-30 16:15:53 +13:00
Andrew Nicols
e818be1046 MDL-40811 JavaScript: Cast activityid to string when checking resources to show/hide 2013-09-25 18:14:06 +01:00
Eloy Lafuente (stronk7)
81eba750d4 Merge branch 'MDL-40811-m' of git://github.com/andrewnicols/moodle 2013-09-24 23:23:15 +02:00
Andrew Nicols
0082df9d12 MDL-36465 Course JavaScript: Ensure that the zero section is not draggable 2013-09-23 09:21:44 +01:00
Andrew Davis
d0f30b07ce MDL-41227 core_course:fixed up some JS that was confusing activity visibility 2013-09-23 09:35:27 +07:00
Andrew Nicols
dd834cba33 MDL-38661 JavaScript: Add missing lazy loading on collapseall 2013-09-18 11:04:31 +01:00
Andrew Nicols
9bda17ee6f MDL-40811 JavaScript: Use the new moodle-course-util functions 2013-09-16 21:05:02 +01:00
Andrew Nicols
36c1ac9b7a MDL-40811 JavaScript: Create a course-util module to reduce code duplication 2013-09-16 20:44:19 +01:00
Andrew Nicols
4dab1c39e2 MDL-38661 JavaScript: Ensure that ARIA tags are set when expanding/collapsing content 2013-09-10 03:22:44 +01:00
Andrew Nicols
1574e6529d MDL-38661: Add keyboard support for expansion 2013-09-10 03:17:13 +01:00
Andrew Robert Nicols
53c1b936e5 MDL-38661 Course: Add JS category expander.
This adds a category expanded which:
* fetches child content in a category tree if it has not already been loaded;
* toggles relevant classes on the category node to show and hide child content; and
* applies appropriate animations to improve user experience.
2013-09-06 10:05:36 +10:00
Damyon Wiese
dd66b6ab48 MDL-36002 core: Make drag and drop keyboard friendly (round 2) 2013-08-15 14:39:00 +08:00
Sam Hemelryk
702d1f853e Revert "MDL-36002 core: Make drag and drop keyboard friendly"
This reverts commit 7c271b9, 313e585, ade4695, and 70b4027

Conflicts:
	theme/bootstrapbase/style/moodle.css
2013-08-15 13:59:06 +12:00
Dan Poltawski
f2b45ad65f Merge branch 'MDL-36002-master' of git://github.com/damyon/moodle
Conflicts:
	theme/base/style/core.css
	theme/bootstrapbase/style/moodle.css
2013-08-12 11:56:37 +08:00
Sam Hemelryk
f803ce267f MDL-39814 actionmenu: tweaked the action menu post integration
The following changes have been made:
 * course_section_cm_edit_actions now allows the caller more options for the
   display of the action menu.
 * The site menu block now disables the JS enhancement of the actionmenu so
   that it displays as it did before. After more testing this seemed like the
   only option that worked in the limited space of the block when it had
   several modules.
 * draganddrop of resources now triggers the action menu enhancement as well.
 * Fixed display of title when the menu is not being enhanced by JS.
 * Fixed the alignment of the completion icon in the bootstrapbase theme.
 * Tweaked the CSS for the standard theme.
2013-08-01 13:05:04 +12:00
Damyon Wiese
7c271b918e MDL-36002 core: Make drag and drop keyboard friendly
This change adds keyboard support to core drag and drop.

Selecting a grab handle and hitting enter (or space) will
open a menu of possible drop targets and allow you to choose one.

The only other UI change this implies is we need to show the grab
for blocks.
2013-07-31 16:43:25 +08:00
Sam Hemelryk
10fc156933 MDL-39814 frontend: added options to disable new action menus
Also:
 * Tidied up patch as per peer-reviews
2013-07-30 16:15:52 +12:00
Sam Hemelryk
3665af78ca MDL-39814 actionmenu: improved alignment, constraint handling, and accessibility 2013-07-30 16:15:26 +12:00
Sam Hemelryk
e5de4933b0 MDL-39814 frontend: redeveloped overlay to correct tab-flow
Also:
 * fixed zindex issue + spinner placement
 * added notes to course format and theme upgrade texts
 * fixed behat tests after action menu changes
2013-07-30 16:15:19 +12:00
Sam Hemelryk
cf69a00a1c MDL-39814 frontend: introduced an action_menu_action class 2013-07-30 16:15:05 +12:00
Sam Hemelryk
b59f2e3bef MDL-39814 frontend: improved display of activities and the menu 2013-07-30 16:14:56 +12:00
Sam Hemelryk
e282c679e3 MDL-39814 frontend: improvements to course/block editing 2013-07-30 16:07:26 +12:00
Dan Poltawski
4fb3df32ac MDL-39422 course: prevent module names longer 255 chars
To prevent ugly DB errors.
2013-04-30 17:21:15 +01:00
Rajesh Taneja
fa1ccff866 MDL-36125 course: Added aria-describedby for editing activity title 2013-03-22 12:39:24 +08:00
Eloy Lafuente (stronk7)
b1ed9f6970 Merge branch 'MDL-38141-m' of git://github.com/andrewnicols/moodle 2013-02-26 01:19:29 +01:00
Andrew Robert Nicols
005c6c203f MDL-38141 JavaScript: Remove unused dependency in module chooser 2013-02-20 21:37:43 +00:00
Marina Glancy
9ecb50e6e3 MDL-33774 instead of checking that activity is label we check that it has view url 2013-02-14 19:46:19 +11:00
Andrew Robert Nicols
8a185b9ebc MDL-34671 Stop browser receiving escape keydown in modal dialogues
In certain modal dialogues, we listen on the Escape key to close a
dialogue. However, this is still passed to the browser. As a result, if the
browser is in full screen mode and that browser respects the escape key as
a means to exit full screen.

As a result, we need to ensure that we listen for the escape key at keydown
rather than keyup, and additionally prevent the default browser behaviour.

This is a workaround to http://yuilibrary.com/projects/yui3/ticket/2532616
and, should that issue be fixed, it should be removed.
2013-01-28 10:35:26 +00:00
Dan Poltawski
8cd57fb26a Merge branch 'MDL-37430-master' of github.com:damyon/moodle 2013-01-22 11:53:10 +08:00