Commit graph

333 commits

Author SHA1 Message Date
samhemelryk
7f09335135 output MDL-19799 Fixed up some set_url calls as well as fixing some regressions caused by recent upgrades 2009-10-21 04:23:35 +00:00
tjhunt
7d4dfc481e quiz: MDL-19145 Safe Exam Browser integration.
This is a better alternative to 'secure' mode.

It needs to be enabled by the administrator.
2009-09-30 10:57:57 +00:00
nicolasconnault
ca4b4f8f7c MDL-19813 Upgraded calls to link_to_popup_window() 2009-08-20 13:17:07 +00:00
nicolasconnault
825116fb22 MDL-19813 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:16:08 +00:00
tjhunt
d4a03c00ea themes & blocks - MDL-19077 & MDL-19010 blocks are now printed by the theme
The code to print blocks in now in theme layout.php files. (Or in
moodle_core_renderer::handle_legacy_theme)

Code for printing blocks everywhere else has been stripped out.
(Total diffstat 1225 insertions, 2019 deletions)

The way the HTML for a block instance is generated has been cleaned
up a lot. Now, the block_instance generates a block_contents
object which gives a structured representation of the block,
and then $OUTPUT->block builds all the HTML from that.

How theme config.php files specify the layout template and block
regions by page general type has been changed to be even more flexible.

Further refinement for how the theme and block code gets initialised.

Ability for scrits to add 'pretend blocks' to the page. That is,
things that look like blocks, but are not normal block_instances.
(Like the add a new block UI.)

Things that are still broken:
 * some pages in lesson, quiz and resource. I'm working on it.
 * lots of developer debug notices pointing out things that
   need to be updated.
2009-07-09 07:35:03 +00:00
tjhunt
d436d197d1 MDL-19690 - the last lot of $CFG->pixpath to $OUTPUT->old_icon_url
Including MDL-19693

RIP $CFG->pixpath
2009-07-03 07:55:30 +00:00
tjhunt
4096752d1d MDL-19690 - first 53 $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-02 10:06:39 +00:00
skodak
a8c31db2a3 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:47:18 +00:00
samhemelryk
e30d7983a4 cssclasses MDL-17525 Added next and previous classes to quiz pagination links 2009-06-10 08:35:45 +00:00
tjhunt
44d1cba4af quiz: MDL-18635 log every single hit to mod/quiz/attempts.php
I don't know why the quiz only logged every 10 minutes. No other part of Moodle worked like that. However, it has always been like that and I did not have a good reason to change it until now.

What was a problem becuase it made it harder to catch people doing a primitive DOS attack against the server by hitting Reload repeatedly.
2009-03-23 01:59:30 +00:00
tjhunt
84e628a027 quiz settings: MDL-18485 Improve quiz settings form
* Reorder form fields to group things more logically.
** and on the corresponding admin page too.

* Set some options to be 'Advanced' by default:
** Apply penalties.
** Each attempt builds on the last.
** Decimal places for question grades.
** The five 'Extra restrictions on attempts' settings. (password, etc.)
* Admins can still change this to suit their institiution at Administration > Plugins > Activity modules > Quiz.
* These new defaults are applied if the admin had not previously set any fields to be advanced.

* Disable some filds when they are not applicable:
** Grading method, if num attempts = 1
** Penaly scheme, if adaptive mode = no
** Each attempt builds of last, if num attempts = 1
** Review after quiz closed options, if no close date.
** Delay between 1st and 2nd attempts, if num attempts = 1
** Delay between later attempts, if num attempts < 3

* Convert quiz.timelimit to be in seconds, for consistency, and ready for the new duration field type (MDL 18500).
** Including ensuring that backup and restore is backwards compatible.

* MDL-5537 New setting, questiondecimalpoints, so, for example, you can show the quiz grade as an integer, but have fractional question grades.
** There is a 'Same as overall decimal points' option, which is the default.

* Improve some field labels.

* Make corresponding changes in the help files.
2009-03-10 08:39:51 +00:00
tjhunt
4299df1daf quiz editing: Refactor the editing actions to make functions in editlib.php for most of them.
In the process, do MDL-17456, move/delete questions by question id rather than position, for greater robustness.
2009-02-27 08:45:05 +00:00
tjhunt
2a874d65ce quiz editing: MDL-17455 refactor the editing code to use the locallib functions to print the icons.
Also, use the new method in the random question class to get the list of random questions reliably.
2009-02-11 10:08:07 +00:00
tjhunt
edd5246bdd quiz editing: MDL-17416 Clean layout when starting a new attempt. 2009-01-07 09:26:47 +00:00
tjhunt
4e6f553d43 quiz editing: MDL-15903 fix the code that updates $quiz->sumgrades,
so we only update the database when something changes, not on every page view.
2008-12-05 05:08:37 +00:00
pilpi
38faf00984 quiz editing: MDL-17418 added another random question preview link 2008-11-28 18:49:28 +00:00
pilpi
7b2c3bde9e quiz editing: MDL-17451 CSS and whitespace fixes to truncate overlong question category name
Tested on opera 9.27, IE6, Firefox 3 on Ubuntu Linux 8.04
2008-11-28 15:16:40 +00:00
pilpi
1b90bb45c5 quiz editing: MDL-17284 removed a print_r() call that must have been forgotten there when debugging 2008-11-26 15:36:34 +00:00
pilpi
0ff9576738 quiz editing: MDL-17284 converted a space to an &nbsp; to keep preview label on same line with its icon. 2008-11-26 15:35:08 +00:00
tjhunt
2e883810d3 quiz editing: MDL-17296 refactor print_timing_information to avoid duplicating code from mod/quiz/accessrules.php 2008-11-26 04:52:46 +00:00
tjhunt
1332ce5397 quiz unittests: MDL-17295 start writing unit tests for some of mod/quiz/locallib.php - and fix the bugs they revealed! 2008-11-23 12:46:51 +00:00
pilpi
414d5bfb7e quiz editing: MDL-17290 doc comments were updated 2008-11-22 15:28:46 +00:00
tjhunt
fa583f5f6e quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.
This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.
2008-11-20 06:59:11 +00:00
tjhunt
2ddba27f0a Correct comment. 2008-09-26 05:57:55 +00:00
tjhunt
739b07112e MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
jamiesensei
c8b2ab1b00 MDL-7308 "Check all the DB columns used to store grades, and make sure they all use a consistent type." Since quiz->sumgrades is now string "0.00000" (quiz->sumgrades) no longer evaluates as false. Changing to (quiz->sumgrades != 0) 2008-09-08 10:35:14 +00:00
tjhunt
45da388f6d MDL-15452 - forgot to check a DB call for errors. 2008-09-04 04:52:29 +00:00
jerome
40f6f97f76 MDL-16307: move quiz_get_best_grade() in lib.php, and fix the DB request of quiz_user_complete() 2008-09-02 10:06:17 +00:00
tjhunt
62e76c6766 MDL-16263 A way for students to flag/bookmark, particular questions during a quiz attempt for later review.
This is an initial implementation that is now at a working state, but with a few things left to do. It seemed like a good idea to commit it before leaving work on Friday night.
2008-08-29 10:08:27 +00:00
tjhunt
e2249afe2b MDL-7010 Convert mod\quiz\config.html to mod/quiz/settingstree.php using the new admin tree system. 2008-08-26 01:05:01 +00:00
tjhunt
f88fb62c40 MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors. 2008-08-15 06:42:38 +00:00
lfrodrigues
2044a2b26f MDL-10107 - Removed old email_to_user with we still arround and added default message processor for user,
adminuser and on messagelib
2008-08-02 00:04:29 +00:00
moodler
3b120e464f MDL-10107 - First check-in of Messaging 2.0 code from Luis Rodrigues, GSOC student.
This new messaging system replaces all the various email_to_user() calls.
They are now replaced by events triggers, and the messages are then
processed centrally according to user preferences and sent to one or more
processors (email, popup, jabber etc...)

This code is not finished yet, a lot of work still has to be done on the
interface.  However, the basic structure is there and should be working.
Luis and I will be reviewing and polishing this heavily in the next few weeks.
2008-07-24 08:38:03 +00:00
tjhunt
b55797b8cc MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase. I was able to factor out some commonalities with review.php along the way. 2008-07-15 15:30:39 +00:00
jamiesensei
98f38217bb MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" 2008-07-11 07:27:14 +00:00
tjhunt
66d07f81a1 MDL-15538 - Rework attempt.php to use attemptlib.php - I had broken processing of submitted responses. Hopefully it is fixed again now. 2008-07-08 18:22:18 +00:00
tjhunt
1aab356193 MDL-15539 - Rework review.php to use attemptlib.php - clean up how review options are calculated, fix up some comments, and make some requires more robust. 2008-07-08 17:46:59 +00:00
tjhunt
78e7a3dd5d MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase - quite a lot of progress, sorry I am committing this as a big lump, but it took me a while to get the code back to a working state.
MDL-15537 - create oo attemptlib.php to hold shared code between attempt, summary and review.php
MDL-15541 - Refactor starting a new attempt into a new file startattempt.php
MDL-15538 - Rework attempt.php to use attemptlib.php
2008-07-08 16:33:47 +00:00
jamiesensei
26a29b1ab5 MDL-15250 "Adding a new function quiz_question_action_icons that outputs a string of html" 2008-06-15 11:52:07 +00:00
skodak
245ac55791 MDL-14679 last forgotten bits of dml conversion 2008-06-09 19:48:24 +00:00
skodak
dfee5a9a8a MDL-15113 converted some skipped dml stuff 2008-06-09 12:18:13 +00:00
nicolasconnault
9cf4a18b41 MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0
2008-06-09 10:00:35 +00:00
tjhunt
97344ae331 Improve PHPdocs on a function. 2008-04-23 14:31:21 +00:00
jamiesensei
58ffdbb883 MDL-14471 - when attempt data is generated by a script then sometimes quiz_get_latest_attempt_by_user fetches the wrong attempt since timestart for the attempt is not a second apart from the last attempt - "patch to quiz/locallib.php function quiz_get_latest_attempt_by_user which makes the query simpler and also makes it more robust.
In the case that there are two attempts started in the same second, which can happen if you are generating random attempt data then the id field is used to tell which is the later attempt."
2008-04-23 06:45:11 +00:00
jamiesensei
e89e09d21d MDL-14283 attempt in mdl_question_states is always 1 - typo in attempt.php introduced in Tim's access rules refactor meant that attempt in quiz_attempts table was always set to 1. This meant that only one attempt was shown on the quiz/view.php page as well as causing other problems. 2008-04-09 13:01:40 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt
6b84dd19ac Replace some tabs that managed to slip in. What is Eclipse playing at? 2008-03-07 12:36:16 +00:00
tjhunt
c52c62d1b1 MDL-13806 - Refactor all the code that implements the rules for whether students can attempt the quiz now into some classes.
Resource page now done as well. That should be everything.
2008-03-07 12:33:07 +00:00
tjhunt
f0079c3e81 MDL-13738 - Invalid context developer debug notice in manual grading. 2008-02-29 16:22:15 +00:00
tjhunt
255985f17b MDL-12776 - Quiz email notification and separate groups mode - student not in group -> all teachers get email I have changed it so that if the quiz is set to groups mode, and if the student is not in a group, then only teachers with 'accessallgroups' get emailed. 2008-02-28 22:44:12 +00:00