Commit graph

95983 commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
712a321db2 MDL-67077 h5p: php74 fix (curly braces) for the H5P lib
This has been sent also upstream @ https://github.com/h5p/h5p-php-library/pull/69
2019-11-16 20:04:04 +01:00
Eloy Lafuente (stronk7)
6783adc239 MDL-67035 tags: fix nested ternary operators to be php74 compliant
Nesting ternary operators without explicit parentheses is deprecated:

    // Code like
    $a ? $b : $c ? $d : $e
    // should be replaced by (current interpretation)
    ($a ? $b : $c) ? $d : $e
    // or (likely intended interpretation)
    $a ? $b : ($c ? $d : $e)
2019-11-16 20:03:47 +01:00
Eloy Lafuente (stronk7)
b69028e626 MDL-67034 google: php74 fix (curly braces) for the Google-Client lib 2019-11-16 20:03:37 +01:00
Eloy Lafuente (stronk7)
15c8da60d4 MDL-67034 adodb: php74 fix (curly braces) for the AdoDB lib 2019-11-16 20:03:37 +01:00
Eloy Lafuente (stronk7)
6b83451251 MDL-67034 horde: php74 fix (curly braces) for the Horde lib 2019-11-16 20:03:37 +01:00
Eloy Lafuente (stronk7)
9e458d8fe8 MDL-67031 s3: php74 fixup for class S3 v0.5.1 2019-11-16 20:03:27 +01:00
Eloy Lafuente (stronk7)
30e5aca81d MDL-67030 htmlpurifier: add details to readme 2019-11-16 20:03:18 +01:00
Eloy Lafuente (stronk7)
9fbe33a6a2 MDL-67030 htmlpurifier: php74 fixup for htmlpurifier v4.10.0
This simply applies this pull request:

https://github.com/ezyang/htmlpurifier/pull/224

straight to our library. Once there is some new htmlpurifier
release available (>v4.11.0) we'll be back upstream because
the fix will be included.
2019-11-16 20:03:18 +01:00
Eloy Lafuente (stronk7)
f94b2e7ade MDL-67029 bennu: add details to readme 2019-11-16 20:03:08 +01:00
Eloy Lafuente (stronk7)
ce17207715 MDL-67029 bennu: php74 fixup for bennu lib 0.1-custom 2019-11-16 20:03:08 +01:00
Eloy Lafuente (stronk7)
ba5aa5fe19 MDL-67017 typo3: add details to readme 2019-11-16 20:02:59 +01:00
Eloy Lafuente (stronk7)
052a282ec4 MDL-67017 typo3: php74 fixup for typo3 lib 4.7.19
We are using a really outdated Typo3 library (2014) already patched
for php73 support. Plus, probably, we'll be soon removing it from core.

So we have decided to, instead of upgrade, apply the needed php74 fixes.
2019-11-16 20:02:59 +01:00
Eloy Lafuente (stronk7)
c3d8c419e5 MDL-66964 markdown: php74 fixup for markdown lib 1.8.0
Note this is different from the upstream commit:

a35858f040

because it was conflicting so only the cases corresponding
to our current 1.8.0 version have been modified.

This commit is trivial, just a pure curly to square replacement.
2019-11-16 20:02:42 +01:00
Eloy Lafuente (stronk7)
d547735f2f weekly back-to-dev release 3.9dev 2019-11-16 18:03:02 +01:00
Eloy Lafuente (stronk7)
bc4c075960 NOBUG: Change travis.yml back to master 2019-11-16 17:54:08 +01:00
Eloy Lafuente (stronk7)
f968cd44e8 Moodle release 3.8 2019-11-16 17:54:08 +01:00
Eloy Lafuente (stronk7)
4da834dcdc NOBUG: Change travis.yml to MOODLE_38_STABLE 2019-11-16 17:54:08 +01:00
Jun Pataleta
dc51037136 Merge branch 'MDL-67281' of https://github.com/stronk7/moodle 2019-11-16 17:44:05 +08:00
Eloy Lafuente (stronk7)
12f310e545 MDL-67281 forum: don't show discussion creation time twice
The discussion creation time (or first post) is being shown
both in the "started by" and "last post" columns in forum
discussions list.

Just let's change the former to show the discussion modification
time (or last post) instead.
2019-11-15 19:11:34 +01:00
Eloy Lafuente (stronk7)
52d3d6f540 Moodle release 3.8rc1 2019-11-15 12:30:52 +01:00
Jun Pataleta
e716c1ea9e Merge branch 'MDL-67269-master' of git://github.com/andrewnicols/moodle 2019-11-15 12:38:54 +08:00
Andrew Nicols
fb803f8854 Merge branch 'MDL-67268-master' of git://github.com/mihailges/moodle 2019-11-15 12:08:33 +08:00
Mihail Geshoski
c7cb3b297b MDL-67268 mod_forum: Group and label radio buttons in forum grader 2019-11-15 12:05:59 +08:00
Andrew Nicols
630a1b0e01 MDL-67269 mod_forum: Capture form submission in grading panel 2019-11-15 11:47:37 +08:00
Andrew Nicols
f45a2860e5 Merge branch 'MDL-67265' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-15 10:35:00 +08:00
Mathew May
4e796e2205 MDL-67265 core: Set max-height on toast wrapper 2019-11-15 09:21:06 +08:00
Jake Dallimore
891e027cf1 Merge branch 'MDL-67241-master' of git://github.com/lameze/moodle 2019-11-14 16:34:28 +08:00
Jake Dallimore
324258e5f5 Merge branch 'MDL-67144-integration' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-14 15:17:24 +08:00
Mathew May
fc741e030e MDL-67144 mod_forum: If no users exist do not show the grading interface 2019-11-14 15:00:30 +08:00
Jun Pataleta
ff175fce22 Merge branch 'MDL-67246-master' of git://github.com/jleyva/moodle 2019-11-14 14:34:17 +08:00
Jake Dallimore
0460d21b28 Merge branch 'MDL-67207-master' of git://github.com/andrewnicols/moodle 2019-11-14 14:27:42 +08:00
Jun Pataleta
e9f63f3fc0 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-14 12:37:22 +08:00
Andrew Nicols
c3777543a6 MDL-67116 course: Restore removed line
This line was inadvertently removed in a previous commit.
2019-11-14 11:43:37 +08:00
Andrew Nicols
8a0b9b1830 Merge branch 'MDL-67250-master-httpswwwroot' of git://github.com/mudrd8mz/moodle 2019-11-14 10:54:14 +08:00
Simey Lameze
0e287a0e7b MDL-67241 mod_forum: raise memory limit when exporting 2019-11-14 10:12:15 +08:00
Adrian Greeve
b6343156f9 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-14 09:03:31 +08:00
Andrew Nicols
0a5a2ca89b MDL-67116 course: Strict empty string check required
In PHP the following are true:

    assert('' == '');
    assert(0 == '');
    assert(null == '');

The options in the course completion settings are now:

    ''    => none selected
    [int] => itemnumber of activity course completion item.

In the case where the itemnumber was 0  this was being incorrectly
evaluated as an empty string due to the implicit cast to int of the
empty string:

    (int) '' === 0

As a result, the non-strict comparison means that the following are
identical:

    assert(0 == '');
    assert(0 == (int) '');
    assert(0 == '0');

Changing the comparison to a strict comparison is correct because it
ensures the type consitency between the empty string value, and the int
of itemnumber 0. It is safe because the value always comes from the
form, where an int is always returned, and not the DB, where a string is
returned.
2019-11-14 08:59:56 +08:00
Eloy Lafuente (stronk7)
ccd5f606c3 Merge branch 'MDL-67248-master' of git://github.com/cescobedo/moodle 2019-11-14 01:12:01 +01:00
David Mudrák
469d4b7f35 MDL-67250 setup: Revert removal of the httpswwwroot setting
It is still used widely in the plugins that would stop working suddenly
without being warned via a debugging message. We must keep it forever as
an alias for the wwwroot.
2019-11-13 19:58:10 +01:00
cescobedo
f12d708e61 MDL-67248 filter_displayh5p: Add new description on filter 2019-11-13 18:36:09 +01:00
Juan Leyva
666de97917 MDL-67246 admin: Return course color settings for external clients 2019-11-13 15:33:20 +01:00
Jun Pataleta
f136aa1933 Merge branch 'MDL-67231-master' of git://github.com/andrewnicols/moodle 2019-11-13 16:00:16 +08:00
Jun Pataleta
289c9e14c4 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-13 15:31:03 +08:00
Andrew Nicols
799418ad12 MDL-67207 forum: Reset focus after closing grade viewer 2019-11-13 14:30:54 +08:00
Andrew Nicols
21900f035e MDL-67207 forum: Return focus when closing expanded discussion 2019-11-13 14:30:54 +08:00
Andrew Nicols
c50bc1bf7c MDL-67207 core: Use focus lock manager in modals 2019-11-13 14:30:54 +08:00
Andrew Nicols
4395ef464d MDL-67207 forum: Reset focus after closing grader 2019-11-13 14:30:54 +08:00
Andrew Nicols
7ede47b738 MDL-67207 forum: Lock focus in grader 2019-11-13 14:30:48 +08:00
Andrew Nicols
dcdcc12cb2 MDL-67207 core: Add new ARIA focus locker
This is based on code and examples provided in the ARIA specification
https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html
2019-11-13 14:30:32 +08:00
Adrian Greeve
23ac81e396 Merge branch 'MDL-67178' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-13 14:30:06 +08:00