Commit graph

22 commits

Author SHA1 Message Date
tjhunt
9c3ea65295 XHTML strict 2009-04-23 06:25:51 +00:00
tjhunt
c468795ce9 switch roles: MDL-18132 New Role allow switches page finished.
I also set up a reasonable set of default allows, including setting up some sensible allow_overrides, whatever the rant in MDL-15841 says.
2009-03-25 04:20:57 +00:00
tjhunt
91eb445ca0 switch roles: MDL-18132 Convert allow override page to use the shared code. 2009-03-25 02:17:14 +00:00
tjhunt
9654643e88 switch roles: MDL-18132 Refactor role allow assign page
This is ready to eliminate the duplication between this and role allow override, and the soon-to-be-written role allow switch page.
2009-03-25 01:50:55 +00:00
tjhunt
bb0e7937ec roles admin: Fix notice when creating a role with no legacy type. 2009-03-04 02:46:48 +00:00
skodak
19a4a32e53 MDL-17942 fixed some incorrect uses of exceptions and typos 2009-01-17 23:24:31 +00:00
tjhunt
a90d7cf93d roles ui: Fix notices and XHTML strict. 2008-12-11 09:08:20 +00:00
tjhunt
e494fbf171 override roles: MDL-8313 followup - don't show capabilities you can't change the override of in basic mode. 2008-11-24 08:19:33 +00:00
tjhunt
abfc0304e1 role assign: Don't get duplicate records in potential_assignees_below_course user selector 2008-11-24 04:55:57 +00:00
tjhunt
e6a3587c59 role assign: MDL-17323 Show users from parent contexts ... Refine group labels again. 2008-11-21 06:26:42 +00:00
tjhunt
490740d6cb role assign: MDL-17323 Show users from parent contexts ... Refine group labels. 2008-11-21 06:19:52 +00:00
tjhunt
698ae7eb24 role assign: MDL-17323 Show users with the role in a parent context as disabled opitons in the existing users box 2008-11-21 05:46:45 +00:00
tjhunt
bed9cec80b define roles: MDL-16966 etc. polishing the new roles UI following a meeting with Martin.
* Move the show/hide advanced button a bit down the page.
* Improve save button caption when creating a role.
* Don't show defaults on the basic define roles screen.
* Explain the background shading on the advanced roels screen.
* Fix the problem with the risks link to Moodle docs.
* Help icon by the permissions column heading.
* Tables with rotated <th>s, make them vertical-align: bottom.
* Rename explain.php and explainhascapability.php to check.php and explain.php
* Tool tips on the number headers in the explain table.
* Explain table - role names were missing.
* Allow link_to_popup_window to work with full URLs.
2008-11-20 09:57:20 +00:00
tjhunt
0c90f98788 formslib: MDL-13210 - partial - try to make validation errores less annoying.
I have made them float right, and reduced the padding on the red box, so they don't cuause the height of the form to change so much, if the error fits to the right of the form control. I realise that some people may not like this, which I why I have done this in head only for now. I will revert this if told to.
2008-11-20 08:30:35 +00:00
tjhunt
4659454ac6 manage roles: MDL-8313 fix bugs with safe overrides. 2008-11-18 08:08:18 +00:00
tjhunt
bbdb7070ca manage roles: MDL-8313 Provide a basic mode for the manage roles page.
* New basic define roles mode, with just an Allow checkbox for each capability.
* Button to toggle this form to/from advanced mode.
* Also, a separate mode for viewing a role definition, rather than just showing disabled checkboxes.
* Now duplicating a role just takes to you a pre-populated add role form, so you can double-check things before saving the new role.
* Deleting a role is now logged.
* Role reordering code cleaned up.
* You can now no longer delete the last role that has admin permissions.
* This includes a general refactor of manage.php, which eliminates manage.html, and splits of define.php.
2008-11-18 07:10:00 +00:00
tjhunt
e9abdd1b84 Fix typo. 2008-11-14 11:48:29 +00:00
tjhunt
f4acee5d78 role manage ui: MDL-8313 First version of the basic/advanced role define page.
This is being separated from manage.php. This code is only partly working. It displays (most) of a role definition, but does not yet let you save changes. However, I wanted to commit it before going home on Friday night. Since this is new code, it won't break anything.
2008-11-14 11:46:01 +00:00
tjhunt
a4df1cbbe5 role manage ui: MDL-8313 Refactoring and clean-up prior to basic/adv manage page. 2008-11-14 10:38:06 +00:00
tjhunt
8aee9bcc27 role override ui: MDL-8313 basic mode + toggle + usability improvements
* Basic mode just hides the prohobit column. Sadly that is all we can do.
* Button to toggle in and out of advanced mode, with user_perference.
* The permission you are selected is now on the page as a label, rather than just being in a tool-tip. (Not pretty, but helpful, I think. I may change my mind on this.)
* You can click anywhere in the table cell, rather than having to hit the radio button exactly.
* Brief instructions at the top of the page.
* Submit buttons both top and bottom of the page.
2008-11-14 05:46:27 +00:00
tjhunt
c6505f1eaa role override ui: MDL-8313 refactor the page in preparation for making an non-advanced mode. 2008-11-14 03:28:15 +00:00
tjhunt
1e8e46879c roles interface: Code reorganisation and adding boilerplate comments.
I have collected code that used to be in lib/adminlib.php, lib/accesslib.php and user/selector/lib.php into a new admin/roles/lib.php file.

And I added standard GPL and Moodle comments to all the files in admin/roles.
2008-11-13 04:07:01 +00:00