Commit graph

98480 commits

Author SHA1 Message Date
Bas Brands
9ffeab1ad1 MDL-67831 core_message: use space available for message index page
- the prevents the message reply box from being out of view when
a user has many conversations.
2020-07-23 11:34:44 +02:00
AMOS bot
7bad9a9f15 Automatically generated installer lang files 2020-07-23 00:07:49 +00:00
Victor Deniz Falcon
5a003a1da9 Merge branch 'MDL-65819-39' of https://github.com/paulholden/moodle into MOODLE_39_STABLE 2020-07-22 19:00:14 +01:00
Ferran Recio
9e96129104 MDL-55299 mod_feedback: fix quoted values donwload 2020-07-22 19:23:46 +02:00
Paul Holden
5068d59b13 MDL-69311 dataformat: correct license docblock.
When this class was implemented in 8844cb82, it incorrectly set the
license to Moodle Workplace.
2020-07-22 10:44:38 +01:00
Andrew Nicols
bf9c4ab68a MDL-69138 behat: Update session->visit() to use visit step 2020-07-22 16:46:51 +08:00
Andrew Nicols
44022305cc MDL-69138 behat: Add "I visit :localurl" step 2020-07-22 16:46:51 +08:00
Jun Pataleta
0595cfb07d Merge branch 'MDL-52052-39' of git://github.com/mihailges/moodle into MOODLE_39_STABLE 2020-07-22 13:47:06 +08:00
Jun Pataleta
c8098c7a80 Merge branch 'MDL-68178-39' of git://github.com/mihailges/moodle into MOODLE_39_STABLE 2020-07-22 12:58:58 +08:00
Eloy Lafuente (stronk7)
2e71c132fe Merge branch 'MDL-69160-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE 2020-07-21 23:29:36 +02:00
Bas Brands
7c3522f902 MDL-69111 mod_forum: forum grading on small viewports
- changes to make the forum grading UI accessible in small
viewports to meet criterion 1.4.10 Reflow.
2020-07-21 17:43:03 +02:00
David Mudrák
4dcb3165e7 MDL-68647 forum: Add index over posts privatereplyto field
This is to further improve the performance of searching of posts related
to the given user. Once both userid and privatereplyto are indexed, the
query planner can use the merged index to search for posts records.
2020-07-21 11:51:20 +02:00
David Mudrák
4fbe8bec4a MDL-68647 forum: Improve the SQL performance in the privacy provider
The idea here is to replace the existing LEFT JOINs and
OR / IS NOT NULL conditions with INNER JOINs and ANDs. So we gather the
discussions data from all three areas in individual queries, make their
UNION. The GROUP BY was present before and maybe it is not even needed
any more (due to how UNION works) but it should not hurt to keep it.

This leads to significantly improved performance.
2020-07-21 11:48:35 +02:00
David Mudrák
4a723a329e MDL-68647 forum: Add missing advanced grading library inclusion
The method get_grading_manager() is called in the file so make sure the
library is loaded. Without it, the forum's privacy provider unit test
ended with error.

Not directly related to the issue, but noticed while working on it.
2020-07-21 11:48:35 +02:00
Adrian Greeve
592b8980aa Merge branch 'MDL-67657-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE 2020-07-21 14:48:10 +08:00
Ferran Recio
1e63a97698 MDL-68423 message: avoid self-xss when send a message 2020-07-20 19:52:58 +02:00
Eloy Lafuente (stronk7)
9d41810bed Merge branch 'm39_MDL-67440' of https://github.com/danmarsden/moodle into MOODLE_39_STABLE 2020-07-20 17:08:21 +02:00
Leon Stringer
8cdebcf4e0 MDL-60501 themes: Fix closing <h4> in template
In site admin pages (/admin/search.php) <h4> elements were generated
with an incorrect second opening <h4> instead of a closing </h4>.
2020-07-20 15:48:50 +01:00
Bas Brands
9744e6e8cb MDL-66670 theme_boost: list bullet styling
Ensure lists with bullets are not cut off
2020-07-20 14:49:08 +02:00
Jake Dallimore
f4d6bd1188 MDL-69319 mod_lti: style and docs changes in external tests 2020-07-20 15:00:25 +08:00
Jake Dallimore
d8c8c75ec4 MDL-69319 mod_lti: replace try/catch with expectException in ext tests 2020-07-20 15:00:25 +08:00
Jake Dallimore
9eaaa8997b MDL-69319 mod_lti: remove unused vars from externallib_test 2020-07-20 15:00:24 +08:00
Jake Dallimore
ef2a7d7302 MDL-69319 mod_lti: move test data generation out of common setup 2020-07-20 15:00:24 +08:00
Jake Dallimore
b660b92b3f MDL-69319 mod_lti: call clean_returnvalue in external tests 2020-07-20 15:00:24 +08:00
Mihail Geshoski
87ae4833c4 MDL-68178 auth: CSRF protection for the resend confirmation email form
Credit to Chandra Kishor.
2020-07-20 12:36:29 +08:00
Adrian Greeve
4f9d34da81 Merge branch 'MDL-69113_39' of https://github.com/jonof/moodle into MOODLE_39_STABLE 2020-07-20 10:37:03 +08:00
Mihail Geshoski
13ad9d1f5b MDL-52052 gradeimport_csv: Do not skip rows with blank user fields 2020-07-20 08:55:05 +08:00
Eloy Lafuente (stronk7)
8cf328dc54 Merge branch 'MDL-69278-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE 2020-07-18 11:56:01 +02:00
Paul Holden
af1f371aa7 MDL-65819 message: send contact requests using recipient language. 2020-07-17 13:33:20 +01:00
Sara Arjona
3e78b603a5 weekly release 3.9.1+ 2020-07-16 21:28:34 +02:00
Andrew Nicols
50da793d5b MDL-67657 behat: Open course with editing using URL
This is a huge performance improvement for behat.

The current set of steps loads the page
It then looks for the Classic/Clean version of the settings menu
If it fails to find it looks for the Boost Cog
Then it clicks the "Turn editing on" button

This can take a substantial period.

We do not actually need to run these steps as we are able to jump
straight to the URL. We already have access to the sesskey value
required to do this.

There is not loss in testing functionality because the actual testing of
the Turn editing functionality is tested in other places sufficiently.
2020-07-16 11:06:43 +08:00
Andrew Nicols
4affbe94be MDL-67657 behat: Convert existing uses of executeScript 2020-07-16 11:06:31 +08:00
Andrew Nicols
d18eacbd35 MDL-67657 behat: Add wrapper for JS execution 2020-07-16 11:05:32 +08:00
Jun Pataleta
3de3755281 Merge branch 'MDL-69215-39-2' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE 2020-07-16 09:42:52 +08:00
Andrew Nicols
04a1611139 MDL-69278 behat: Correct variable name 2020-07-16 08:29:57 +08:00
Andrew Nicols
0b5889d299 MDL-69278 behat: Mark tests as failed when unable to start Session 2020-07-16 08:29:57 +08:00
Andrew Nicols
aa6bf0f367 MDL-69215 output: Correct use of icon_system::instance 2020-07-16 07:30:32 +08:00
Andrew Nicols
7164e1626e MDL-69215 output: Correct font awesome for themes 2020-07-16 07:30:32 +08:00
Eloy Lafuente (stronk7)
a869415180 Merge branch 'MDL-69214-39' of https://github.com/paulholden/moodle into MOODLE_39_STABLE 2020-07-16 00:01:19 +02:00
Eloy Lafuente (stronk7)
b39f2de8ad Merge branch 'MDL-69165-39' of https://github.com/HuongNV13/moodle into MOODLE_39_STABLE 2020-07-15 23:47:24 +02:00
Charles Fulton
b02b1f3ea9 MDL-69074 admin: ensure consistent default for getremoteaddrconf 2020-07-15 19:05:52 +02:00
Sara Arjona
72ad5d94ea Merge branch 'MDL-68605_39' of https://github.com/t-schroeder/moodle into MOODLE_39_STABLE 2020-07-15 18:52:46 +02:00
Sara Arjona
1c2358de43 Merge branch 'MDL-68210-39' of https://github.com/snake/moodle into MOODLE_39_STABLE 2020-07-15 18:19:44 +02:00
Shamim Rezaie
ba56dfb574 MDL-66707 mod_forum: do not blindly mark discussion replies as read 2020-07-15 22:27:10 +10:00
Sara Arjona
da48e72353 Merge branch 'MDL-67671_39_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_39_STABLE 2020-07-15 14:11:46 +02:00
Sara Arjona
3c5757b0e2 Merge branch 'MDL-57678-39' of git://github.com/junpataleta/moodle into MOODLE_39_STABLE 2020-07-15 12:56:20 +02:00
Jun Pataleta
e1a310bde7 MDL-57678 core_course: Remove padding of nbsp's on category names
Padding nested course categories by space to make them render in a tree
structure does not really make a lot of sense as they are already being
rendered as full paths. It's simpler to show them without the
indentation.
2020-07-15 18:27:02 +08:00
Sara Arjona
a040f29f03 Merge branch 'MDL-69068-39' of git://github.com/andrewnicols/moodle into MOODLE_39_STABLE 2020-07-15 12:20:30 +02:00
Andrew Nicols
3f3262c76e MDL-69068 behat: Allow singular, pivotted data generators 2020-07-15 15:27:31 +08:00
Andrew Nicols
5018c4e4db MDL-69068 behat: New step to support singular generators 2020-07-15 15:27:31 +08:00