Commit graph

1886 commits

Author SHA1 Message Date
Juan Leyva
d96d72955e MDL-58415 mod_lesson: Fix code styles and missing declaration
Found by the integrator review:
- Some incorrect code style declaration and phpdocs
- Missing $USER declaration
- Incorrect use of $lesson (should be $this)
2017-04-20 09:58:48 +02:00
Juan Leyva
9c543014a2 MDL-58415 mod_lesson: Add missing answer fields
There were a couple of fields missing when returning the complete
answer information required for offline usage.
2017-04-20 09:58:47 +02:00
Juan Leyva
dd60892155 MDL-58415 mod_lesson: EOL var must be always numeric
Otherwise it will break the Web Service return description.
2017-04-20 09:58:47 +02:00
Juan Leyva
f1cdd978aa MDL-58415 mod_lesson: Out of time should be a string
process_eol_page expects a string, right now we are passing a boolean.
We should convert it to the correct string when is set to true, that is
‘normal’
2017-04-20 09:58:46 +02:00
Juan Leyva
a33c0e30eb MDL-58415 mod_lesson: Return always allowofflineattempts
We need this field always to be able to display if the lesson is
available or not for download
2017-04-20 09:58:46 +02:00
Juan Leyva
0fc1f24b12 MDL-58415 mod_lesson: Handle correctly review mode 2017-04-20 09:58:45 +02:00
Juan Leyva
0259109fb5 MDL-58415 mod_lesson: Avoid API http redirections
Deep in the lesson API there are some http redirections in special
pages like clusters.
We need to handle it via new parameters to avoid redirections.
2017-04-20 09:58:44 +02:00
Juan Leyva
16ca026c4b MDL-58415 mod_lesson: Force int type for calculated progress
Under some circumstances the value returned by the function needs
casting.
2017-04-20 09:58:44 +02:00
Dan Poltawski
cdfcfb1f8c Merge branch 'MDL-58498-master' of git://github.com/ryanwyllie/moodle 2017-04-20 07:44:56 +01:00
Juan Leyva
78681d03b0 MDL-58431 mod_lesson: Fix error in random jumps on first visit
Random jumps to content pages were not working when they were set in
the first page.
This was caused because the page where the jump was, was not being
marked as visited before calculating the jump.
2017-04-19 17:47:21 +02:00
Jake Dallimore
273d310601 MDL-58138 completion: Fixes for a number of small issues. 2017-04-19 11:41:57 +08:00
Jake Dallimore
8db355c58f MDL-58138 tests: unit and behat tests covering bulk and default tabs
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Marina Glancy
7f53e8aa22 MDL-58267 completion: allow to set default activity completion
Part of MDL-58138 epic
2017-04-19 08:54:35 +08:00
Marina Glancy
06cdda468a MDL-58139 completion: bulk update completion
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Jake Dallimore
b54bcddda4 MDL-58190 completion: callbacks to get completion rule descriptions
- Activities can have their custom completion rules added to cm_info
through the get_coursemodule_info callback.
- Descriptions of a modules active completion rules can be fetched using
the component callback mod_xxx_get_completion_active_rule_descriptions
which takes in a cm_info object and returns an array of strings.

Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Dan Poltawski
6a346ab440 Merge branch 'MDL-58507_master' of git://github.com/markn86/moodle 2017-04-17 10:42:48 +01:00
Mark Nelson
59391e80ad MDL-58501 mod_*: improved docs for new calendar callbacks 2017-04-12 17:43:52 +08:00
Mark Nelson
063b7ee647 MDL-58507 core: link functions with final deprecation issue 2017-04-12 12:38:51 +08:00
Ryan Wyllie
bfc8fbea97 MDL-58498 mod_lesson: no action after lesson submission
Update the action event callback to not provide an action for the user
if they have already attempted the lesson.
2017-04-11 03:26:08 +00:00
Mark Nelson
01f96180ff MDL-58504 mod_*: fixed PHPDoc return type for *_provide_event_action 2017-04-06 15:00:02 +08:00
Dan Poltawski
1e4e5c52d7 Merge branch 'MDL-55611-master' of git://github.com/danpoltawski/moodle 2017-04-04 17:07:41 +01:00
Mark Nelson
e1cd93ce20 MDL-58423 core_calendar: moved \core_calendar\event class
Part of MDL-55611 epic.
2017-04-04 11:01:49 +01:00
Cameron Ball
aa1cdff5f6 MDL-58087 mod_lesson: Apply overrides in event action callback
Part of MDL-55611 epic.
2017-04-04 11:01:39 +01:00
Jun Pataleta
12a0c74a29 MDL-58102 mod: Behat fixes
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Jun Pataleta
e44d71a6ee MDL-58102 mod: Set sensible defaults for additional completion fields
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Simey Lameze
f7c476bac5 MDL-58265 mod_lesson: remove steps using course overview block
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
fdeeaff954 MDL-58265 core_test: replace I turn editing on steps
Also remove few more unnecessary steps that redirects behat to
site home page to actually get to the course.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
c987d1b2ef MDL-58265 core_test: replace all uses of I follow course steps
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Cameron Ball
8a8bd42528 MDL-57986 mod_lesson: Add action events
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Mark Nelson
e057f279e4 MDL-57497 core_calendar: added new calendar event class
Moved calendar_event class to new location using replaceclasses.php

Part of MDL-55611 epic.
2017-04-03 11:33:55 +08:00
Mark Nelson
e9dfeec94e MDL-57434 core: deprecated xxx_print_overview() and related functions
Part of MDL-55611 epic.
2017-04-03 11:33:55 +08:00
Juan Leyva
0a34838725 MDL-57411 course: Return modules updates for teachers 2017-04-01 19:39:02 +02:00
David Monllao
85384d44c7 MDL-57757 mod_lesson: Check that there is an object 2017-03-29 12:56:33 +02:00
David Monllao
f9b99736f4 Merge branch 'MDL-57757-master' of git://github.com/jleyva/moodle 2017-03-29 12:51:46 +02:00
David Monllao
9653e19b7e Merge branch 'MDL-57754-master' of git://github.com/jleyva/moodle 2017-03-29 12:37:35 +02:00
Juan Leyva
8c21800470 MDL-57754 mod_lesson: Include missing required file
The constant LESSON_PAGE_BRANCHTABLE requires the page type file.
2017-03-29 11:31:35 +02:00
Juan Leyva
86ff8ccd22 MDL-57757 mod_lesson: Handle empty answers
This is and edge case created by a bug in the numeric question type.
2017-03-29 11:01:02 +02:00
David Monllao
3ecbebc816 Merge branch 'MDL-58329-master' of git://github.com/jleyva/moodle 2017-03-27 15:47:55 +02:00
Juan Leyva
448a488642 MDL-58329 mod_lesson: New WS function mod_lesson_get_lesson 2017-03-27 14:48:28 +02:00
Juan Leyva
a0558b5607 MDL-58329 mod_lesson: Refactor to use new exporter
Refactor existing WS to use the new summary_exporter
2017-03-27 14:42:11 +02:00
David Monllao
76e4853585 Merge branch 'MDL-57760-master' of git://github.com/jleyva/moodle 2017-03-27 13:39:44 +02:00
David Monllao
7cf5c3d54c Merge branch 'MDL-57762-master' of git://github.com/jleyva/moodle 2017-03-27 13:31:29 +02:00
Juan Leyva
2db90397f1 MDL-57759 mod_lesson: Handle offline attempts in view and WS
- Notify the user if there are previous offline attempts
- Set the offline attempts and return additional information via Web
Services
2017-03-27 13:10:01 +02:00
Juan Leyva
c6f9f06146 MDL-57759 mod_lesson: New settings for allowing offline attempts 2017-03-27 13:10:00 +02:00
Juan Leyva
635721f5c1 MDL-57762 mod_lesson: Implement the check_updates callback 2017-03-27 10:51:42 +02:00
Juan Leyva
707d50d1c8 MDL-57760 mod_lesson: New WS mod_lesson_get_pages_possible_jumps 2017-03-27 10:47:07 +02:00
Juan Leyva
87e472bd15 MDL-57759 mod_lesson: Handle offline attempts in view and WS
- Notify the user if there are previous offline attempts
- Set the offline attempts and return additional information via Web
Services
2017-03-27 10:41:09 +02:00
Juan Leyva
d874370b20 MDL-57759 mod_lesson: New settings for allowing offline attempts 2017-03-27 10:41:08 +02:00
Juan Leyva
79d5e88215 MDL-57757 mod_lesson: New WS mod_lesson_get_user_attempt 2017-03-27 10:37:21 +02:00
Juan Leyva
49e353782f MDL-57757 mod_lesson: Move user report code to function 2017-03-27 10:37:20 +02:00